mbox series

[v3,0/8] usb: Check for genXxY on host

Message ID cover.1615432770.git.Thinh.Nguyen@synopsys.com
Headers show
Series usb: Check for genXxY on host | expand

Message

Thinh Nguyen March 11, 2021, 3:42 a.m. UTC 
This series add some missing support for USB 3.2 SuperSpeed Plus detection on
the host side. A SuperSpeed Plus device can operate in gen2x2, gen2x1, or
gen1x2. The current implementation can't detect whether the device is in Gen 1
or Gen 2 speed. We can do this by matching for the lane speed exponent and
mantissa of the SSP sublink speed capability descriptor from the hub driver.

Also, the current xHCI driver is missing some reports for the default SSP
Sublink Speed capability for USB 3.2 roothub. This series also add some support
for xHCI driver detecting various SuperSpeed Plus GenXxY.

Changes in v3:
- Rebase on greg/usb-testing
- Update speed print from genXxY to Gen XxY
- Use > < operators for easier read for port minor revision fix
Changes in v2:
- Remove RFC tag
- Rebase on greg/usb-testing
- Make some updates on BOS descriptor creation base on Mathias suggestions


Thinh Nguyen (8):
  usb: core: Track SuperSpeed Plus GenXxY
  usb: core: hub: Remove port_speed_is_ssp()
  usb: core: hub: Print speed name based on ssp rate
  usb: core: sysfs: Check for SSP rate in speed attr
  usb: xhci: Init root hub SSP rate
  usb: xhci: Fix port minor revision
  usb: xhci: Rewrite xhci_create_usb3_bos_desc()
  usb: xhci: Remove unused function

 drivers/usb/core/hcd.c      |   6 +-
 drivers/usb/core/hub.c      |  97 ++++++++---
 drivers/usb/core/sysfs.c    |   5 +-
 drivers/usb/host/xhci-hub.c | 320 +++++++++++++++++++++++-------------
 drivers/usb/host/xhci-mem.c |   9 +
 drivers/usb/host/xhci.c     |   2 +
 include/linux/usb.h         |   2 +
 7 files changed, 300 insertions(+), 141 deletions(-)


base-commit: 60a35ba9141f06b67150ce3544bc595d049b0d83

Comments

gregkh@linuxfoundation.org March 23, 2021, 12:19 p.m. UTC | #1 
On Wed, Mar 10, 2021 at 07:42:35PM -0800, Thinh Nguyen wrote:
> This series add some missing support for USB 3.2 SuperSpeed Plus detection on

> the host side. A SuperSpeed Plus device can operate in gen2x2, gen2x1, or

> gen1x2. The current implementation can't detect whether the device is in Gen 1

> or Gen 2 speed. We can do this by matching for the lane speed exponent and

> mantissa of the SSP sublink speed capability descriptor from the hub driver.

> 

> Also, the current xHCI driver is missing some reports for the default SSP

> Sublink Speed capability for USB 3.2 roothub. This series also add some support

> for xHCI driver detecting various SuperSpeed Plus GenXxY.


I took the first 4 patches already and will wait for Mathias to review
the rest.

thanks,

greg k-h
Mathias Nyman March 23, 2021, 2:36 p.m. UTC | #2 
On 23.3.2021 14.19, Greg Kroah-Hartman wrote:
> On Wed, Mar 10, 2021 at 07:42:35PM -0800, Thinh Nguyen wrote:

>> This series add some missing support for USB 3.2 SuperSpeed Plus detection on

>> the host side. A SuperSpeed Plus device can operate in gen2x2, gen2x1, or

>> gen1x2. The current implementation can't detect whether the device is in Gen 1

>> or Gen 2 speed. We can do this by matching for the lane speed exponent and

>> mantissa of the SSP sublink speed capability descriptor from the hub driver.

>>

>> Also, the current xHCI driver is missing some reports for the default SSP

>> Sublink Speed capability for USB 3.2 roothub. This series also add some support

>> for xHCI driver detecting various SuperSpeed Plus GenXxY.

> 

> I took the first 4 patches already and will wait for Mathias to review

> the rest.

> 

> thanks,

> 

> greg k-h

> 


For patches 4 to 8

Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
gregkh@linuxfoundation.org March 23, 2021, 3:53 p.m. UTC | #3 
On Tue, Mar 23, 2021 at 04:36:24PM +0200, Mathias Nyman wrote:
> On 23.3.2021 14.19, Greg Kroah-Hartman wrote:

> > On Wed, Mar 10, 2021 at 07:42:35PM -0800, Thinh Nguyen wrote:

> >> This series add some missing support for USB 3.2 SuperSpeed Plus detection on

> >> the host side. A SuperSpeed Plus device can operate in gen2x2, gen2x1, or

> >> gen1x2. The current implementation can't detect whether the device is in Gen 1

> >> or Gen 2 speed. We can do this by matching for the lane speed exponent and

> >> mantissa of the SSP sublink speed capability descriptor from the hub driver.

> >>

> >> Also, the current xHCI driver is missing some reports for the default SSP

> >> Sublink Speed capability for USB 3.2 roothub. This series also add some support

> >> for xHCI driver detecting various SuperSpeed Plus GenXxY.

> > 

> > I took the first 4 patches already and will wait for Mathias to review

> > the rest.

> > 

> > thanks,

> > 

> > greg k-h

> > 

> 

> For patches 4 to 8

> 

> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>


Thanks, all queued up now!

greg k-h