From patchwork Tue May 9 11:54:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 680491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07FDC7EE22 for ; Tue, 9 May 2023 11:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235597AbjEILyf (ORCPT ); Tue, 9 May 2023 07:54:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235423AbjEILye (ORCPT ); Tue, 9 May 2023 07:54:34 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 237981713; Tue, 9 May 2023 04:54:33 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 349Ajjuo025009; Tue, 9 May 2023 11:54:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=C0IUByqP6P3Y1odG476PVj3s63YZi31x7NmJwEDO1L8=; b=GCQWGwXAhcdNdSW1WjTrW1XVOW1xhEGggDI6Yg0oUx65lU7/JTjE4OeEGkeHtFb6ljix qMsnDMBZ1jKToUsN1G7+5d+iTB0a1vQboPqjNgJHwdtctEVM9DMbX45QmiVmemPrKZXD p5K32PUspRklRp85t/HoVhDT0C0jko2hW4p4w7ITnaXqX1M5OvpBc5V316qbRHa2N8rb r+DmjC+u0Qsi8b09rFEtQTasgYwkWGdifEigtU4tIPjNjklwITKyjr868L7a9xWiQkDe qj3RkQI5JAdpSfuedAAVwIy4l141HnkEb0IQmpHYbCGsXVX1r1brdjfV9WvqYDpgHXth QA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qf7861mak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 May 2023 11:54:22 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 349BsLo8021268 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 May 2023 11:54:21 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 9 May 2023 04:54:15 -0700 From: Varadarajan Narayanan To: , , , , , , , , , , , , , , , , , CC: Varadarajan Narayanan Subject: [PATCH v11 0/9] Enable IPQ9754 USB Date: Tue, 9 May 2023 17:24:00 +0530 Message-ID: X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: JmnXnQMhY8YL3DRQAIbv3Xfm4zeAbTyl X-Proofpoint-ORIG-GUID: JmnXnQMhY8YL3DRQAIbv3Xfm4zeAbTyl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-09_08,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 suspectscore=0 clxscore=1011 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=778 bulkscore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305090095 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch series adds the relevant phy and controller configurations for enabling USB on IPQ9754 Depends on: https://lore.kernel.org/all/20230217142030.16012-1-quic_devipriy@quicinc.com/ https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/ [v11]: - Rename dwc_0 -> usb_0_dwc3 - Minor change in qcom,sc8280xp-qmp-usb3-uni-phy.yaml to factor in latest updates to the file [v10]: - Fix regulator definitions - Address couple of other comments [v9]: - Update bindings to make power-domains as optional since IPQ9574 doesn't have GDSCs [v8]: - Update bindings for the clock name change [v7]: - com_aux -> cfg_ahb in patch 7 [v6]: - Incorporated review comments - Resolve make dtbs_check messages - Fixed pcs_usb offset - Board dts file name changed [v5]: - Incorporated review comments - 'make dtbs_check' giving the following messages since ipq9574 doesn't have power domains. Hope this is ok /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@7d000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@8a00000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml - Move qmp phy DT node to newer specification [v4]: - Incorporated review comments - Address all 'make dtbs_check' errors [v3]: - Incorporated review comments regarding coding style [v2]: - Incorporated review comments regarding coding style, maintaining sorted order of entries and unused phy register offsets - Removed NOC clock entries from DT node (will be implemented later with interconnect support) - Fixed 'make dtbs_check' errors/warnings [v1]: https://lore.kernel.org/linux-arm-msm/5dac3aa4-8dc7-f9eb-5cf3-b361efdc9494@linaro.org/T/ Varadarajan Narayanan (9): dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY dt-bindings: usb: dwc3: Add IPQ9574 compatible clk: qcom: gcc-ipq9574: Add USB related clocks phy: qcom-qusb2: add QUSB2 support for IPQ9574 phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence arm64: dts: qcom: ipq9574: Add USB related nodes arm64: dts: qcom: ipq9574: Add LDO regulator node arm64: dts: qcom: ipq9574: Enable USB .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 3 +- .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 44 ++++++-- .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 +- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 30 ++++++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 104 +++++++++++++++++++ drivers/clk/qcom/gcc-ipq9574.c | 37 +++++++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 115 +++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 + include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + 9 files changed, 333 insertions(+), 8 deletions(-) Reviewed-by: Dmitry Baryshkov