From patchwork Tue Feb 25 19:40:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 25312 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f198.google.com (mail-vc0-f198.google.com [209.85.220.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3D43D20143 for ; Tue, 25 Feb 2014 19:42:29 +0000 (UTC) Received: by mail-vc0-f198.google.com with SMTP id lf12sf15487019vcb.9 for ; Tue, 25 Feb 2014 11:42:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=NeVuTmCyIgKpikufz/ixBgUkDrkba+wQY9zpg1HnpfE=; b=GT8d0ayuwwb+a8WXOpbmKlmuyJTYGJYZrv7iS3yc5mJSlcD6UHeSPH3aW1QKSO9JfN W8hu5jLdcDDjIfGHYY5RNqouBYB9cxZ2Bc+tTtafyinI3gQPGWhWuGxSmV2uPwfYF8IT HPo6si2baWegvxQbcPuBN0klRbZXpcdTsofwG8tOp3uWeRBGSz4IBft+2Y0NU4Jqeqx3 6F8kSy3Cd2jdXVbWVceqJganJEpZZ4rnHNyYNb8kdgHFosY1ZV2Dt7+Sb9abyDA3Lr0k AzcYxy5exoaGOkx9BMOPOopKW+JcCVCxVZvVHEmXQpawnTZrgR5xP5nqOuxiEhz8IHFO 3GOw== X-Gm-Message-State: ALoCoQki5gw6Kanjp2fL9KvNsw02s5+5b0Doto2tsOuR2gaKksK7DdoieJxf8xcz9A5l186hjjqX X-Received: by 10.236.69.35 with SMTP id m23mr661038yhd.6.1393357349049; Tue, 25 Feb 2014 11:42:29 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.177 with SMTP id s46ls226139qga.24.gmail; Tue, 25 Feb 2014 11:42:28 -0800 (PST) X-Received: by 10.220.200.6 with SMTP id eu6mr1067528vcb.35.1393357348900; Tue, 25 Feb 2014 11:42:28 -0800 (PST) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id t20si7080436vek.117.2014.02.25.11.42.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Feb 2014 11:42:28 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id jw12so1029524veb.32 for ; Tue, 25 Feb 2014 11:42:28 -0800 (PST) X-Received: by 10.52.229.133 with SMTP id sq5mr323817vdc.45.1393357348829; Tue, 25 Feb 2014 11:42:28 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp163126vcz; Tue, 25 Feb 2014 11:42:28 -0800 (PST) X-Received: by 10.68.204.231 with SMTP id lb7mr1768116pbc.30.1393357348317; Tue, 25 Feb 2014 11:42:28 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gp2si21476007pac.70.2014.02.25.11.42.28; Tue, 25 Feb 2014 11:42:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753421AbaBYTm0 (ORCPT + 3 others); Tue, 25 Feb 2014 14:42:26 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:53842 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437AbaBYTmS (ORCPT ); Tue, 25 Feb 2014 14:42:18 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s1PJgI3u028786 for ; Tue, 25 Feb 2014 13:42:18 -0600 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s1PJgIOi027039 for ; Tue, 25 Feb 2014 13:42:18 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Tue, 25 Feb 2014 13:42:17 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s1PJgHbu020574; Tue, 25 Feb 2014 13:42:17 -0600 From: Felipe Balbi To: Linux USB Mailing List CC: Felipe Balbi Subject: [PATCH 10/11] usb: dwc3: gadget: make sure HIRD threshold is 0 in superspeed Date: Tue, 25 Feb 2014 13:40:42 -0600 Message-ID: <1393357243-2958-11-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1393357243-2958-1-git-send-email-balbi@ti.com> References: <1393357243-2958-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , During superspeed, HIRD threshold should always be zero. Curent driver wasn't making sure that was the case. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 3eee96a..d307ad7 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2331,6 +2331,10 @@ static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc) reg |= DWC3_DCTL_HIRD_THRES(12); dwc3_writel(dwc->regs, DWC3_DCTL, reg); + } else { + reg = dwc3_readl(dwc->regs, DWC3_DCTL); + reg &= ~DWC3_DCTL_HIRD_THRES_MASK; + dwc3_writel(dwc->regs, DWC3_DCTL, reg); } dep = dwc->eps[0];