From patchwork Mon Mar 10 18:30:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 25994 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0B5E82054B for ; Mon, 10 Mar 2014 18:33:05 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id wo20sf29333654obc.6 for ; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=hJez1w99Qqlm4NB3yOlZni3DHlG6BCRIa55jXHjz15s=; b=K/lCP0+vN0Bi28jI44poqslxX9xJHgU07xEONKrj5rvLI0d6ygpTdATumlC0a+Wovx sY0eYSFdk4vl47lNUzyrCpVXI86YrErr3fOWsP3wCFenOxvGaB7gjJerQ+nWTNMdy3/S UtEUc4iAonE65CVaImZ0QsV7R5ytSaG05G2jVEk6dGT6xOSJ99OHICkdH0G3FlBPV04B 7kzKOh37jqAbhXtmhVy9TsSMuuRUEsQloEQSnpx87WwvEutog8xI2HW0beybkJoE3uy2 kC5FyafySZR5n8dgBpB9TkfywJfMOCPoXbrCfuifZ6UkAFiT6R5YZrvwRqS4haB6AOMf d6Jg== X-Gm-Message-State: ALoCoQngtMhWcdXI+pnLBUMyX72u6u+JBKrqb7tkFyEQeYTmKodduPNrTnte9dCWLK7wwpgBgwgJ X-Received: by 10.42.51.141 with SMTP id e13mr13036642icg.28.1394476385351; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.95.230 with SMTP id i93ls2256595qge.28.gmail; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) X-Received: by 10.58.238.35 with SMTP id vh3mr23847931vec.16.1394476385187; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id dq2si4989702veb.145.2014.03.10.11.33.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 11:33:05 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jx11so7434972veb.17 for ; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) X-Received: by 10.58.161.227 with SMTP id xv3mr1473424veb.31.1394476385110; Mon, 10 Mar 2014 11:33:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp139261vck; Mon, 10 Mar 2014 11:33:04 -0700 (PDT) X-Received: by 10.66.164.229 with SMTP id yt5mr42351983pab.67.1394476384211; Mon, 10 Mar 2014 11:33:04 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si17584997pbh.314.2014.03.10.11.33.03; Mon, 10 Mar 2014 11:33:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbaCJSc7 (ORCPT + 3 others); Mon, 10 Mar 2014 14:32:59 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:37317 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbaCJScy (ORCPT ); Mon, 10 Mar 2014 14:32:54 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2AIWYYs019983; Mon, 10 Mar 2014 13:32:35 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2AIWYn8025406; Mon, 10 Mar 2014 13:32:34 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Mon, 10 Mar 2014 13:32:34 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2AIWYLo027645; Mon, 10 Mar 2014 13:32:34 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: , , , , Felipe Balbi Subject: [PATCH 1/4] usb: gadget: lpc32xx_udc: fix wrong clk_put() sequence Date: Mon, 10 Mar 2014 13:30:53 -0500 Message-ID: <1394476256-2902-2-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1394476256-2902-1-git-send-email-balbi@ti.com> References: <1394476256-2902-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch fixes the following Coccinelle error: drivers/usb/gadget/lpc32xx_udc.c:3313:1-7: ERROR: \ missing clk_put; clk_get on line 3139 and \ execution via conditional on line 3146 Signed-off-by: Felipe Balbi --- drivers/usb/gadget/lpc32xx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c index 049ebab..a139894 100644 --- a/drivers/usb/gadget/lpc32xx_udc.c +++ b/drivers/usb/gadget/lpc32xx_udc.c @@ -3295,9 +3295,9 @@ usb_clk_enable_fail: pll_set_fail: clk_disable(udc->usb_pll_clk); pll_enable_fail: - clk_put(udc->usb_slv_clk); -usb_otg_clk_get_fail: clk_put(udc->usb_otg_clk); +usb_otg_clk_get_fail: + clk_put(udc->usb_slv_clk); usb_clk_get_fail: clk_put(udc->usb_pll_clk); pll_get_fail: