From patchwork Mon Jun 23 07:51:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 32333 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f197.google.com (mail-ig0-f197.google.com [209.85.213.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D80C4203AC for ; Mon, 23 Jun 2014 07:54:08 +0000 (UTC) Received: by mail-ig0-f197.google.com with SMTP id r10sf10855758igi.0 for ; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=DUl40jx2Mlg0uulCsi6WCnWLRXa6xQTGt0MxcDhaOFs=; b=bKLz93wfJQ3NYiSy4QsZSyHbxmMVgXBQtY6fkqK5G4Q1QjImugF/vgL/DWF/0ihfFn Et+tQvvWqK+TJIweOcGUnZUVT6aHOWuSHjCe1LrIXSZMJCKFwB7XAnfWXUUsFc7Nwe1N LUH+etoNzrXm2uQiEH+TuUk39FlkobLCoZ8WcJZtNNFZH9mKiZNEqsr2w2p8/4h8IbyN 7Wxe5jfNnJVXDHHM8U1aGNqIB+90RCVCVF9GgFbATJZ9npW+rAhIySFj72PF3OquWZXE AMP+kdUwOogy23LZ6ZqjRAbDKtCuMzSEOju4oBDFnbeQGL8wSqQNhsm9ZeO0bEGlWDPY cRlw== X-Gm-Message-State: ALoCoQkeuFo6J3+sZsFR0X5D8S0wN9eF8UVaUN8QFJACw52z635nmcH2/Ew2Wg/DFV7ZQIi9EC4a X-Received: by 10.42.109.148 with SMTP id l20mr8170564icp.0.1403510048418; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.129 with SMTP id g1ls1789599qge.17.gmail; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) X-Received: by 10.52.163.208 with SMTP id yk16mr3390192vdb.36.1403510048320; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id l10si1650187veb.2.2014.06.23.00.54.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Jun 2014 00:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ik5so5494841vcb.7 for ; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) X-Received: by 10.58.229.162 with SMTP id sr2mr187858vec.15.1403510048260; Mon, 23 Jun 2014 00:54:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp112376vcb; Mon, 23 Jun 2014 00:54:07 -0700 (PDT) X-Received: by 10.66.192.194 with SMTP id hi2mr26825770pac.33.1403510047501; Mon, 23 Jun 2014 00:54:07 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hq3si20742411pad.87.2014.06.23.00.54.06; Mon, 23 Jun 2014 00:54:06 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbaFWHyE (ORCPT + 9 others); Mon, 23 Jun 2014 03:54:04 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:59760 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbaFWHyA (ORCPT ); Mon, 23 Jun 2014 03:54:00 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7M005RO39ZH080@mailout2.samsung.com>; Mon, 23 Jun 2014 16:53:59 +0900 (KST) X-AuditID: cbfee61b-f79f86d00000144c-d3-53a7dd170517 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 07.E1.05196.71DD7A35; Mon, 23 Jun 2014 16:53:59 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7M00JX335V68O0@mmp2.samsung.com>; Mon, 23 Jun 2014 16:53:59 +0900 (KST) From: Robert Baldyga To: balbi@ti.com Cc: paulz@synopsys.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga Subject: [PATCH 08/11] usb: dwc2/gadget: do not call disconnect method in pullup Date: Mon, 23 Jun 2014 09:51:27 +0200 Message-id: <1403509890-14103-9-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1403509890-14103-1-git-send-email-r.baldyga@samsung.com> References: <1403509890-14103-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t9jQV3xu8uDDf4ulLWY9bKdxeLg/XqL 5sXr2Swu75rDZrFoWSuzxdojd9kttk+ZzmTx4PBOdgcOj/1z17B79G1ZxeixZf9nRo/jN7Yz eXzeJBfAGsVlk5Kak1mWWqRvl8CVcebmQZaCeWwVV5qusjQwLmLtYuTkkBAwkbi//DiULSZx 4d56NhBbSGA6o8TOryVdjFxAdjuTxK3pE8ASbAI6Elu+T2AEsUUEBCTWv7jEDlLELHCCUaLj /wWwImGBAIk7fY/YQWwWAVWJJY87WEBsXgFXiROTl7NBbJOTOHlsMthmTgE3ifU3F7JDbHaV WHR6GvsERt4FjAyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYLD65n0DsZVDRaHGAU4GJV4 eDXclgcLsSaWFVfmHmKU4GBWEuFtbAAK8aYkVlalFuXHF5XmpBYfYpTmYFES5z3Yah0oJJCe WJKanZpakFoEk2Xi4JRqYFzu9/5F79pZdU7ZOS7C+56/+508M5d9znFuvZMlSfZ1qU95773+ Gv7vsYal55EfTF84HhUXWCwLfCfabPDTOHLxwcbjU2+dkCju3Jq0WvX9+9NvnynudLR89m/u 7Z1eyi/6faceVM/YbZRyVEPz1757XY13FzSo2a5YkK4zS3FxyPWO1YGG8/SVWIozEg21mIuK EwFRdr8tKwIAAA== Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 2220882..def4900 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2945,7 +2945,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }