From patchwork Fri Jul 18 11:39:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 33832 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D735F20CA0 for ; Fri, 18 Jul 2014 11:41:16 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id y10sf24555758pdj.0 for ; Fri, 18 Jul 2014 04:41:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=DUl40jx2Mlg0uulCsi6WCnWLRXa6xQTGt0MxcDhaOFs=; b=UH28jKoNaHGwPftLCP2K18a6Y944+hSm8Ni7XTXK9brma42OB6H/N0j8a7Ts5oLZv9 QsdiX/FWgO+J68P1kU48+ClKTT3c+1FJkFPBQvcq2DfKTsEsmrJ7vUbvl9qVTg15cVLQ qyJ884KWXwx8WN2OwXXdthESdwDds+RHbA5WZcdEh4HClDT7Xn2cfuLlkESCYMDto9PH paxHc68jK/5rgIJ1KhbkyoGdO7QZkk6hg4DGq6TjW4VwUda3b1ekEllUETPd/w0Ol0Tz 4DyTvxMyzq9ONRTr8LBRBHVqZlIGsYbru+yRuuBrPynjAXW6yFtBXpqMOf73h+uGKJOq jwyw== X-Gm-Message-State: ALoCoQkOo0lWUzcauykIS1JFRYu4/6yNCGOsgwnatAI5iq09TfyxZxeahbu9HK07NhNIlNfMuinJ X-Received: by 10.66.65.109 with SMTP id w13mr2095347pas.21.1405683676108; Fri, 18 Jul 2014 04:41:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.92.140 with SMTP id b12ls937633qge.88.gmail; Fri, 18 Jul 2014 04:41:16 -0700 (PDT) X-Received: by 10.52.177.98 with SMTP id cp2mr4020784vdc.88.1405683675983; Fri, 18 Jul 2014 04:41:15 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id er10si5292256vdc.28.2014.07.18.04.41.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jul 2014 04:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id im17so6971110vcb.31 for ; Fri, 18 Jul 2014 04:41:15 -0700 (PDT) X-Received: by 10.221.47.9 with SMTP id uq9mr4890907vcb.48.1405683675905; Fri, 18 Jul 2014 04:41:15 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp3175vcb; Fri, 18 Jul 2014 04:41:15 -0700 (PDT) X-Received: by 10.67.2.73 with SMTP id bm9mr4151714pad.73.1405683674951; Fri, 18 Jul 2014 04:41:14 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ct2si5653331pbc.92.2014.07.18.04.41.06; Fri, 18 Jul 2014 04:41:06 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761677AbaGRLkU (ORCPT + 24 others); Fri, 18 Jul 2014 07:40:20 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45048 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761658AbaGRLkQ (ORCPT ); Fri, 18 Jul 2014 07:40:16 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8W00G9FOF34A40@mailout2.samsung.com>; Fri, 18 Jul 2014 20:40:15 +0900 (KST) X-AuditID: cbfee61a-f79e46d00000134f-fa-53c9079f9d9b Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B6.67.04943.F9709C35; Fri, 18 Jul 2014 20:40:15 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8W002CQOE11160@mmp1.samsung.com>; Fri, 18 Jul 2014 20:40:15 +0900 (KST) From: Robert Baldyga To: balbi@ti.com Cc: paulz@synopsys.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga Subject: [PATCH v3 08/12] usb: dwc2/gadget: do not call disconnect method in pullup Date: Fri, 18 Jul 2014 13:39:33 +0200 Message-id: <1405683577-11226-9-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1405683577-11226-1-git-send-email-r.baldyga@samsung.com> References: <1405683577-11226-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsVy+t9jAd357CeDDf6dFLKY9bKdxeLg/XqL 5sXr2Swu75rDZrFoWSuzxdojd9kttk+ZzmTx4PBOdgcOj/1z17B79G1ZxeixZf9nRo/jN7Yz eXzeJBfAGsVlk5Kak1mWWqRvl8CVcebmQZaCeWwVV5qusjQwLmLtYuTkkBAwkZh4YzUzhC0m ceHeerYuRi4OIYFFjBIn3m1lAUkICbQzSbROcgGx2QR0JLZ8n8AIYosICEisf3GJHaSBWeAE o0TH/wtsIAlhgVCJs5/7wKayCKhKXNs7hR3E5hVwlfjfswxqs5zEyWOTwWxOATeJtkf/gZZx AC1zlZj2lX8CI+8CRoZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMHB9UxqB+PKBotDjAIc jEo8vBY3jwcLsSaWFVfmHmKU4GBWEuHNvg8U4k1JrKxKLcqPLyrNSS0+xCjNwaIkznug1TpQ SCA9sSQ1OzW1ILUIJsvEwSnVwCgQfXaCRqvwh4PBi3UeKX12P99/+vcfZvbTvrE2eddjH0Yz rFiqVbe2fcPmBU891V79T+EVnTVP0mrp624htRs3f6/OLj6yvzV8N0P43r1rD1jcVHqttmj6 ry/cnzff7dW52DXz7L4LXOuiq56qRR1Ori0LFbS+ZGT5qihum8+3Liv+AxuFclyUWIozEg21 mIuKEwHMCcAHKgIAAA== Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 2220882..def4900 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2945,7 +2945,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }