From patchwork Thu Sep 4 19:04:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Zimmerman X-Patchwork-Id: 36759 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f200.google.com (mail-yk0-f200.google.com [209.85.160.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A0B8820CBB for ; Thu, 4 Sep 2014 19:06:41 +0000 (UTC) Received: by mail-yk0-f200.google.com with SMTP id 9sf32459343ykp.7 for ; Thu, 04 Sep 2014 12:06:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=UUUvTVlsCOyRq5ygB8JlSgfU40acH4IIYARTOVGErMY=; b=GAHwlDtLO+Kz6VeNkfzgIhSh2+0jnnx5tdNVxP054Zq1ctSLQsfitDn+gxNJGD59Nw YCYKjG6lTVCVSaaM9Pg+psZlDf9ftaCbuTjofbBvEPETy4gG9FESHuPmVHqNMPaeLrkp n6K4bFx4SdvY4we1VqkZfsaZAAhHZ1EFQKw9NRgFxonXetnuul2f16phPpWT4W4k7gJv uirAuWzlNFJBit5b1JNPIFN5eyyWp5FXFFGPNug+NoXoazuOzepxSF01VYWjZYQrt16U jPqubfJi3wdMSmtCzw2t44eqHyJgpPMRDqkGinude7b0g8r6X9/3Qih66p5Fp0lIt39V 8bPw== X-Gm-Message-State: ALoCoQlEPOebusFmNTDZm38X6myA6FwhOdjKD2B9V/LJiRNWyTvId+GVot2uJMTeftMsN5MntuqS X-Received: by 10.236.63.197 with SMTP id a45mr3916831yhd.9.1409857601334; Thu, 04 Sep 2014 12:06:41 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.182 with SMTP id h51ls472164qgf.80.gmail; Thu, 04 Sep 2014 12:06:41 -0700 (PDT) X-Received: by 10.220.182.73 with SMTP id cb9mr6236310vcb.9.1409857601214; Thu, 04 Sep 2014 12:06:41 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id wd4si3739743vdb.33.2014.09.04.12.06.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Sep 2014 12:06:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id hq11so11197231vcb.36 for ; Thu, 04 Sep 2014 12:06:41 -0700 (PDT) X-Received: by 10.220.169.72 with SMTP id x8mr3628928vcy.45.1409857600973; Thu, 04 Sep 2014 12:06:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp885259vcb; Thu, 4 Sep 2014 12:06:40 -0700 (PDT) X-Received: by 10.70.88.75 with SMTP id be11mr11909297pdb.69.1409857600137; Thu, 04 Sep 2014 12:06:40 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pl6si5320797pdb.111.2014.09.04.12.06.35 for ; Thu, 04 Sep 2014 12:06:35 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755196AbaIDTGF (ORCPT + 2 others); Thu, 4 Sep 2014 15:06:05 -0400 Received: from smtprelay4.synopsys.com ([198.182.44.111]:55338 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754986AbaIDTGD (ORCPT ); Thu, 4 Sep 2014 15:06:03 -0400 Received: from us01secmta2.synopsys.com (us01secmta2.synopsys.com [10.9.203.102]) by smtprelay.synopsys.com (Postfix) with ESMTP id 36FF424E0034; Thu, 4 Sep 2014 12:06:03 -0700 (PDT) Received: from us01secmta2.internal.synopsys.com (us01secmta2.internal.synopsys.com [127.0.0.1]) by us01secmta2.internal.synopsys.com (Service) with ESMTP id 2AEF8A4112; Thu, 4 Sep 2014 12:06:03 -0700 (PDT) Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.9.202.240]) by us01secmta2.internal.synopsys.com (Service) with ESMTP id 02BD9A4102; Thu, 4 Sep 2014 12:06:03 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id EA078BCA; Thu, 4 Sep 2014 12:06:02 -0700 (PDT) Received: from us01dwvnc004.internal.synopsys.com (us01dwvnc004.internal.synopsys.com [10.15.114.106]) by mailhost.synopsys.com (Postfix) with ESMTP id CA24EBC9; Thu, 4 Sep 2014 12:06:02 -0700 (PDT) Received: from us01dwvnc004.internal.synopsys.com (localhost [127.0.0.1]) by us01dwvnc004.internal.synopsys.com (8.13.1/8.12.3) with ESMTP id s84J62ek005264; Thu, 4 Sep 2014 12:06:02 -0700 Received: (from paulz@localhost) by us01dwvnc004.internal.synopsys.com (8.13.1/8.13.1/Submit) id s84J5vIQ005263; Thu, 4 Sep 2014 12:05:57 -0700 From: Paul Zimmerman To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, r.baldyga@samsung.com, Marek Szyprowski , Paul Zimmerman Subject: [PATCH RESEND v3 08/12] usb: dwc2/gadget: do not call disconnect method in pullup Date: Thu, 4 Sep 2014 12:04:30 -0700 Message-Id: <1409857474-4497-9-git-send-email-paulz@synopsys.com> X-Mailer: git-send-email 1.7.0.5 In-Reply-To: <1409857474-4497-1-git-send-email-paulz@synopsys.com> References: <1409857474-4497-1-git-send-email-paulz@synopsys.com> Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: paul.zimmerman@synopsys.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga Signed-off-by: Paul Zimmerman Reviewed-by: Felipe Balbi --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 97368c4c..55238b0 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2944,7 +2944,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }