From patchwork Fri Oct 17 17:16:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 38934 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8940620973 for ; Fri, 17 Oct 2014 17:18:11 +0000 (UTC) Received: by mail-wi0-f198.google.com with SMTP id hi2sf799900wib.1 for ; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=mxwxcV1mwaVSA7heIcIqDS4CjtZHozNae9Jz4YT4oWg=; b=mw+i9pU7c+an/zJWaAGsOzyUxCr9ay75tt8IOc5hgu7IOxhpJlVhCrLqB8vM0ZDryO A1Um4+p6kGDk9/l3WDOpMJB+FF0+vfNGhix4up+37i2iT2hiJ3fZpHDvjnX2fKD4X3bP DT5IaWRv5mZ/BkJZuKyQooTM91Kl67H1ICkOIPvoleMMoWKdSD069VR+2FAFIakoAwDV gAPOYa0UZ/DBIHJq2K3VxLGwwR+nplBPjwyCi/o0pGL180PBRaGX3XpUGnLPVxB3UMnk MS1oFv+fiWzqzQKeuPohyVSiG3Y+zyIwjRFEH4etTiAhxORCBUMBg0Jp+ydYbsXnPHQd AeOw== X-Gm-Message-State: ALoCoQkiXi06hmVqJe2tRW7k2WT30y0SVWfd0Fu7FndjKJNAHUKgDCPaitKpF29SnU3supt+x82f X-Received: by 10.152.26.72 with SMTP id j8mr1600973lag.3.1413566290694; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.5.43 with SMTP id cj11ls273747lad.85.gmail; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) X-Received: by 10.152.5.38 with SMTP id p6mr5622007lap.44.1413566290589; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id wh3si2947311lbb.118.2014.10.17.10.18.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 10:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id pn19so1061444lab.14 for ; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) X-Received: by 10.152.202.135 with SMTP id ki7mr10326846lac.40.1413566290311; Fri, 17 Oct 2014 10:18:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp268066lbz; Fri, 17 Oct 2014 10:18:09 -0700 (PDT) X-Received: by 10.66.141.9 with SMTP id rk9mr10129648pab.28.1413566287964; Fri, 17 Oct 2014 10:18:07 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b7si1686618pdm.75.2014.10.17.10.18.07 for ; Fri, 17 Oct 2014 10:18:07 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753542AbaJQRSA (ORCPT + 3 others); Fri, 17 Oct 2014 13:18:00 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:44342 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbaJQRR6 (ORCPT ); Fri, 17 Oct 2014 13:17:58 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9HHHkfV008041; Fri, 17 Oct 2014 12:17:46 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9HHHkCP029319; Fri, 17 Oct 2014 12:17:46 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Fri, 17 Oct 2014 12:17:47 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9HHHjkR030124; Fri, 17 Oct 2014 12:17:46 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Greg KH , , Paul Zimmerman , , , , , , , Dan Carpenter , Felipe Balbi Subject: [PATCH 19/67] usb: gadget: f_uac1: remove an unneeded NULL check Date: Fri, 17 Oct 2014 12:16:26 -0500 Message-ID: <1413566234-13537-20-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT In-Reply-To: <1413566234-13537-1-git-send-email-balbi@ti.com> References: <1413566234-13537-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Dan Carpenter This NULL check sets off a static checker warning because we already dereferenced "card" earlier in the function. However, since "card" is never NULL so we can just remove the check. Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi --- drivers/usb/gadget/function/u_uac1.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/function/u_uac1.c b/drivers/usb/gadget/function/u_uac1.c index a44a07f..53842a1 100644 --- a/drivers/usb/gadget/function/u_uac1.c +++ b/drivers/usb/gadget/function/u_uac1.c @@ -213,9 +213,6 @@ static int gaudio_open_snd_dev(struct gaudio *card) fn_cap = opts->fn_cap; fn_cntl = opts->fn_cntl; - if (!card) - return -ENODEV; - /* Open control device */ snd = &card->control; snd->filp = filp_open(fn_cntl, O_RDWR, 0);