From patchwork Thu Apr 28 12:42:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102410 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp191711qge; Thu, 28 Apr 2016 05:43:23 -0700 (PDT) X-Received: by 10.66.141.42 with SMTP id rl10mr20359418pab.48.1461847402947; Thu, 28 Apr 2016 05:43:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d27si10192945pfj.14.2016.04.28.05.43.22; Thu, 28 Apr 2016 05:43:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbcD1MnV (ORCPT + 4 others); Thu, 28 Apr 2016 08:43:21 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56118 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbcD1MnU (ORCPT ); Thu, 28 Apr 2016 08:43:20 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0MDkte-1auAaZ3fyg-00H5xs; Thu, 28 Apr 2016 14:43:09 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Valentina Manea , Shuah Khan , Krzysztof Opasiak , Igor Kotrasinski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usbip: vudc: fix Kconfig dependencies Date: Thu, 28 Apr 2016 14:42:50 +0200 Message-Id: <1461847388-1463701-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:WzA14brZ/KcX9PxnsYlGtsgOgKCL/pIEeMCeEGHQlyyLK+Ih2I6 5GKN2UqD8bioeZeAOaf+eSyaSVPEbNWALBabV1JLp+ttLZ7bznyO1Qjt2nepqlpkA+dfBqR 4YKLpwRJy5k3OeDtwsYwzkPV4fALhEaqQ3Pjd1p3CzlpZfBgVM4ExQ9DWSAtj5smJZFPKNh QoD1TGLDZ1IgTc7mTRz7g== X-UI-Out-Filterresults: notjunk:1; V01:K0:s9GVGYH/wGE=:U4T7PpBWd59tsm408eig00 HfezkU0ignijH8+t0wnuJJjZfZk8ZkNUh//shosZ1ttTCxmrf1ljsEcjCja+FWzm8HeTvhmiZ 5RV2FzCHz9Qo4xyfXxivWo7zVwH+kK5Q1JQdjGVEZzE9mO8doXx84CqPvkVVLjr/Q5rSImJf+ Dlr5lmK/rHjTPwwXRO/Pv2FK56d68hB3+9PL1x9z7GWigzLwPGZzH8/Zt8w3wrlOTSsjYV6kf jAVh89fEaA4tq3RVIWj5vaqcmyF18WEcvuZaH/iAean7usn5vfU0ABsEsZUsIpN+wXELxDVbD Gm37IMjWMB/Um0/7N4rZj3hop3vyTTrByXjGSuE0OsuwY06hE3LJEZ8cpHeNPF6xqpU8xDuKz UlYwgFvYkX6ZSz3ZS4RnrGBN0WEwBOuea8LcvucsklB3zavMyfKTPcpQ0WUJpoNAIOKjj8rSL nw8FR8JqBcPSrj0qEuDV16mA2MntXPiLyV/RDXx5QhgF4518QwSxIA6wBkRQO073PzqtrU/RT 2BEfDCOrDjIFDO0mJmn2GvgpN0YE9DuNZUlppIG574GmmDQeZIQ5XCBPZhvw1Kn+DoUUXrGPU tgSiutbijHKfTH42uKmn2VmN1uPC+iR4JCwydoMceHek6qg+YJd2eWcpNSwxl3QAhDujEyQ40 088AyiXYXDdqzd/d90trJc421c4mBJIWr7B+kJ1GbzojenSmWJezjJ55bqi6hqeNMjr0= Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org With the addition of VUDC, the USBIP stack can now be used on configurations without USB host support, but trying to build it with USB gadget support disabled fails with drivers/usb/built-in.o: In function `vep_dequeue': vudc_main.c:(.text+0xa6ddc): undefined reference to `usb_gadget_giveback_request' drivers/usb/built-in.o: In function `nuke': vudc_main.c:(.text+0xa6ea8): undefined reference to `usb_gadget_giveback_request' drivers/usb/built-in.o: In function `vudc_device_reset': vudc_main.c:(.text+0xa720c): undefined reference to `usb_gadget_udc_reset' drivers/usb/built-in.o: In function `vudc_probe': This addresses both issues, by changing the dependency for USBIP_CORE to USB_COMMON, and adding additional dependencies on USB or USB_GADGET for the individual portions as needed. Signed-off-by: Arnd Bergmann Fixes: 9360575c5837 ("usbip: vudc: Add vudc to Kconfig") --- drivers/usb/usbip/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig index ebf4ff050890..17646b25343f 100644 --- a/drivers/usb/usbip/Kconfig +++ b/drivers/usb/usbip/Kconfig @@ -1,6 +1,6 @@ config USBIP_CORE tristate "USB/IP support" - depends on USB && NET + depends on USB_COMMON && NET ---help--- This enables pushing USB packets over IP to allow remote machines direct access to USB devices. It provides the @@ -16,7 +16,7 @@ config USBIP_CORE config USBIP_VHCI_HCD tristate "VHCI hcd" - depends on USBIP_CORE + depends on USBIP_CORE && USB ---help--- This enables the USB/IP virtual host controller driver, which is run on the remote machine. @@ -26,7 +26,7 @@ config USBIP_VHCI_HCD config USBIP_HOST tristate "Host driver" - depends on USBIP_CORE + depends on USBIP_CORE && USB ---help--- This enables the USB/IP host driver, which is run on the machine that is sharing the USB devices. @@ -36,7 +36,7 @@ config USBIP_HOST config USBIP_VUDC tristate "VUDC driver" - depends on USBIP_CORE + depends on USBIP_CORE && USB_GADGET ---help--- This enables the USB/IP virtual USB device controller driver, which is run on the host machine, allowing the