From patchwork Fri Jan 24 19:08:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 23690 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 89CE920307 for ; Fri, 24 Jan 2014 20:04:35 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id hu8sf6249219vcb.2 for ; Fri, 24 Jan 2014 12:04:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=rmB4cfCpwDybPSL20RIhf7HWOJo15KGIZWgqOyvBdhg=; b=VywRuH7VAIpoTy227EjiXq545yRlEP9cF9w4Vh79JYEgDI0BfjZhFbwOaF3T4SNyS0 g3f8IsDMjiKI/kaH7FNNlkA69E2tDx2RobiwUhB/EAZtOHTCiCT8uTWUe5kW5NPxZA0s 1e2QC9LQHJzJ0uXjocR/LJtGwlNumDWzcpUFOEZLIFr7abZB7VaHmxRw0bSH6wYD29Km JsoGZ23ZibPzyLKixeF5V/s+8pe4yp6acvAxpnxIOw+wFH2bvNRK2Kuu4KA16RwXA2ah xw8htAju6ZtoI6DjXLbZ5lDVPtn5A2u06aNA/RnUrOzIvX1HxcMOpeemmaSrIlr6/Jfw i/iA== X-Gm-Message-State: ALoCoQlm4y11/l5+8eqdJlt4iGnrnCxQ/8liba0vvk+TlWPbgnJmrsQudeO2e9/ZSAGYBftngneq X-Received: by 10.236.94.113 with SMTP id m77mr5654220yhf.33.1390593874700; Fri, 24 Jan 2014 12:04:34 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.16.145 with SMTP id 17ls739261qgb.58.gmail; Fri, 24 Jan 2014 12:04:34 -0800 (PST) X-Received: by 10.58.119.161 with SMTP id kv1mr8454688veb.21.1390593874572; Fri, 24 Jan 2014 12:04:34 -0800 (PST) Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com [209.85.212.49]) by mx.google.com with ESMTPS id dc20si1080591vec.4.2014.01.24.12.04.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Jan 2014 12:04:34 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.49 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.49; Received: by mail-vb0-f49.google.com with SMTP id x14so2105917vbb.36 for ; Fri, 24 Jan 2014 12:04:34 -0800 (PST) X-Received: by 10.220.76.201 with SMTP id d9mr5639391vck.33.1390593874481; Fri, 24 Jan 2014 12:04:34 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp3079vcz; Fri, 24 Jan 2014 12:04:33 -0800 (PST) X-Received: by 10.66.182.199 with SMTP id eg7mr16039138pac.135.1390590636252; Fri, 24 Jan 2014 11:10:36 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xu6si2174787pab.109.2014.01.24.11.10.35; Fri, 24 Jan 2014 11:10:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbaAXTJu (ORCPT + 3 others); Fri, 24 Jan 2014 14:09:50 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:40655 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbaAXTJt (ORCPT ); Fri, 24 Jan 2014 14:09:49 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s0OJ9hVw022338; Fri, 24 Jan 2014 13:09:43 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s0OJ9hgo002426; Fri, 24 Jan 2014 13:09:43 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Fri, 24 Jan 2014 13:09:42 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s0OJ9grS006315; Fri, 24 Jan 2014 13:09:42 -0600 Date: Fri, 24 Jan 2014 13:08:31 -0600 From: Felipe Balbi To: Josh Boyer CC: , Greg KH , , , "Linux-Kernel@Vger. Kernel. Org" Subject: Re: Odd 'unable to find transceiver' messages from USB with v3.13-3260-g03d11a0 and later Message-ID: <20140124190831.GA6449@saruman.home> Reply-To: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.49 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, On Fri, Jan 24, 2014 at 08:47:07AM -0500, Josh Boyer wrote: > We've had a report [1] of the USB layer throwing out 'unable to find > transceiver' messages during boot with the 3.14 merge window kernels. > I've seen this on my personal machine as well and included the dmesg > section below. This does not happen with the 3.13 kernel. > > There are only a handful of files in git that have that error, but I > haven't seen anything that immediately strikes me as causing this. > From the dmesg output it looks like it is spit out right before a host > controller is registered? USB seems to be still working OK in my > minimal testing, so the error message is confusing. > > Thoughts? looks like it was caused because of this commit: commit 1ae5799ef63176cc75ec10e545cb65f620a82747 Author: Valentine Barshak Date: Wed Dec 4 01:42:22 2013 +0400 usb: hcd: Initialize USB phy if needed This adds external USB phy support to USB HCD driver that allows to find and initialize external USB phy, bound to the HCD, when the HCD is added. The usb_add_hcd function returns -EPROBE_DEFER if the USB phy, bound to the HCD, is not ready. If no USB phy is bound, the HCD is initialized as usual. Signed-off-by: Valentine Barshak Signed-off-by: Greg Kroah-Hartman usb_get_phy_device() will pr_err() when a PHY isn't found. Looks like that should be pr_debug() since everything still works even without a PHY. diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 7527c8e..d3a9bcd 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -2589,6 +2589,24 @@ int usb_add_hcd(struct usb_hcd *hcd, int retval; struct usb_device *rhdev; + if (IS_ENABLED(CONFIG_USB_PHY) && !hcd->phy) { + struct usb_phy *phy = usb_get_phy_dev(hcd->self.controller, 0); + + if (IS_ERR(phy)) { + retval = PTR_ERR(phy); + if (retval == -EPROBE_DEFER) + return retval; + } else { + retval = usb_phy_init(phy); + if (retval) { + usb_put_phy(phy); + return retval; + } + hcd->phy = phy; + hcd->remove_phy = 1; + } + } + dev_info(hcd->self.controller, "%s\n", hcd->product_desc); /* Keep old behaviour if authorized_default is not in [0, 1]. */