From patchwork Thu Jul 2 14:46:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192263 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1511311ilg; Thu, 2 Jul 2020 07:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy38bOUVPHzvmLMsdOzMep2SE8bPzqQk7AcL6wAXY56GwZaVFDIEcAvCeH84/loU3sp6jmI X-Received: by 2002:aa7:db53:: with SMTP id n19mr5833720edt.338.1593701319312; Thu, 02 Jul 2020 07:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593701319; cv=none; d=google.com; s=arc-20160816; b=yt//ggOWCXdWrZyRc9ax+jIA+R4kLk7lApqhjlWpQzMqlAHQ1kKwR9Bka7iVxTS6kr 7wYxE49hJ4ra6GTs4fXSeVURnSCAaEuhFvvUaxst6e7jpEo4QziDmt8LmIa6PiLoXSmT f698JcOP/GtFteavO12G0uCTGj6ntIvT6OmzJwuKQI+F6FlrE9XIy8ud2d1NVW2vNf25 qWbBDlDOYjk2cFu1f1YUo+ozO/sWXokaS2ADFZmYLpi17OMfYuU3cwk0fHHqPpE3iogu 5gSI5sfdZQB9oGANFaJqaJJleykxJenzuUqgEg1RWUJzvEundqo5Sux/Vi3aaxEvt4kv sR2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ekU/9fToolV+bnxY6uX+/NgRtkggBCTFheSpOeaBTsQ=; b=zLUMaHiPzuNAoU1rAs0wcyE9ApbZ+HjaiMCkFBAkD/25CJmWHJAXVqkcdWdT9RD36i toRVzTFyLWB6GNNXlEvVFIIMOcKLusKEcEJpasUHAb5liSOFELjziTHdmSE6SxnI6iLl uGUu5DfkXa1Pho5gUs0RrqfBYb5rb+NKIXzP2n4Mw+Y169/8kmZIXajarTsphlbvSzaI 1U0J14gH04Y/PgqjHsGNhltQ1+ZOGaWNX9k9oFao6b9USpUSj1KNpztbajmQpC2viS8p W4VEigvRYZKV4rfa9iRmJ+abCxipLdSweYv3ZL++V925Myy/zPvhMPnoLxJ6CRDfQWoV hmMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y+Hz7s1H; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr12si7493478ejc.352.2020.07.02.07.48.39; Thu, 02 Jul 2020 07:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y+Hz7s1H; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730004AbgGBOqv (ORCPT + 5 others); Thu, 2 Jul 2020 10:46:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729989AbgGBOqt (ORCPT ); Thu, 2 Jul 2020 10:46:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 392F2C08C5F3 for ; Thu, 2 Jul 2020 07:46:47 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g10so9234394wmc.1 for ; Thu, 02 Jul 2020 07:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekU/9fToolV+bnxY6uX+/NgRtkggBCTFheSpOeaBTsQ=; b=y+Hz7s1H9c6E1muboBIQnKa1duyLm9Puyw0SItMBVefMB9XgGsxNMgUvs1xGrvIgYE RobvU+GQKeiKScPwvyKiIuVUYUcLaE1/nvfdKccNfyv5+MvA5wCwfQcKVx7zK139D7Jq ZJUwxai3KootCSJFle1ffk2k5vJ0aiBsqqJkOf4gPxUh/FsKJownzbYSvOU8wUkV2kBu WAfo0c9r1FtOS3RpnmvBUg+i4NU0VPGXBUIm7ORvIkZowhL8kNJlVkVdsGFOiWxADhCF PK3W1qdTIqxSrOrWTRaurHqtBvnHIyZ+Wty4zVcZOHLl2ktHh3fjxQS5H1I+pgpOIXQz 1kjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekU/9fToolV+bnxY6uX+/NgRtkggBCTFheSpOeaBTsQ=; b=X1UZZSWvNQP+MtYd646QTP/6cUURa0MnysRcfP65eIVOLB1Ufp4OZWJvh1M1624xUj ZWviyjHz6gxcaNL31TGVyU9c7Hsd/M29KpW1FbncyrhQjUx2HgdFKnOD21mUf10gnoEz FWR4/xW65Nhltn+N2U2HPc5Of67SWIoscevpHeiS8fALJ8oeIk3IZJoHuqH0DnVHY79z vAK3efL79++8Ab6I/oLs2zJ8qVccTto3npMYeoW8dORN1l8vDzQ/vNbAtL0w7YKnVG3J jilXRH5IIsJ8YK8Eseu04K16h/ztTGzDw4QJJE+MwQRIxnpW/Yjr0SewCJkXZ602HIFj rJqg== X-Gm-Message-State: AOAM530hPg3o7Lgu/HtJa7gO0VxsON8bMz/NHAOAEkknEba3r3L5k61C yMZuv6KUST7jaLdhCZX57vQLOQ== X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr34759591wmj.117.1593701205836; Thu, 02 Jul 2020 07:46:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Minas Harutyunyan , Ben Dooks Subject: [PATCH 11/30] usb: dwc2: gadget: Avoid pointless read of EP control register Date: Thu, 2 Jul 2020 15:46:06 +0100 Message-Id: <20200702144625.2533530-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Commit ec1f9d9f01384 ("usb: dwc2: gadget: parity fix in isochronous mode") moved these checks to dwc2_hsotg_change_ep_iso_parity() back in 2015. The assigned value hasn't been read back since. Let's remove the unnecessary H/W read. Fixes the following W=1 warning: drivers/usb/dwc2/gadget.c: In function ‘dwc2_hsotg_epint’: drivers/usb/dwc2/gadget.c:2981:6: warning: variable ‘ctrl’ set but not used [-Wunused-but-set-variable] 2981 | u32 ctrl; | ^~~~ Cc: Minas Harutyunyan Cc: Ben Dooks Signed-off-by: Lee Jones --- drivers/usb/dwc2/gadget.c | 2 -- 1 file changed, 2 deletions(-) -- 2.25.1 Acked-by: Minas Harutyunyan diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 116e6175c7a48..fa07e3fcb8841 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2975,10 +2975,8 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx, u32 epctl_reg = dir_in ? DIEPCTL(idx) : DOEPCTL(idx); u32 epsiz_reg = dir_in ? DIEPTSIZ(idx) : DOEPTSIZ(idx); u32 ints; - u32 ctrl; ints = dwc2_gadget_read_ep_interrupts(hsotg, idx, dir_in); - ctrl = dwc2_readl(hsotg, epctl_reg); /* Clear endpoint interrupts */ dwc2_writel(hsotg, ints, epint_reg);