From patchwork Fri Jul 3 17:41:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 231487 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2595598ilg; Fri, 3 Jul 2020 10:43:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXnc0/rVijzeUSB9pGy3Ul2O853iwx+66ZR7Dl11hSxmcYglAx0iTGgIOs9rhiS29bDMx4 X-Received: by 2002:a17:906:7250:: with SMTP id n16mr25312743ejk.290.1593798216950; Fri, 03 Jul 2020 10:43:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593798216; cv=none; d=google.com; s=arc-20160816; b=HuZh0stIXaCaWZtEDGsOx3T1ZAPdQtkvLSrKgBiYaZht5X+aDE2A6ccqWC6GE3GBDx Hxiw2N26q7DygPxPlh5Op6AH/sg0FTDwIm97mXAiD/Zq5dtUFYpplWYklHZ6FDOX5FXW kJ8Y++y0epdppYf1ceUSzAebb5nAJHLADHQnmGwGSIGxJsYh6FBbnZ2OgGPttztac3CL kv0IL0h/otyv1rk55ehkQjWWNOHL6YAE0g7IqHmDsKUoApy2v1+mONAz+Jevcp4QI9zk iewCXemwk904oEjjXFFxUYP+M61+DPQWXsKRCJ2d0cK35te3JAS+6BJHmxfom+fQhjCa cb1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ISJzLOqlSFQczkvc3nK58bGo6HT98YijZfD9JIzoDdI=; b=QpYpf2g9g1zKaG5Wj0/hFBWX2ytKX5CL/yIz+Q/6q+EyFHOzNF4m+Gt18PU9FxYwkD 0Pb9qfr5dd3L4Ng7+akXRCj7C2VL2UxfB6x1khlNt9GlM3b558c3cD8C555CYGCbbgv4 XekWk4a/0lmEDYOdH2O6h+x5R6mGrOubeaTDOLK5zn7LF8gnX2QzVxNcVAonSttUrbEG D+oSZbDTP3bOSsByVX6h6k55ZUxXSrdv6WnrnSEq3WTtmrEwoNAML/4kKrDrLxC43Iqq lk/k2k0Yj2rDc1/3VX1kcXi4rDB3eWf25kqkxLVvyU1dHemzyeU9Jt71F26yHUtNOq6p Mszw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hdDJM1wU; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si8186762edy.5.2020.07.03.10.43.36; Fri, 03 Jul 2020 10:43:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hdDJM1wU; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgGCRn2 (ORCPT + 5 others); Fri, 3 Jul 2020 13:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbgGCRm4 (ORCPT ); Fri, 3 Jul 2020 13:42:56 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0750FC08C5DD for ; Fri, 3 Jul 2020 10:42:56 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id o11so33585696wrv.9 for ; Fri, 03 Jul 2020 10:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ISJzLOqlSFQczkvc3nK58bGo6HT98YijZfD9JIzoDdI=; b=hdDJM1wUbe6Ydmnsq4OtW1IpkqyR5cZyO21yDrMUJB1fPRtE9PXgy9WLg9uyjpLjDk 02rvMWgwad9utS1g6bYTUJKX7YVCsq7Xs7//+phOH0Oi67PsV5lSVQdrkOAxOaz4tsQW KY+BgAb4/zf/Edqb5LDhPlUnPqTljgNt1UPtf3jD3WyDnAvR0z99qifIMbsQ0kwKpBKV Ite1MzW2DvZHvyOU6ALS9uUvdSlb6fFhLsh8xPfS7tsakPpgDNHMum8UEPMF5+ekR/rR nFk+JrvtjyhLapCvYjvvytXS9fNnf2ED2grHZRNAmLSgpIQYeigPbYlkngsCTR8BeljI +WZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ISJzLOqlSFQczkvc3nK58bGo6HT98YijZfD9JIzoDdI=; b=fFmts81q8LPInFlH0kuGpzHjQ215KEIphGrIaVeCR555a6IXHfEk20NP5VhDteqwKH OIf5z/Zo8l8WsTUd6BLvEDhjPpCvaeLVeimwhZMwVDB6Dc0JIfwZsuOsqsm27fqdIll7 I++BeVeO1jv92bFMv1Tw/bV3xL5m9XjCt2R4CY0pXFegXElaX266tBosTCISjZz1TFHF CUy7JYtayKG7I3UMJJSQ4+fuc9rtpFckKcHbivMjT3pk55c86FJC52UWBFgZfR+XQw53 ZailO2vzuf2pqTXYKZ2d0CxptGpPkQP78I04FyNPympLkYjJljaQMI7xVEt1e/I3HOLL wuhQ== X-Gm-Message-State: AOAM531moz8uf/8xXKHSiL/qv1HiquvRQLhPFMvKCf+zPQkIpXPYpkGk sHTSIdkwuUNElaMd9wh1KdZcsg== X-Received: by 2002:adf:fcc5:: with SMTP id f5mr41969478wrs.60.1593798174786; Fri, 03 Jul 2020 10:42:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:54 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Johan Hovold , Christian Lucht , Stephane Dalton , Stephane Doyon Subject: [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:43 +0100 Message-Id: <20200703174148.2749969-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/iowarrior.c:251: warning: Function parameter or member 'dev' not described in 'iowarrior_delete' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'file' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'buffer' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'count' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'ppos' not described in 'iowarrior_read' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'file' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'cmd' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'arg' not described in 'iowarrior_ioctl' drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'inode' not described in 'iowarrior_open' drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'file' not described in 'iowarrior_open' drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'inode' not described in 'iowarrior_release' drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'file' not described in 'iowarrior_release' drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'interface' not described in 'iowarrior_probe' drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'id' not described in 'iowarrior_probe' drivers/usb/misc/iowarrior.c:879: warning: Function parameter or member 'interface' not described in 'iowarrior_disconnect' Cc: Johan Hovold Cc: Christian Lucht Cc: Stephane Dalton Cc: Stephane Doyon Signed-off-by: Lee Jones --- drivers/usb/misc/iowarrior.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 40e8c06894bff..4afd1ace3d32c 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -244,7 +244,7 @@ static void iowarrior_write_callback(struct urb *urb) wake_up_interruptible(&dev->write_wait); } -/** +/* * iowarrior_delete */ static inline void iowarrior_delete(struct iowarrior *dev) @@ -271,7 +271,7 @@ static int read_index(struct iowarrior *dev) return (read_idx == intr_idx ? -1 : read_idx); } -/** +/* * iowarrior_read */ static ssize_t iowarrior_read(struct file *file, char __user *buffer, @@ -475,7 +475,7 @@ static ssize_t iowarrior_write(struct file *file, return retval; } -/** +/* * iowarrior_ioctl */ static long iowarrior_ioctl(struct file *file, unsigned int cmd, @@ -592,7 +592,7 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, return retval; } -/** +/* * iowarrior_open */ static int iowarrior_open(struct inode *inode, struct file *file) @@ -640,7 +640,7 @@ static int iowarrior_open(struct inode *inode, struct file *file) return retval; } -/** +/* * iowarrior_release */ static int iowarrior_release(struct inode *inode, struct file *file) @@ -742,7 +742,7 @@ static struct usb_class_driver iowarrior_class = { /*---------------------------------*/ /* probe and disconnect functions */ /*---------------------------------*/ -/** +/* * iowarrior_probe * * Called by the usb core when a new device is connected that it thinks @@ -870,7 +870,7 @@ static int iowarrior_probe(struct usb_interface *interface, return retval; } -/** +/* * iowarrior_disconnect * * Called by the usb core when the device is removed from the system.