From patchwork Mon Jul 6 13:33:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 234861 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp4780513ilg; Mon, 6 Jul 2020 06:35:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzM6peXMdkJMyTCEqAbaCbZOxZmk8Izgdon9HWW9YbA/u+tqP9RvRyPZtVOLe4/Hq2dGwJ X-Received: by 2002:a17:906:a84d:: with SMTP id dx13mr36577992ejb.246.1594042516386; Mon, 06 Jul 2020 06:35:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594042516; cv=none; d=google.com; s=arc-20160816; b=p5E0FprdXj365yRRTeW2q5Q0E4tVtUMZf/CrrWWSF6QplD2sqXDIh9FFnj6uDm4kE0 YpooxmhWTCKnc+DX2BvO/W9ikw+ZEmVnUymapv0p4UZIem4SX1WjxCBJwc4fO7B9TKTU tuyG+jJd9ZyponKZ21xuQEJODdTSRJu3IJMkiIRX6u5iAME/Di5T+L7LX27UXsuM/dq6 rYdcHlttsoKHIrOZNtAI72x67H8xNVkXgP0vEuy5ONbvFZpthxPFu77wjP2aPuKJNYaB e4+Fu0Qg8rbUkVSPFliaRSQEINrO51+gE8iJEotBFqO6egsgLkZ+R4ZAu51S0ZDau4Qt hYuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=M5RywkdnjabQV+u8q9mXe5U3d+KO30OuBRmmhtNJJpFqXkiTlS0YekdFmcjw+Znbd7 4B1SIpeZ+xpw6mAKKwR3w4Kq0aGzD2LO94LTiqL1or4/TUP8bekUH6NMb0mXkxN1N3el fkTX2MGj85SaSsoMFwFiBvwnAdr3yAASSbBrZAD6sLBuornHlH+tYXOqXPLvvucsgaq+ uiBeO7f5MNVOPSXCt0JNTNuUlyYkU0ZnkOy5dwHLprlci+yGJDgeV+tqUfqmsycQa3AD Df5M5UQny8b3kLiZPu9Hm/dDJwUYhy3t3Rrc1dogYJbu/cYkEU5um676ymkb5/JPTkmA Lklw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xDhKb4d1; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si9551351edy.200.2020.07.06.06.35.16; Mon, 06 Jul 2020 06:35:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xDhKb4d1; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729482AbgGFNfN (ORCPT + 5 others); Mon, 6 Jul 2020 09:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729197AbgGFNeO (ORCPT ); Mon, 6 Jul 2020 09:34:14 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E590C061794 for ; Mon, 6 Jul 2020 06:34:13 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so39377634wmg.1 for ; Mon, 06 Jul 2020 06:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=xDhKb4d1kq4g63PE6Kw+d0pJTKLnw/IIJQRWCvGGBRKLAySHr3nXCYdnP0FF+KYdgl vilMW0c0k6s1Ego/Dne9r8otV3SFOpks3w1DdJX6EPTI97pwdrKlIb2UKkbKdM3aDVlj oSrJ9yzAacAEyGyCdl7WGdOS1ZgDlhAHAlm1LeHkd9CpJeixRsVwXY0hZ/8oKIB1aA7R tQf8xNsPpdj7GOKICfWv8NpWcwtVpUjJFXZFlcmBUynkOisE2Sqp7YJSGA42CjzUdB7j d48tqL2Z+IA4acMLvxU18EamPKiWgdTtUL2LpLPFNEyrurJ1mT7m8OpdBkl5rzIdpn3b 0snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=spwTB8Z3vtqPRSIo1u99v9fuInSBKTXt3LCGxPltWRHG8fwiHQgcHgwGsG6AbMjkFm k6GMPh8XBEL6us0kslX15d+lmq+h8SCieGTaRAzUH6iBPfGz65lwtdXITMf5c7Ralx2A jWCl1Gm0D/aT06CoWS8Hl3lfkQI97c2UNe2KTBWFV4k1DWtHqhZLxp5A9NgKypHRJXtb OJmKJ7VBJlD13Xowok/WjizqaY9R4DHQiMrSX3oyOFDJbPzIcJiXMpVhYv/UqgbOvoYZ l2kASdDqlNNNVYYF3Swk9PJ5JnbytXxZJvqBCl2Xj7FBM4uA/oTpQd5j2UmUDAT4zaYk 1ltA== X-Gm-Message-State: AOAM532lq1rF0/ueTjoBAJbCoROhZjKhPfmNAWKixTEa8huzb0BO3PW7 mypji6FfeCb9MN5050SOYBDaCg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112738wma.4.1594042452163; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:11 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Jassi Brar , Christophe JAILLET Subject: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Date: Mon, 6 Jul 2020 14:33:32 +0100 Message-Id: <20200706133341.476881-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’: drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable] 626 | u8 addr; | ^~~~ Cc: Felipe Balbi Cc: Jassi Brar Cc: Christophe JAILLET Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/max3420_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 Acked-by: Jassi Brar diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c index 23f33946d80c4..52884bae4af11 100644 --- a/drivers/usb/gadget/udc/max3420_udc.c +++ b/drivers/usb/gadget/udc/max3420_udc.c @@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc) static void max3420_handle_setup(struct max3420_udc *udc) { struct usb_ctrlrequest setup; - u8 addr; spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8); @@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc) USB_TYPE_STANDARD | USB_RECIP_DEVICE)) { break; } - addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); return; case USB_REQ_CLEAR_FEATURE: