| Message ID | 20231103190758.82911-2-mario.limonciello@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | Improvements to pcie_bandwidth_available() for eGPUs | expand |
On Fri, 3 Nov 2023, Mario Limonciello wrote: > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > using dev_is_removable() to be able to detect USB4 devices as well. Please extend this with more details. I had to lookup the TBT change to be able to make any guess why you're doing this (and it's still a guess at best).
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: > On Fri, 3 Nov 2023, Mario Limonciello wrote: > > > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > > using dev_is_removable() to be able to detect USB4 devices as well. > > Please extend this with more details. I had to lookup the TBT change to > be able to make any guess why you're doing this (and it's still a guess > at best). Also please write it as Thunderbolt not TBT so that it is clear what we are talking about. Ditto to all patches.
On 11/6/2023 10:47, Mika Westerberg wrote: > On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: >> On Fri, 3 Nov 2023, Mario Limonciello wrote: >> >>> pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to >>> using dev_is_removable() to be able to detect USB4 devices as well. >> >> Please extend this with more details. I had to lookup the TBT change to >> be able to make any guess why you're doing this (and it's still a guess >> at best). > > Also please write it as Thunderbolt not TBT so that it is clear what we > are talking about. Ditto to all patches. Ack, thanks I will add more detail to these first few patches and make that s/TBT/Thunderbolt/ change when I rebase this on 6.7-rc1.
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c index f8bf0ec26844..14215b7ca187 100644 --- a/drivers/gpu/drm/nouveau/nouveau_vga.c +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c @@ -94,8 +94,8 @@ nouveau_vga_init(struct nouveau_drm *drm) vga_client_register(pdev, nouveau_vga_set_decode); - /* don't register Thunderbolt eGPU with vga_switcheroo */ - if (pci_is_thunderbolt_attached(pdev)) + /* don't register USB4/Thunderbolt eGPU with vga_switcheroo */ + if (dev_is_removable(&pdev->dev)) return; vga_switcheroo_register_client(pdev, &nouveau_switcheroo_ops, runtime); @@ -118,7 +118,7 @@ nouveau_vga_fini(struct nouveau_drm *drm) vga_client_unregister(pdev); - if (pci_is_thunderbolt_attached(pdev)) + if (dev_is_removable(&pdev->dev)) return; vga_switcheroo_unregister_client(pdev);
pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to using dev_is_removable() to be able to detect USB4 devices as well. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/gpu/drm/nouveau/nouveau_vga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)