From patchwork Sun Mar 16 10:26:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 874138 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FA919D08F; Sun, 16 Mar 2025 10:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742121163; cv=none; b=rop21n5u9MHUzDVWGQgfraityAYWt/8xoyImT5lu7NSxhuEJaQtfl9vSOao+jUBBiODEOH1C2e9LOEVZqckjzfcbVtNVv9/58XLf5vNW/h6sv3toUWRE22pyBWgK/oHhqxEHzaSSOUR2kHcfL7+WSV4ND7oEiQZBfpjdcvCnw0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742121163; c=relaxed/simple; bh=IoZRDSWclLoY0c9HHHU0rFNnEogfw3ECDrvyX7T0Ctw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YI7c8jgF3hfyedn6wrucEOgbu0XwAb9+gPPpidBe9U3SC4VgVNs7Zk12f8aBZ74/7xyy1MrRS4XgSaOWbVMo03RKP1/cXNCJjZVqrdvOZVMBJnOrYLnajL5HO2N9AFh2uFXsuQk+SlchSSNsUeERrE8A2imHX+X2DML6NYoT8hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=tvHt1/JH; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="tvHt1/JH" Received: from fedora.intra.ispras.ru (unknown [10.10.165.7]) by mail.ispras.ru (Postfix) with ESMTPSA id 262C146361CD; Sun, 16 Mar 2025 10:27:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 262C146361CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1742120844; bh=XnT7h38wk2Tx5Bqn00SrYumy1xtf5pPAUEWMtYlgi4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tvHt1/JHz0QzZHyftyuT49jk/JWvISlwk66JwW0IuwfdRR+c3apksWD5fjT9QpMnz 8Y7rPyM48hI82bYzt1THPSene62mD7kFVpl+/R6tKbOLfQmF/dxtTvLSgMw6pXEUxs m2HqMvzK9oh0VpGTRlmFGjc/OuCjPjEhadPMaTvU= From: Fedor Pchelkin To: Peter Chen , Frank Li Cc: Fedor Pchelkin , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Joe Hattori , Sebastian Reichel , Fabien Lahoudere , linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH v2 1/3] usb: chipidea: ci_hdrc_imx: fix usbmisc handling Date: Sun, 16 Mar 2025 13:26:54 +0300 Message-ID: <20250316102658.490340-2-pchelkin@ispras.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250316102658.490340-1-pchelkin@ispras.ru> References: <20250316102658.490340-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 usbmisc is an optional device property so it is totally valid for the corresponding data->usbmisc_data to have a NULL value. Check that before dereferencing the pointer. Found by Linux Verification Center (linuxtesting.org) with Svace static analysis tool. Fixes: 74adad500346 ("usb: chipidea: ci_hdrc_imx: decrement device's refcount in .remove() and in the error path of .probe()") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- drivers/usb/chipidea/ci_hdrc_imx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 1a7fc638213e..619779eef333 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -534,7 +534,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) cpu_latency_qos_remove_request(&data->pm_qos_req); data->ci_pdev = NULL; err_put: - put_device(data->usbmisc_data->dev); + if (data->usbmisc_data) + put_device(data->usbmisc_data->dev); return ret; } @@ -559,7 +560,8 @@ static void ci_hdrc_imx_remove(struct platform_device *pdev) if (data->hsic_pad_regulator) regulator_disable(data->hsic_pad_regulator); } - put_device(data->usbmisc_data->dev); + if (data->usbmisc_data) + put_device(data->usbmisc_data->dev); } static void ci_hdrc_imx_shutdown(struct platform_device *pdev)