| Message ID | 20250622171705.4148948-1-alok.a.tiwari@oracle.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] thunderbolt: Fix redundant Bit masking of ADP_DP_CS_1_AUX_RX_HOPID_MASK | expand |
On Sun, Jun 22, 2025 at 10:17:02AM -0700, Alok Tiwari wrote: > The tb_dp_port_set_hops() function was incorrectly clearing > ADP_DP_CS_1_AUX_RX_HOPID_MASK twice. > According to the function's purpose, it should clear both TX and RX AUX > hop ID fields. > Replace the first instance with ADP_DP_CS_1_AUX_TX_HOPID_MASK to ensure > proper configuration of both AUX directions. > > Fixes: 98176380cbe5 ("thunderbolt: Convert DP adapter register names to follow the USB4 spec") > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Applied to thunderbolt.git/fixes, thanks!
On Sun, Jun 22, 2025 at 10:17:03AM -0700, Alok Tiwari wrote: > Fixes two minor typos in Thunderbolt driver comments: > Correct "passwd" -> "passed" in nvm.c. > Correct "boths" -> "both" in switch.c. > > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Applied to thunderbolt.git/next, thanks!
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 28febb95f8fa1..36918a656f456 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -1450,7 +1450,7 @@ int tb_dp_port_set_hops(struct tb_port *port, unsigned int video, return ret; data[0] &= ~ADP_DP_CS_0_VIDEO_HOPID_MASK; - data[1] &= ~ADP_DP_CS_1_AUX_RX_HOPID_MASK; + data[1] &= ~ADP_DP_CS_1_AUX_TX_HOPID_MASK; data[1] &= ~ADP_DP_CS_1_AUX_RX_HOPID_MASK; data[0] |= (video << ADP_DP_CS_0_VIDEO_HOPID_SHIFT) &
The tb_dp_port_set_hops() function was incorrectly clearing ADP_DP_CS_1_AUX_RX_HOPID_MASK twice. According to the function's purpose, it should clear both TX and RX AUX hop ID fields. Replace the first instance with ADP_DP_CS_1_AUX_TX_HOPID_MASK to ensure proper configuration of both AUX directions. Fixes: 98176380cbe5 ("thunderbolt: Convert DP adapter register names to follow the USB4 spec") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> --- drivers/thunderbolt/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)