| Message ID | 20250624-dwc3-fix-gadget-mtp-v2-1-0e2d9979328f@leica-geosystems.com |
|---|---|
| State | New |
| Headers | show
Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011040.outbound.protection.outlook.com [52.101.65.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E08228689C; Tue, 24 Jun 2025 10:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750762425; cv=fail; b=f9mi9gJLgGcTJtEwtzGwwWOhrFI6BYe1KK/gMTCnaa989gkKguwDMWxfJLykvtYQ5cDsm6UYvwsjhuk12MRAlzMr8v5PVqgNXwxhvQKNszg2Kaoc1Vzb01FQyz1Uy8Re/AaPykMZ3nzIaPiM/udqnDiv/BVqfPwvh4ttJyN/5/U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750762425; c=relaxed/simple; bh=neZNTUymVbHPHw6syfk/hFLqcFLHJ0YX5YKiDoOIais=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EFDRz0QhEuGXeasS7fULDhQdR6TVmi+2LiKk1uG2OSdvaLeIfPNlGhhEGaNNjJ5Y3+n/FsxwSvOG/4CJb8/wPl9k7gFuIS1aFfWlx9bEixZd5j+1Sh9aT3JaCzzD7llWnNeSkaa7ZaBVslAC0HJEdw3l1ViEp/tui1YDrpdQULo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=leica-geosystems.com; spf=fail smtp.mailfrom=leica-geosystems.com; dkim=pass (1024-bit key) header.d=leica-geosystems.com header.i=@leica-geosystems.com header.b=sCNNuDsr; arc=fail smtp.client-ip=52.101.65.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=leica-geosystems.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=leica-geosystems.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=leica-geosystems.com header.i=@leica-geosystems.com header.b="sCNNuDsr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OdlY104UXRkk+cQV+f81PzgbLkEsHIJbYyb/UDVt/bXxHw/vOXYR2FwSfLHjqVF6cTXlH/KltpB7Xi8mmvjApzHikjumXuUFd8n65ZyxWucmC+NakEjxR97xkwl21fYGSbVmzWlXTpSRA0rqDRGniCXNmQ2VVgkYMnQCsYpk03JOIW4IrtkcfeBtieTdcp1D4Gc9b4u8FLk8dwHJCel4yPHmnRiYfpN4IzQdZSr+5S52SVMuGIIAxExPDgqis4/V6Je9ALokXbsI/TVO0ZphhxCw8buyZHdyi+Tqu7OLhgAvlhOFfBGG65TB723dbQNWQZWz53V4+hZi1fdsGYd+Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lJSGVLktELB2mglF8p2m3zl1G0aIPUNQNqJI0n+L8Ao=; b=SD8EQsA49/B0Nmo9/ltPyrS1o0F+5hrMpMgv/Azbu7dV0csF6EO2BOei1KvGgbsVTSALlcH2VIrmy4JKTG0wnnx8Qd+S0GSGiokNKGHhi3EOb4vxh0thUb/Ypt8ttsyOmE9t/rT1KnBIcL1JdCJ7xh/cZ5D3+CP8NPho+3zwweNPzr49g6Cngoa8YfhTnKOwNmcFUaRtXsZqdMc6CxIZWo0xRQXiNmkq9Pma7grcyaTuIqcnQ+3vfgIbzWC3dmYmj8WrtwIEYiMvDrFUAK5hmbqHRFQew8XdT1+VAG7NjDgfatOddpRUdiMwVNyUbEbyil4jgvWg1py5QVFTUX7syw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 193.8.40.94) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=leica-geosystems.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=leica-geosystems.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leica-geosystems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lJSGVLktELB2mglF8p2m3zl1G0aIPUNQNqJI0n+L8Ao=; b=sCNNuDsrff0XpfW+D1MxU/enQI6F/eAxQvHqXCuyNx5qU43AkqkwqCHYaEw00V3eswPb/SejOcdTjX+mdqxKUwIT+c613/4f1j5hWQwCeqv+wgrzBkZj/5B8bdL2rgnHP2r9udXreqpSRFcjMaJCdh93OKi/Sf9yJHC+dtlEyMs= Received: from AM0PR10CA0030.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::40) by AS8PR06MB7944.eurprd06.prod.outlook.com (2603:10a6:20b:3c6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Tue, 24 Jun 2025 10:53:41 +0000 Received: from AMS0EPF000001A7.eurprd05.prod.outlook.com (2603:10a6:208:17c:cafe::8d) by AM0PR10CA0030.outlook.office365.com (2603:10a6:208:17c::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.30 via Frontend Transport; Tue, 24 Jun 2025 10:53:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 193.8.40.94) smtp.mailfrom=leica-geosystems.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=leica-geosystems.com; Received-SPF: Pass (protection.outlook.com: domain of leica-geosystems.com designates 193.8.40.94 as permitted sender) receiver=protection.outlook.com; client-ip=193.8.40.94; helo=hexagon.com; pr=C Received: from hexagon.com (193.8.40.94) by AMS0EPF000001A7.mail.protection.outlook.com (10.167.16.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 10:53:41 +0000 Received: from aherlnxbspsrv01.lgs-net.com ([10.60.34.116]) by hexagon.com with Microsoft SMTPSVC(10.0.17763.1697); Tue, 24 Jun 2025 12:53:40 +0200 From: Johannes Schneider <johannes.schneider@leica-geosystems.com> Date: Tue, 24 Jun 2025 12:53:12 +0200 Subject: [PATCH v2 1/2] usb: dwc3: gadget: Fix TRB reclaim logic for short transfers and ZLPs Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: <linux-usb.vger.kernel.org> List-Subscribe: <mailto:linux-usb+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-usb+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250624-dwc3-fix-gadget-mtp-v2-1-0e2d9979328f@leica-geosystems.com> References: <20250624-dwc3-fix-gadget-mtp-v2-0-0e2d9979328f@leica-geosystems.com> In-Reply-To: <20250624-dwc3-fix-gadget-mtp-v2-0-0e2d9979328f@leica-geosystems.com> To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, bsp-development.geo@leica-geosystems.com, Johannes Schneider <johannes.schneider@leica-geosystems.com> X-Mailer: b4 0.14.2 X-OriginalArrivalTime: 24 Jun 2025 10:53:40.0103 (UTC) FILETIME=[3E9B8970:01DBE4F6] X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001A7:EE_|AS8PR06MB7944:EE_ X-MS-Office365-Filtering-Correlation-Id: a08488c0-146e-4c67-854f-08ddb30d61bf X-SET-LOWER-SCL-SCANNER: YES X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?lXNcNsNGpYWxQ0ovqu2IaBhtxv+JwnS?= =?utf-8?q?rA/ZYYsYuwvmhQt3uc/+HTcbsP/mw0PEWw+zi1ZmnwdomRefr3Hn2lBokLl/DPn6e?= =?utf-8?q?/WqNkAC7hE9PUVbuyE+mPDwRGMr7vXVnlDNgm9Fr+6aKx1bOsJBNI1yQZHTUkaDf5?= =?utf-8?q?48fCRCsoRukTr0/+XhNidR/OuqswrM5IayBm3GTOGfr/lsSDru1I9zJ2iSsIlrXdr?= =?utf-8?q?30yGgL50Yk0gzPpAkHbxita3hc7E33rSUDyiu+qLWnKWjGD8Ycm6ClAsdOZj1jnDl?= =?utf-8?q?/L3QoAaPf75HAwF6kIsUNI1MkUzevrjzBoV6FUIm0glQ+WMw072bDp9AvuH90ChdN?= =?utf-8?q?u5fCexjhOrDzWQFQimbSj12c7APmWGO4b5a3cFBIniuf2KCxAFupRfslsoYLYwXWI?= =?utf-8?q?KDE+kzLNrdZFibYGuJDT6W0pTYOJ6mmfPWohPBGfnKAYE6/kroL2RYKFXa5wyvfOx?= =?utf-8?q?I7dAUaOfKTk5NWnDEC1TVK78CeUDTXPmJ0WbdOsrxd0oQQKtPFGIIocGji8DHxoIE?= =?utf-8?q?i6m7PG2d5LFEdQOmAFLIzuihDouWhdd/CXWyfnKDvAaDRoK5Xvv4mat/H/ZeJMpmE?= =?utf-8?q?DRjvTriKJ8MSSXMs93VquqypFv6DWAEwxzE3aHmeTbomGwlW5Ws8WDxnJ/ThgsltX?= =?utf-8?q?9Dac8fYeRpLu5gpXSW1R0dVWAdF5OJJvarJhIq8khlutqgrdTwSM0mKMqWyRssvsE?= =?utf-8?q?7xR66BbELc+A2CFwKgQTXum+mqiUMKQDZTChHqwGGz/8HJuMGTozLgfaFh7CgOT2/?= =?utf-8?q?4+ei111GP7ve40BLYPeegd7XE4y1N/A5gmTDOo0KGlUKcYxBOiqIdMs/sqB0QMKkJ?= =?utf-8?q?0Tdn7GjdYz1True7LhIXEdzgLQo+Lpfv5Q24/EjyCQRE8Jn5jAh2cmumQHKUZNlIu?= =?utf-8?q?GcLHiGlrfrcOGO0izvuNOaE1hHRO+oCWiYIzlZCEPVZ1D80o4XYfkiJBhKrFGbxTX?= =?utf-8?q?kwMcImZ3QNl72cuj/CQEydqk+thTByGOAQVqfXKF+iclu8hs8izPiCyzo9EpLVhNr?= =?utf-8?q?w86STUe1uZmqIL42qaLQQWUkq0ZFqNWa8WF0QvcAvjP7MUKhRy7+WrJLydccsLH6q?= =?utf-8?q?bcMc8SJkxXVWKsH43mPanvEj7GQgL2yVMZbq9qFCMgWdAKtHAImqRjI49l98jxU8h?= =?utf-8?q?4dTdrHxnyocJegjS8rW34lqfZCecpOlwVxQSxMgDZgIxF+MhHBB11T+0fC+RlgurP?= =?utf-8?q?t44iX64Z8HjCY1tE6QxV3lMMEO5f4ez7UBgSJPMN0eDjA+EQ1bzpSA7ONQ0UrlM0z?= =?utf-8?q?Q6/wSulS8dY/383vomdbVojO9D3Np3V2JU23EqtIJ5vPwtQ1XaMH/VJCtUuYPDRLw?= =?utf-8?q?dQZjSWpWCH6G+nR7l6KRsZwdhzPHtp94ln+S3JDD2BDMb3/KSI1KiRBrTEn2sAOLo?= =?utf-8?q?6sEqMKjy0Ooj9B0ZpN8O0R8wpTO13NiB0U9tXLe8i0YZREwJ89TDzIdqUjB0nfy/l?= =?utf-8?q?B31em9Db0v?= X-Forefront-Antispam-Report: CIP:193.8.40.94;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:hexagon.com;PTR:ahersrvdom50.leica-geosystems.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: leica-geosystems.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 10:53:41.1461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a08488c0-146e-4c67-854f-08ddb30d61bf X-MS-Exchange-CrossTenant-Id: 1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a;Ip=[193.8.40.94];Helo=[hexagon.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A7.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR06MB7944 |
| Series |
[v2,1/2] usb: dwc3: gadget: Fix TRB reclaim logic for short transfers and ZLPs
|
expand
|
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 321361288935db4b773cd06235a16670a6adda1a..99fbd29d8f46d30df558ceb23d2afe7187b4244c 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -3516,7 +3516,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep, * We're going to do that here to avoid problems of HW trying * to use bogus TRBs for transfers. */ - if (chain && (trb->ctrl & DWC3_TRB_CTRL_HWO)) + if (trb->ctrl & DWC3_TRB_CTRL_HWO) trb->ctrl &= ~DWC3_TRB_CTRL_HWO; /*
Commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling") updated the TRB reclaim path to use the TRB CHN (Chain) bit to determine whether a TRB was part of a chain. However, this inadvertently changed the behavior of reclaiming the final TRB in some scatter-gather or short transfer cases. In particular, if the final TRB did not have the CHN bit set, the cleanup path could incorrectly skip clearing the HWO (Hardware Own) bit, leaving stale TRBs in the ring. This resulted in broken data transfer completions in userspace, notably for MTP over FunctionFS. Fix this by unconditionally clearing the HWO bit during TRB reclaim, regardless of the CHN bit state. This restores correct behavior especially for transfers that require ZLPs or end on non-CHN TRBs. Fixes: 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling") Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com> --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)