mbox series

[0/5] diag288 watchdog fixes and improvements

Message ID 20230203073958.1585738-1-egorenar@linux.ibm.com
Headers show
Series diag288 watchdog fixes and improvements | expand

Message

Alexander Egorenkov Feb. 3, 2023, 7:39 a.m. UTC 
Minor code refactoring to improve readability of the driver,
reduce code duplication and remove dead code.

Alexander Egorenkov (5):
  watchdog: diag288_wdt: get rid of register asm
  watchdog: diag288_wdt: remove power management
  watchdog: diag288_wdt: unify command buffer handling for diag288 zvm
  watchdog: diag288_wdt: de-duplicate diag_stat_inc() calls
  watchdog: diag288_wdt: unify lpar and zvm diag288 helpers

 drivers/watchdog/diag288_wdt.c | 162 ++++++++-------------------------
 1 file changed, 37 insertions(+), 125 deletions(-)

Comments

Heiko Carstens Feb. 6, 2023, 9:59 a.m. UTC | #1 
On Fri, Feb 03, 2023 at 08:39:53AM +0100, Alexander Egorenkov wrote:
> Minor code refactoring to improve readability of the driver,
> reduce code duplication and remove dead code.
> 
> Alexander Egorenkov (5):
>   watchdog: diag288_wdt: get rid of register asm
>   watchdog: diag288_wdt: remove power management
>   watchdog: diag288_wdt: unify command buffer handling for diag288 zvm
>   watchdog: diag288_wdt: de-duplicate diag_stat_inc() calls
>   watchdog: diag288_wdt: unify lpar and zvm diag288 helpers
> 
>  drivers/watchdog/diag288_wdt.c | 162 ++++++++-------------------------
>  1 file changed, 37 insertions(+), 125 deletions(-)

Guenter, Wim, how should this go upstream?

I can easily pick this up via the s390 tree for the next merge window.
Please let me know.

Thanks,
Heiko
Guenter Roeck Feb. 6, 2023, 1:55 p.m. UTC | #2 
On 2/6/23 01:59, Heiko Carstens wrote:
> On Fri, Feb 03, 2023 at 08:39:53AM +0100, Alexander Egorenkov wrote:
>> Minor code refactoring to improve readability of the driver,
>> reduce code duplication and remove dead code.
>>
>> Alexander Egorenkov (5):
>>    watchdog: diag288_wdt: get rid of register asm
>>    watchdog: diag288_wdt: remove power management
>>    watchdog: diag288_wdt: unify command buffer handling for diag288 zvm
>>    watchdog: diag288_wdt: de-duplicate diag_stat_inc() calls
>>    watchdog: diag288_wdt: unify lpar and zvm diag288 helpers
>>
>>   drivers/watchdog/diag288_wdt.c | 162 ++++++++-------------------------
>>   1 file changed, 37 insertions(+), 125 deletions(-)
> 
> Guenter, Wim, how should this go upstream?
> 
> I can easily pick this up via the s390 tree for the next merge window.
> Please let me know.
> 

I have it currently in my watchdog-next tree, but that is not in linux-next.
Fine with me to go through the s390 tree.

Guenter
Heiko Carstens Feb. 6, 2023, 2:33 p.m. UTC | #3 
On Mon, Feb 06, 2023 at 05:55:40AM -0800, Guenter Roeck wrote:
> On 2/6/23 01:59, Heiko Carstens wrote:
> > On Fri, Feb 03, 2023 at 08:39:53AM +0100, Alexander Egorenkov wrote:
> > > Minor code refactoring to improve readability of the driver,
> > > reduce code duplication and remove dead code.
> > > 
> > > Alexander Egorenkov (5):
> > >    watchdog: diag288_wdt: get rid of register asm
> > >    watchdog: diag288_wdt: remove power management
> > >    watchdog: diag288_wdt: unify command buffer handling for diag288 zvm
> > >    watchdog: diag288_wdt: de-duplicate diag_stat_inc() calls
> > >    watchdog: diag288_wdt: unify lpar and zvm diag288 helpers
> > > 
> > >   drivers/watchdog/diag288_wdt.c | 162 ++++++++-------------------------
> > >   1 file changed, 37 insertions(+), 125 deletions(-)
> > 
> > Guenter, Wim, how should this go upstream?
> > 
> > I can easily pick this up via the s390 tree for the next merge window.
> > Please let me know.
> 
> I have it currently in my watchdog-next tree, but that is not in linux-next.
> Fine with me to go through the s390 tree.

Applied to s390 tree - should be in next linux-next release.

Thank you!