From patchwork Mon May 15 15:50:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 99820 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1609709qge; Mon, 15 May 2017 08:51:41 -0700 (PDT) X-Received: by 10.98.103.87 with SMTP id b84mr7260114pfc.235.1494863501434; Mon, 15 May 2017 08:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494863501; cv=none; d=google.com; s=arc-20160816; b=un/sbhQAsahVDd/IDKhWQ0AccQfP1eca9ts6qG8+Lo5F5LPjbDVui8niRTsAGjmBYi 5fokRrqpxNx6nADn+gszO2ZuyqxT2fgsyBWretH/LLyPEMW4Ypeir6lyM+mhVhf54/wV 0ijKBTHg/ggGeuquvB/0AOnHrVhBmNeUt9cM+hFJ6N+TXcqFtyyBX2eRqYP1OlnSu0vK lvaW7OSNLuHs2dzv9aL1mpS5TkNcP8AsOvaVwuWXd0UTUahM6rWsj+8A+t5wWFFRhPyJ 12WaKiPg8YQhtZWt2Pm+afg8ofIuY2k+KI3rKznmwTZCxpM7qx7/O4rtGRuRy+hzSLhq Z53w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=NOqTiSavyMrWdswwTnQISYKUhmkNlBLWIHVHKG4SOVA=; b=jwStDIguZXMF4LF9Cy8WMrL9nVN9rIhqb8RS05g/WyVYivdvG9zIxjyR5k3WfFU0NT oMGKndtmK7Qcv7hbMQ6Ay1kYiY/SWeJEVPFzRUQPvHypE7/zYcRCZTdE5UhEHGGOtUyE flVXwKtOXV6pXPq4xYwYrs9VdgP/t11OnZRyn0h4+DrBZ/2vTUtUSpb1YdVflnzUo32N wQ8n6hxTGsMPKE68+EQO+qOidth+dg4Y8/h+a/QunTctxLMwtqfh6PR2kDVzjwdAz86e qoE3Df9aC3mAzrxwUYH8EvzRzZjqra8iFbZC+qZMhmdgX3JK0iWQZYAraT1PVRnNkMG1 aIXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-watchdog-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-watchdog-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si10938047pgj.101.2017.05.15.08.51.41 for ; Mon, 15 May 2017 08:51:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-watchdog-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-watchdog-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-watchdog-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbdEOPvk (ORCPT ); Mon, 15 May 2017 11:51:40 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59135 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbdEOPvj (ORCPT ); Mon, 15 May 2017 11:51:39 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MMrpj-1d54XL3wgZ-008aP8; Mon, 15 May 2017 17:50:45 +0200 From: Arnd Bergmann To: Guenter Roeck Cc: Arnd Bergmann , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] watchdog: orion: don't build for ARCH_EBSA110 Date: Mon, 15 May 2017 17:50:19 +0200 Message-Id: <20170515155040.1521131-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:WR1dvucirEiRyZF1yDTcvrVtYUnOPJpVBgM5BKu2P4ZZVXBkO9S BXDdtZakQRPnrTTgY0B4CafN8mj4pqMBtMs00FQRriyHH35x917PbTU7YHenuW0V9N1E+98 XsVrqJyCbdJrsD+Llum+zdFd9xiz0yFYvS6J5FHgXcTenDqdbr8EEQoHaQmhBjE86mBxImG 6tpVXWWTQD02Y9JSvhViA== X-UI-Out-Filterresults: notjunk:1; V01:K0:NYN4x89eunE=:V/nryNY1ji6YKkRjk3UYAx jhasCoaH7OE8Lok5cYdO7D5+I/afkIgX2EN+Wzt+Sqd/fcua64j1Dp0+6p8a7mbJfCZlxeBD6 8OLRFH8tbwrJK9fmtxpZ4k/xexgkHBcIxXxsgGiPeF9yf6LBcnIcc03WqTHQ8YmX4SvfWVxe8 RQRuEAJY3B5CJHe3IId8GMm6aACB81t5PEbJc/e8kI6PCvEXbsImt/p1O9GYN60/fAFZwjEkZ kwyTJX3CR7PFAvQcj8KitCZJJ9aN20ojlGJ6ftYSOuoAawg5vN/e+vUhHWSDutaeDVArRyM5o E6WFSaVDSItiLS4mxnlkHqG5aUJr4cEBU9ypJGyK0iHwt1rsYpBW7V+0w+UJKcWT3SQraLcGL Cai9VC2dpK41pq618i0hKemufGN8zo/2zlVoCJnr4OgzGY629Cw3fZp07xpeliql1rAgXiXHS ojp2cGJMNIk5UiWJie90NLXVHNgD/DzWx7bH+oF96tcuaGKSMmxKIxXlF3M3MwYzPVPTVCHJQ 0H+LOghff1QgZ4mKYkSvH1DtbQgOXuExuNUrF2HdCg3KJ2upJe8Mwhn4926txxrRfFVZBbbmM 7UZ7MMCRAEiFEQIhr963QbzfSZfgdOZ5GtWF35iO+OMklplO2wDLpGaQYJlC4hii4pJ/IX24R CBJYJ7BaYhwvvkVy4KDoUfrsHAhZRWY+Acs211Lg7QBPYF+UlOaE8WXya6HO2qmvcnQU= Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org The randconfig builder caught another corner case with this driver that fails to build for EBSA110 since that has its own MMIO handlers and lacks atomic_io_modify: drivers/watchdog/orion_wdt.o: In function `orion_stop': orion_wdt.c:(.text.orion_stop+0x28): undefined reference to `atomic_io_modify' orion_wdt.c:(.text.orion_stop+0x3c): undefined reference to `atomic_io_modify' drivers/watchdog/orion_wdt.o: In function `armada370_wdt_clock_init': orion_wdt.c:(.text.armada370_wdt_clock_init+0x2c): undefined reference to `atomic_io_modify' drivers/watchdog/orion_wdt.o: In function `armada375_stop': orion_wdt.c:(.text.armada375_stop+0x28): undefined reference to `atomic_io_modify' orion_wdt.c:(.text.armada375_stop+0x58): undefined reference to `atomic_io_modify' The best workaround I can think of is to add another Kconfig dependency. We could add atomic_io_modify() for ebsa110 in theory, but it seemed wrong because that platform would never actually use it. Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") Signed-off-by: Arnd Bergmann --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Guenter Roeck diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 52a70ee6014f..feead0dbfc55 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -453,7 +453,7 @@ config DAVINCI_WATCHDOG config ORION_WATCHDOG tristate "Orion watchdog" depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU || COMPILE_TEST - depends on ARM + depends on ARM && !ARCH_EBSA110 select WATCHDOG_CORE help Say Y here if to include support for the watchdog timer