From patchwork Wed May 12 08:47:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sanil, Shruthi" X-Patchwork-Id: 437680 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A333AC433B4 for ; Wed, 12 May 2021 08:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67E6861425 for ; Wed, 12 May 2021 08:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231249AbhELItF (ORCPT ); Wed, 12 May 2021 04:49:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:31189 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbhELItD (ORCPT ); Wed, 12 May 2021 04:49:03 -0400 IronPort-SDR: I5NQAoAQXOfLlFQuKA22rXDkZtmLvwNDy77dU4arauKLXqx2UcMBp6nsEUzTt+KL5zkFMQMCz1 csOfAlVwJsww== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199709047" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="199709047" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 01:47:56 -0700 IronPort-SDR: MwvU7SPuBhavIl9S0mwIM6jmpAU28wNbGkbqFBflKYPiu//L7baOddpsnA2q2NxocbDh+oRTpt 4ebWF2zcQk9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="435106510" Received: from bspteam04.iind.intel.com ([10.106.46.142]) by fmsmga008.fm.intel.com with ESMTP; 12 May 2021 01:47:51 -0700 From: shruthi.sanil@intel.com To: wim@linux-watchdog.org, linux@roeck-us.net, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Cc: andriy.shevchenko@linux.intel.com, kris.pan@linux.intel.com, mgross@linux.intel.com, srikanth.thokala@intel.com, lakshmi.bai.raja.subramanian@intel.com, mallikarjunappa.sangannavar@intel.com, shruthi.sanil@intel.com Subject: [PATCH 07/10] watchdog: keembay: Update the check in keembay_wdt_resume() Date: Wed, 12 May 2021 14:17:21 +0530 Message-Id: <20210512084724.14634-8-shruthi.sanil@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210512084724.14634-1-shruthi.sanil@intel.com> References: <20210512084724.14634-1-shruthi.sanil@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org From: Shruthi Sanil Corrected the typo in the function keembay_wdt_resume, we need to enable the WDT if it is disabled/not active. Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc") Reviewed-by: Andy Shevchenko Tested-by: Kris Pan Signed-off-by: Shruthi Sanil --- drivers/watchdog/keembay_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c index dd192b8dff55..10896415f8c7 100644 --- a/drivers/watchdog/keembay_wdt.c +++ b/drivers/watchdog/keembay_wdt.c @@ -260,7 +260,7 @@ static int __maybe_unused keembay_wdt_resume(struct device *dev) { struct keembay_wdt *wdt = dev_get_drvdata(dev); - if (watchdog_active(&wdt->wdd)) + if (!watchdog_active(&wdt->wdd)) return keembay_wdt_start(&wdt->wdd); return 0;