diff mbox series

[v5,1/5] mfd: da9062: make register CONFIG_I writable

Message ID 20211206064732.280375-1-andrej.picej@norik.com
State New
Headers show
Series [v5,1/5] mfd: da9062: make register CONFIG_I writable | expand

Commit Message

Andrej Picej Dec. 6, 2021, 6:47 a.m. UTC
From: Stefan Christ <s.christ@phytec.de>

Make the config register CONFIG_I writable to change the watchdog mode.

Signed-off-by: Stefan Christ <s.christ@phytec.de>
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Changes in v5:
- no changes

Changes in v4:
 - no changes

Changes in v3:
 - no changes

Changes in v2:
 - no changes
 drivers/mfd/da9062-core.c | 1 +
 1 file changed, 1 insertion(+)


Christoph Niedermaier April 11, 2022, 9:06 a.m. UTC | #1
From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck
Sent: Monday, December 6, 2021 6:12 PM
> On 12/6/21 8:46 AM, Adam Thomson wrote:
>> On 06 December 2021 06:47, Andrej Picej wrote:
>>> From: Stefan Christ <s.christ@phytec.de>
>>> Make the config register CONFIG_I writable to change the watchdog mode.
>>> Signed-off-by: Stefan Christ <s.christ@phytec.de>
>>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> I've already provided 'Reviewed-by' tags for the other patches in this set. In
>> the future you can add any received tags on to patch re-submissions where
>> nothing has changed since last review.
>> Anyway, thanks for the work on this, and for the patch set:
>> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> In this context:
> I expect that tags are present in patchwork. If a submitter drops tags
> in a new revision of a patch series, those will get lost. The underlying
> assumption is that the submitter had a reason to drop tags, such as
> substantial changes in an affected patch. I can not assume that the
> submitter dropped a tag accidentally and re-apply it, unless the reason
> was explicitly provided (obviously that is typically not the case since
> people don't usually add "accidentally dropped Reviewed-by: tags" to
> change logs).
> Also, I do not look into one patch of a series and apply tags to other
> patches of that series. Similar reason, only here it is worse because Wim
> may pull a patch from patchwork, from an e-mail, or from my watchdog-next
> branch. We can't have all of them have different tags, so I take what is
> in patchwork and nothing else (and your updated Reviewed-by: tag will
> not apply to other patches of the series because it isn't in patchwork
> for those).
> I also see that my own Reviewed-by: tag (or tags, I didn't check all
> of them) was/were dropped in v5 of this series. That means I'll have to
> re-review the series to see what changed, which will take time and means
> that the series will end up at the bottom of my review queue.
> Please keep that in mind when dropping tags.

Hi Guenter,

Is there anything against applying the first 4 patches of this series?

Thanks and regards
diff mbox series


diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
index 01f8e10dfa55..7041ba53efb4 100644
--- a/drivers/mfd/da9062-core.c
+++ b/drivers/mfd/da9062-core.c
@@ -556,6 +556,7 @@  static const struct regmap_range da9062_aa_writeable_ranges[] = {
 	regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
 	regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
 	regmap_reg_range(DA9062AA_BBAT_CONT, DA9062AA_BBAT_CONT),
+	regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I),
 	regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),