| Message ID | 20220608095623.22327-11-tmaimon77@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand |
On 08/06/2022 11:56, Tomer Maimon wrote: > Add nuvoton,sysgcr syscon property to the reset > node to handle the general control registers. Wrong wrapping. Best regards, Krzysztof
Hi Krzysztof, Thanks for your comments On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/06/2022 11:56, Tomer Maimon wrote: > > Add nuvoton,sysgcr syscon property to the reset > > node to handle the general control registers. > > Wrong wrapping. it will be very helpful if you could point me what wrong wrapped in the commit message, is it the explanation or the header? or something else? > > Best regards, > Krzysztof Best regards, Tomer
Hi Tomer, On Thu, 9 Jun 2022 at 14:30, Tomer Maimon <tmaimon77@gmail.com> wrote: > > Hi Krzysztof, > > Thanks for your comments > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > On 08/06/2022 11:56, Tomer Maimon wrote: > > > Add nuvoton,sysgcr syscon property to the reset > > > node to handle the general control registers. > > > > Wrong wrapping. > it will be very helpful if you could point me what wrong wrapped in > the commit message, is it the explanation or the header? or something > else? The commit message body should be wrapped at 72 chars. You can fit more on the first line if you reflow: Add nuvoton,sysgcr syscon property to the reset node to handle the general control registers. > > > > Best regards, > > Krzysztof > > Best regards, > > Tomer
Hi Benjamin, Thanks a lot for your explanation. will be applied in next patch set Best regards, Tomer On Fri, 10 Jun 2022 at 01:11, Benjamin Fair <benjaminfair@google.com> wrote: > > Hi Tomer, > > On Thu, 9 Jun 2022 at 14:30, Tomer Maimon <tmaimon77@gmail.com> wrote: > > > > Hi Krzysztof, > > > > Thanks for your comments > > > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > > > > On 08/06/2022 11:56, Tomer Maimon wrote: > > > > Add nuvoton,sysgcr syscon property to the reset > > > > node to handle the general control registers. > > > > > > Wrong wrapping. > > it will be very helpful if you could point me what wrong wrapped in > > the commit message, is it the explanation or the header? or something > > else? > > The commit message body should be wrapped at 72 chars. You can fit > more on the first line if you reflow: > > Add nuvoton,sysgcr syscon property to the reset node to handle the > general control registers. > > > > > > > Best regards, > > > Krzysztof > > > > Best regards, > > > > Tomer
On 09/06/2022 23:30, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comments > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 08/06/2022 11:56, Tomer Maimon wrote: >>> Add nuvoton,sysgcr syscon property to the reset >>> node to handle the general control registers. >> >> Wrong wrapping. > it will be very helpful if you could point me what wrong wrapped in > the commit message, is it the explanation or the header? or something > else? I pointed you last time. I pointed the exact line, exact rule you need to follow. I pointed it three times already and three times I said wrapping is wrong: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 "The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch." Your wrapping is not at 75 columns and it causes the commit to be less readable, without any reason. Please follow Linux kernel coding style/rules. Best regards, Krzysztof
Hi Krzysztof, Thanks for the clarifications, will update the next version. Best regards, Tomer On Fri, 10 Jun 2022 at 12:51, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/06/2022 23:30, Tomer Maimon wrote: > > Hi Krzysztof, > > > > Thanks for your comments > > > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 08/06/2022 11:56, Tomer Maimon wrote: > >>> Add nuvoton,sysgcr syscon property to the reset > >>> node to handle the general control registers. > >> > >> Wrong wrapping. > > it will be very helpful if you could point me what wrong wrapped in > > the commit message, is it the explanation or the header? or something > > else? > > I pointed you last time. I pointed the exact line, exact rule you need > to follow. I pointed it three times already and three times I said > wrapping is wrong: > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > "The body of the explanation, line wrapped at 75 columns, which will be > copied to the permanent changelog to describe this patch." > > Your wrapping is not at 75 columns and it causes the commit to be less > readable, without any reason. Please follow Linux kernel coding style/rules. > > > Best regards, > Krzysztof
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi index 3696980a3da1..8a2f29016291 100644 --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi @@ -110,6 +110,7 @@ rstc: rstc@f0801000 { compatible = "nuvoton,npcm750-reset"; reg = <0xf0801000 0x70>; #reset-cells = <2>; + nuvoton,sysgcr = <&gcr>; }; clk: clock-controller@f0801000 {
Add nuvoton,sysgcr syscon property to the reset node to handle the general control registers. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 1 + 1 file changed, 1 insertion(+)