From patchwork Fri Jul 15 23:44:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 591170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC79BC433EF for ; Fri, 15 Jul 2022 23:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbiGOXo6 (ORCPT ); Fri, 15 Jul 2022 19:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiGOXo5 (ORCPT ); Fri, 15 Jul 2022 19:44:57 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 367B42F39A; Fri, 15 Jul 2022 16:44:56 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id f2so8685005wrr.6; Fri, 15 Jul 2022 16:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N5thT5NLuuwBXvq/8xQLslRAV9uyeybXk3ABL1LJfB8=; b=LjVIvJAn9fdZk2OrXoQ8ff19epOy40bmGq3pNUtPVjU7V9kD9o1g7TuDMXR0CuOzeY i6tf3uO/yySDxAdp5EChuL/9W+5yOAdj0LPiXHxqcU7imbuRyFONDb570+ZE0ujA/bb+ Q4YTTjPOBRrUKS5Ne5F9c6yROkrItyES7sGCJ8oRb22AxGWp15VlGRkV7QU7pNl1HHyr 1m6+v725KBVITMslzzVAf2+bAsLUDcOLpk8T400EMjnPQWS9+DYlTFt5Tq2C5Suud85C epqmkAPav+SaXEPUA+YzdLBkU1OCN5OvMLlhm8IDA1pOm8Zi+TDvuQ1vfbkC1mwRZNMY dMuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N5thT5NLuuwBXvq/8xQLslRAV9uyeybXk3ABL1LJfB8=; b=qFjAAagub6BKeDIdarRMpfxibzZ1qsjdTTWsHaNho233IVsKuLYDKFCq0kgwCVZUfu 8dOjOhyKwe9M77JI8SVrpe1o7QRwzzd6SUIlZ7FxSkmvPWT7THv94AfXbpi4UPE8QWeh edimozvbxRrzVe8xunBoE12C1S7wHghGQBSYkry3IAlF80KMMJN6dKJxWf8lcWYbCrdB 2KTZEe+Mjun1lAlmbHihmKAq7+Y8Ig7vCaHhX9Z9XJjT1lDFV8sUG/3lTciY5s0y7n1h Xvf90fuk9mGGLTCDlAned2kWaEZ+hPXArCljmSx0Pr7uc4ZBxngUaS8mo5pJmQwBlCWL hcmQ== X-Gm-Message-State: AJIora+cVQf2r1zjaejCLYcyL1AwBOvFdfULZXEH4mUQPqVZkQNzI2Lm gwW/JAihPFJedAaWfnRl8nysBpN1lwR3hV1q X-Google-Smtp-Source: AGRyM1tRDvCqGvBzZSYIVR1pmdU26g0rK0NtlHFqQ2H8p99fAOOyt11Mn1aP/UfHhkPIunamQHr3sA== X-Received: by 2002:a5d:66c1:0:b0:21d:6c98:7aa4 with SMTP id k1-20020a5d66c1000000b0021d6c987aa4mr14215841wrw.136.1657928694619; Fri, 15 Jul 2022 16:44:54 -0700 (PDT) Received: from localhost.localdomain ([2a01:4b00:9414:100:70ae:aa59:3138:f63c]) by smtp.gmail.com with ESMTPSA id r8-20020a5d52c8000000b0021d65e9d449sm5040776wrv.73.2022.07.15.16.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 16:44:53 -0700 (PDT) From: Alexey Klimov To: linux-watchdog@vger.kernel.org Cc: wim@linux-watchdog.org, linux@roeck-us.net, oneukum@suse.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, atishp@rivosinc.com, atishp@atishpatra.org, yury.norov@gmail.com, aklimov@redhat.com, atomlin@redhat.com, klimov.linux@gmail.com Subject: [PATCH v4] watchdog: add driver for StreamLabs USB watchdog device Date: Sat, 16 Jul 2022 00:44:42 +0100 Message-Id: <20220715234442.3910204-1-klimov.linux@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Driver supports StreamLabs usb watchdog device. The device plugs into 9-pin usb header and connects to reset pins and reset button pins on desktop PC. USB commands used to communicate with device were reverse engineered using usbmon. Signed-off-by: Alexey Klimov Reported-by: kernel test robot --- Changes since v3: -- added nowayout module param; -- removed usb_set_intfdata(intf, NULL) in ->disconnect since usb_unbind_interface() should take care of it; -- keep the usb_streamlabs_wdt_stop_cmd() in ->disconnect(). Disconnect can be triggered via sysfs or on module removing, it looks like we want to stop the watchdog on such events; Should it also be stopped in ->disconnect() only if !nowayout? -- rebased, cleanups, URL correction; -- migrated to managed (devm_*) interfaces; -- error in usb_streamlabs_wdt_validate_response() changed to -EPROTO; -- added entry in MAINTAINERS file; -- const struct usb_device_id and watchdog_ops; Previous version: https://lore.kernel.org/lkml/20170217092523.23358-1-klimov.linux@gmail.com/ MAINTAINERS | 6 + drivers/watchdog/Kconfig | 15 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/streamlabs_wdt.c | 311 ++++++++++++++++++++++++++++++ 4 files changed, 333 insertions(+) create mode 100644 drivers/watchdog/streamlabs_wdt.c diff --git a/MAINTAINERS b/MAINTAINERS index a5f65e7a113d..717d39a2d874 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19120,6 +19120,12 @@ W: http://www.stlinux.com F: Documentation/networking/device_drivers/ethernet/stmicro/ F: drivers/net/ethernet/stmicro/stmmac/ +STREAMLABS USB WATCHDOG DRIVER +M: Alexey Klimov +L: linux-watchdog@vger.kernel.org +S: Maintained +F: drivers/watchdog/streamlabs_wdt.c + SUN3/3X M: Sam Creasey S: Maintained diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 32fd37698932..64b7f947b196 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -2171,6 +2171,21 @@ config USBPCWATCHDOG Most people will say N. +config USB_STREAMLABS_WATCHDOG + tristate "StreamLabs USB watchdog driver" + depends on USB + help + This is the driver for the USB Watchdog dongle from StreamLabs. + If you correctly connect reset pins to motherboard Reset pin and + to Reset button then this device will simply watch your kernel to make + sure it doesn't freeze, and if it does, it reboots your computer + after a certain amount of time. + + To compile this driver as a module, choose M here: the + module will be called streamlabs_wdt. + + Most people will say N. Say yes or M if you want to use such usb device. + config KEEMBAY_WATCHDOG tristate "Intel Keem Bay SoC non-secure watchdog" depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST) diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile index c324e9d820e9..2d601da9b5bd 100644 --- a/drivers/watchdog/Makefile +++ b/drivers/watchdog/Makefile @@ -33,6 +33,7 @@ obj-$(CONFIG_WDTPCI) += wdt_pci.o # USB-based Watchdog Cards obj-$(CONFIG_USBPCWATCHDOG) += pcwd_usb.o +obj-$(CONFIG_USB_STREAMLABS_WATCHDOG) += streamlabs_wdt.o # ALPHA Architecture diff --git a/drivers/watchdog/streamlabs_wdt.c b/drivers/watchdog/streamlabs_wdt.c new file mode 100644 index 000000000000..f2b782f3c98e --- /dev/null +++ b/drivers/watchdog/streamlabs_wdt.c @@ -0,0 +1,311 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * StreamLabs USB Watchdog driver + * + * Copyright (c) 2016-2017,2022 Alexey Klimov + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* + * USB Watchdog device from Streamlabs: + * https://www.stream-labs.com/products/devices/watch-dog/ + * + * USB commands have been reverse engineered using usbmon. + */ + +#define DRIVER_AUTHOR "Alexey Klimov " +#define DRIVER_DESC "StreamLabs USB watchdog driver" +#define DRIVER_NAME "usb_streamlabs_wdt" + +MODULE_AUTHOR(DRIVER_AUTHOR); +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_LICENSE("GPL"); + +#define USB_STREAMLABS_WATCHDOG_VENDOR 0x13c0 +#define USB_STREAMLABS_WATCHDOG_PRODUCT 0x0011 + +/* + * one buffer is used for communication, however transmitted message is only + * 32 bytes long + */ +#define BUFFER_TRANSFER_LENGTH 32 +#define BUFFER_LENGTH 64 +#define USB_TIMEOUT 350 + +#define STREAMLABS_CMD_START 0xaacc +#define STREAMLABS_CMD_STOP 0xbbff + +/* timeout values are taken from windows program */ +#define STREAMLABS_WDT_MIN_TIMEOUT 1 +#define STREAMLABS_WDT_MAX_TIMEOUT 46 + +struct streamlabs_wdt { + struct watchdog_device wdt_dev; + struct usb_interface *intf; + struct mutex lock; + u8 *buffer; +}; + +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool, 0); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); + +/* + * This function is used to check if watchdog actually changed + * its state to disabled that is reported in first two bytes of response + * message. + */ +static int usb_streamlabs_wdt_check_stop(u16 *buf) +{ + if (buf[0] != cpu_to_le16(STREAMLABS_CMD_STOP)) + return -EINVAL; + + return 0; +} + +static int usb_streamlabs_wdt_validate_response(u8 *buf) +{ + /* + * If watchdog device understood the command it will acknowledge + * with values 1,2,3,4 at indexes 10, 11, 12, 13 in response message + * when response treated as 8bit message. + */ + if (buf[10] != 1 || buf[11] != 2 || buf[12] != 3 || buf[13] != 4) + return -EPROTO; + + return 0; +} + +static void usb_streamlabs_wdt_prepare_buf(u16 *buf, u16 cmd, + unsigned long timeout_msec) +{ + /* + * remaining elements expected to be zero everytime during + * communication + */ + buf[0] = cpu_to_le16(cmd); + buf[1] = cpu_to_le16(0x8000); + buf[3] = cpu_to_le16(timeout_msec); + buf[5] = 0x0; + buf[6] = 0x0; +} + +static int usb_streamlabs_wdt_cmd(struct streamlabs_wdt *wdt, u16 cmd) +{ + struct usb_device *usbdev; + unsigned long timeout_msec; + int retval; + int size; + + if (unlikely(!wdt->intf)) + return -ENODEV; + + usbdev = interface_to_usbdev(wdt->intf); + timeout_msec = wdt->wdt_dev.timeout * MSEC_PER_SEC; + + usb_streamlabs_wdt_prepare_buf((u16 *) wdt->buffer, cmd, timeout_msec); + + /* send command to watchdog */ + retval = usb_interrupt_msg(usbdev, usb_sndintpipe(usbdev, 0x02), + wdt->buffer, BUFFER_TRANSFER_LENGTH, + &size, USB_TIMEOUT); + if (retval) + return retval; + + if (size != BUFFER_TRANSFER_LENGTH) + return -EIO; + + /* and read response from watchdog */ + retval = usb_interrupt_msg(usbdev, usb_rcvintpipe(usbdev, 0x81), + wdt->buffer, BUFFER_LENGTH, + &size, USB_TIMEOUT); + if (retval) + return retval; + + if (size != BUFFER_LENGTH) + return -EIO; + + /* check if watchdog actually acked/recognized command */ + return usb_streamlabs_wdt_validate_response(wdt->buffer); +} + +static int usb_streamlabs_wdt_stop_cmd(struct streamlabs_wdt *wdt) +{ + /* how many times to re-send stop cmd */ + int retry_counter = 10; + int retval; + + /* + * Transition from enabled to disabled state in this device + * for stop command doesn't happen immediately. Usually, 2 or 3 + * (sometimes even 4) stop commands should be sent until + * watchdog answers 'I'm stopped!'. + * Retry only stop command if watchdog fails to answer correctly + * about its state. After 10 attempts go out and return error. + */ + + do { + retval = usb_streamlabs_wdt_cmd(wdt, STREAMLABS_CMD_STOP); + if (retval) + break; + + retval = usb_streamlabs_wdt_check_stop((u16 *) wdt->buffer); + + } while (retval && --retry_counter >= 0); + + return retry_counter > 0 ? retval : -EIO; +} + +static int usb_streamlabs_wdt_start(struct watchdog_device *wdt_dev) +{ + struct streamlabs_wdt *streamlabs_wdt = watchdog_get_drvdata(wdt_dev); + int retval; + + mutex_lock(&streamlabs_wdt->lock); + retval = usb_streamlabs_wdt_cmd(streamlabs_wdt, STREAMLABS_CMD_START); + mutex_unlock(&streamlabs_wdt->lock); + + return retval; +} + +static int usb_streamlabs_wdt_stop(struct watchdog_device *wdt_dev) +{ + struct streamlabs_wdt *streamlabs_wdt = watchdog_get_drvdata(wdt_dev); + int retval; + + mutex_lock(&streamlabs_wdt->lock); + retval = usb_streamlabs_wdt_stop_cmd(streamlabs_wdt); + mutex_unlock(&streamlabs_wdt->lock); + + return retval; +} + +static const struct watchdog_info streamlabs_wdt_ident = { + .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, + .identity = DRIVER_NAME, +}; + +static const struct watchdog_ops usb_streamlabs_wdt_ops = { + .owner = THIS_MODULE, + .start = usb_streamlabs_wdt_start, + .stop = usb_streamlabs_wdt_stop, +}; + +static int usb_streamlabs_wdt_probe(struct usb_interface *intf, + const struct usb_device_id *id) +{ + struct usb_device *usbdev = interface_to_usbdev(intf); + struct streamlabs_wdt *streamlabs_wdt; + int retval; + + /* + * USB IDs of this device appear to be weird/unregistered. Hence, do + * an additional check on product and manufacturer. + * If there is similar device in the field with same values then + * there is stop command in probe() below that checks if the device + * behaves as a watchdog. + */ + if (!usbdev->product || !usbdev->manufacturer + || strncmp(usbdev->product, "USBkit", 6) + || strncmp(usbdev->manufacturer, "STREAM LABS", 11)) + return -ENODEV; + + streamlabs_wdt = devm_kzalloc(&intf->dev, sizeof(struct streamlabs_wdt), + GFP_KERNEL); + if (!streamlabs_wdt) + return -ENOMEM; + + streamlabs_wdt->buffer = devm_kzalloc(&intf->dev, BUFFER_LENGTH, + GFP_KERNEL); + if (!streamlabs_wdt->buffer) + return -ENOMEM; + + mutex_init(&streamlabs_wdt->lock); + + streamlabs_wdt->wdt_dev.info = &streamlabs_wdt_ident; + streamlabs_wdt->wdt_dev.ops = &usb_streamlabs_wdt_ops; + streamlabs_wdt->wdt_dev.timeout = STREAMLABS_WDT_MAX_TIMEOUT; + streamlabs_wdt->wdt_dev.max_timeout = STREAMLABS_WDT_MAX_TIMEOUT; + streamlabs_wdt->wdt_dev.min_timeout = STREAMLABS_WDT_MIN_TIMEOUT; + streamlabs_wdt->wdt_dev.parent = &intf->dev; + + streamlabs_wdt->intf = intf; + usb_set_intfdata(intf, &streamlabs_wdt->wdt_dev); + watchdog_set_drvdata(&streamlabs_wdt->wdt_dev, streamlabs_wdt); + watchdog_set_nowayout(&streamlabs_wdt->wdt_dev, nowayout); + + retval = usb_streamlabs_wdt_stop(&streamlabs_wdt->wdt_dev); + if (retval) + return -ENODEV; + + retval = devm_watchdog_register_device(&intf->dev, + &streamlabs_wdt->wdt_dev); + if (retval) { + dev_err(&intf->dev, "failed to register watchdog device\n"); + return retval; + } + + dev_info(&intf->dev, "StreamLabs USB watchdog driver loaded.\n"); + return 0; +} + +static int usb_streamlabs_wdt_suspend(struct usb_interface *intf, + pm_message_t message) +{ + struct streamlabs_wdt *streamlabs_wdt = usb_get_intfdata(intf); + + if (watchdog_active(&streamlabs_wdt->wdt_dev)) + return usb_streamlabs_wdt_stop(&streamlabs_wdt->wdt_dev); + + return 0; +} + +static int usb_streamlabs_wdt_resume(struct usb_interface *intf) +{ + struct streamlabs_wdt *streamlabs_wdt = usb_get_intfdata(intf); + + if (watchdog_active(&streamlabs_wdt->wdt_dev)) + return usb_streamlabs_wdt_start(&streamlabs_wdt->wdt_dev); + + return 0; +} + +static void usb_streamlabs_wdt_disconnect(struct usb_interface *intf) +{ + struct streamlabs_wdt *streamlabs_wdt = usb_get_intfdata(intf); + + mutex_lock(&streamlabs_wdt->lock); + usb_streamlabs_wdt_stop_cmd(streamlabs_wdt); + /* Stop sending messages to the device */ + streamlabs_wdt->intf = NULL; + mutex_unlock(&streamlabs_wdt->lock); +} + +static const struct usb_device_id usb_streamlabs_wdt_device_table[] = { + { USB_DEVICE(USB_STREAMLABS_WATCHDOG_VENDOR, USB_STREAMLABS_WATCHDOG_PRODUCT) }, + { } /* Terminating entry */ +}; + +MODULE_DEVICE_TABLE(usb, usb_streamlabs_wdt_device_table); + +static struct usb_driver usb_streamlabs_wdt_driver = { + .name = DRIVER_NAME, + .probe = usb_streamlabs_wdt_probe, + .disconnect = usb_streamlabs_wdt_disconnect, + .suspend = usb_streamlabs_wdt_suspend, + .resume = usb_streamlabs_wdt_resume, + .reset_resume = usb_streamlabs_wdt_resume, + .id_table = usb_streamlabs_wdt_device_table, +}; + +module_usb_driver(usb_streamlabs_wdt_driver);