From patchwork Fri Mar 3 21:36:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 658747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF1DC7EE32 for ; Fri, 3 Mar 2023 21:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbjCCVhk (ORCPT ); Fri, 3 Mar 2023 16:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbjCCVhi (ORCPT ); Fri, 3 Mar 2023 16:37:38 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F9662D8A for ; Fri, 3 Mar 2023 13:37:36 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYD5r-00006u-1s; Fri, 03 Mar 2023 22:37:35 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYD5q-001eAq-CO; Fri, 03 Mar 2023 22:37:34 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYD5o-001wxZ-Om; Fri, 03 Mar 2023 22:37:32 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Wim Van Sebroeck , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 08/34] watchdog: bcm47xx: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 22:36:50 +0100 Message-Id: <20230303213716.2123717-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303213716.2123717-1-u.kleine-koenig@pengutronix.de> References: <20230303213716.2123717-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1619; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=avG4o+348YUkK0zg7PzY2tPH9b+vC7iws+Yi2l2JfNE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAmgrl1An784na5A8uj9qAXph0YvU5APg/BILa PHpEL01xniJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJoKwAKCRDB/BR4rcrs CY3TB/9llxKkGv+EWOeCNKVhgoyHXIJxNHw9qLfIsJcV3dDy209ROJxNUMFw9DlRSfeTUNoe5sP 1HxlEldqnqytUc/WJMMr7I2lzynL3Xc+4bGiRa+6Od6XsETdbyVMyRJmQAqPYvHHQ2c55nepwlI qyN8D+9ngh9C9+guLKHYdRU1b+EyeB69uTRBmvvbiQWLgO3TM9Su6wW2S+015ulWf5VZMNtGhMU Ltd1PR3iKmuc19odclHdcjCMFStyJ0t5ICSSPq2lzGIOKkfmbNySrSR5f/2zBbDilmcaI80Ovla kewdVz+jYIL7FPrfhSi6qg9hlFpyM1lpVsuKenKOnDmQ783q X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-watchdog@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/watchdog/bcm47xx_wdt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/bcm47xx_wdt.c b/drivers/watchdog/bcm47xx_wdt.c index 05425c1dfd4c..841ca1839f7f 100644 --- a/drivers/watchdog/bcm47xx_wdt.c +++ b/drivers/watchdog/bcm47xx_wdt.c @@ -218,13 +218,11 @@ static int bcm47xx_wdt_probe(struct platform_device *pdev) return ret; } -static int bcm47xx_wdt_remove(struct platform_device *pdev) +static void bcm47xx_wdt_remove(struct platform_device *pdev) { struct bcm47xx_wdt *wdt = dev_get_platdata(&pdev->dev); watchdog_unregister_device(&wdt->wdd); - - return 0; } static struct platform_driver bcm47xx_wdt_driver = { @@ -232,7 +230,7 @@ static struct platform_driver bcm47xx_wdt_driver = { .name = "bcm47xx-wdt", }, .probe = bcm47xx_wdt_probe, - .remove = bcm47xx_wdt_remove, + .remove_new = bcm47xx_wdt_remove, }; module_platform_driver(bcm47xx_wdt_driver);