From patchwork Mon Oct 7 21:24:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 833526 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDEF1DE3D4; Mon, 7 Oct 2024 21:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728336295; cv=fail; b=F/x0+HtFwvbWBbIUfeRfMAcG7+3Zu+J3HcnrvluYEz09bt5FUas5Vo/rFsCFihVrB+IYa5ZUsVHrHsh6+RU6yt7jhMqI72iJarIl51mhTRL7lo/QV93vXi2WvquBW50MtgvhrBjC7Vvw4XrAvjF9nAWGb4Ht0jpVwFUIT3Gp3N0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728336295; c=relaxed/simple; bh=JlRnnnVLdMiP3eKg3ymz9zpkVVRCaIVAvhldkFKLgZA=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=GJwE35aI7WtGiGcSTS2DRUyd8KAwJMM/2Qgb4SLlpzoxEeRO2J4zY39PzLoxP3sBAChDHK/HTUt+Dw/K0AvcnSVrcFJflBOgeNUL/X3BIvJ1Br8rUqr87FUFwvpeWkN30WHUFSfxoInw0FWGxwSkA9DbDMMPlyCVRqKlPZVe3Yo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=aQJ0lqDs; arc=fail smtp.client-ip=40.107.22.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="aQJ0lqDs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hT9s8scqDTC+IisuPKrZji0zQQaOajTVhpjBLG4Vtai0WhYxoGzcPzhpdxqFsnr8OlJmlDkfV007muAGBY7MmlPtv265pGkQe2AwCP04QJig4px9edBMs/ore/jaxg+ourmgztr2r2BS1C7ArBFAgXFD6gOwcEMMct+oKvfnBjtld2J0oVCT6oBX1nzvCS4fc/EAcZ+oQG1BIB8V6ylvK6i5HWrS3dh2WNwjIwhPIv3CV0fvBt6E4n3kWgWcjh43Ydue0UTBfLkzvpMeOsfndNIWxe9tqnDzT6UZqdh8p7gpFrZHlVUiHCJrh6yq4NJjyUcJJVhEsGqfZcdzRMc2xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vda5Pqpj/fgvR932jI+3YgmY6sAzls2no5+SZM/wP/s=; b=f6w5Pc3WOlw68YN1Ra/e0y0vMr2TxitflAcm2GN1W/dlpCZ0rhPHfnUIle76CWYOvdF1QyRpYC3nKfT+N4b+zwBwUjNQLHHk7o7X0Bhj4AuvNT6vjLmC96DOWdwZKPLjir+zEOokyAw0AuUwnT26KwW5Uqg9O94cKTJ7aW+pPk4woQVaj4lOTL1ITIq2Ppp3iq1hxNEDa2wI+07zuKMbdv/+65vhfA1oVwsa5lmlsOKeheel4DDaDgh07piapMa6y78uQp7OmGmVJxHkqZi10JUDUJLFN4PfZgjmxkGOD3uLGEOvjhxW4nTILAFNvD8wt4yRP/lj2ajimvFhU++0Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vda5Pqpj/fgvR932jI+3YgmY6sAzls2no5+SZM/wP/s=; b=aQJ0lqDs/ZC5zv3Ny+hIXZKfIrLcnIdhTog44ctv0s8oMNJU4Xmcu17W0MIboVzoMKMARd/PL+Y1CHDiN2FOx37CIyp/X4shRrkk7TKODjBCnwWzjxrSmv/V4NTPOx7KN53dYhmOqHldhu5eV02Xg1AvNNnbJxbY7ZCXbPxyahDBV/2EifgNx7ALDvDgzR1Gy4h/eOR98JHWhDvuy0s3cTgM2GI4afYAXEpqRwY8HuWcItQK8MUH+w6uVH/cklHkQuQjeEN1bXcQISYOVPFIqh659EZTQnvYtpYGqtWj8MRTvJpVYttefqj1AA37etD7s8Oj3K1EaeVrZbFHCZK+RA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by VI1PR04MB6976.eurprd04.prod.outlook.com (2603:10a6:803:130::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 21:24:50 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8026.019; Mon, 7 Oct 2024 21:24:50 +0000 From: Frank Li To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Cc: imx@lists.linux.dev Subject: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Date: Mon, 7 Oct 2024 17:24:33 -0400 Message-Id: <20241007212434.895521-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: BY5PR17CA0015.namprd17.prod.outlook.com (2603:10b6:a03:1b8::28) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|VI1PR04MB6976:EE_ X-MS-Office365-Filtering-Correlation-Id: 983c7a48-00f7-4051-efe8-08dce71679f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|7416014|38350700014|921020; X-Microsoft-Antispam-Message-Info: exzWDdzlFickdKR0YOD+XxilprggGjR+FBUf8hRL6g1HEu+FKawGr0OzZ0nbx2jQSHv3nQYzCrImgMUUoTjxTD12C8HmMAIiwz+J5uUxD21WLbILR9tzKQHQ1p/5nnz4O0euxg+i9Kj08JAhgcR3fVWe+8bAOYobiGcyRZjH16Lll7gNoCYd3ZsWhQ9i0lJz3fAgnFbyzVIb2SmQTV0tnVHQlUV6IMNKn0kjmyTWv86gLwAsGSxIIEqedP8iM43PRdQ/bYosms4pn78OhnwlMv44Jo12yr/fMDYFtX7Qbsc6ImIx6o84/siyYrAC5OHYi3v4upd7XsukVYxRXH/u56ftTPPDaoMpe8OKgyGfxS+EgsC0keOCDoGsXQYnrzhdl54tW1trn+Zi+R287kLamvrBvIpA/fcMCjCItiFEHJ3pA3FG79VydoylXvFpHmJzeGguEjIBRrbeZlacCLyg1U/sfY2OM/nMO/PbKUiGLhAzJcHD/iuP30m+i1jTux7Si+2yXsEiRzoHdw7/gb9lzV8M0sKFAHVlWE6Y6ypjcxFuZd40sGSKhngm8YxPw2Y3KZFI56NuUVqTlv2MhN5rUJC9L6p8s4ovR1RQ8gPopNLJfv+G33OwnKRpvx6xNkCIk50M1zx1818WMyHISO+eb0668/QzvewLcZOdKYn6uJ5U8MvCfX86NfTKwQWnoOuAlQ3UL8GmKZQAtPuN/Fe1yk6BvvB9tquKmvalptTJc4pjS7Yi0xVYZTiCtIt15IssL3o+pci8+m7MdFCJVdJD7W4FgruRaK2Tma+ILhdKVW0EXhl6Ia71kL23QlSHB0vSiuzWz4SV1/8jCeSZye7Bfrzz2jdTAqRV3CuNqqo8Tq9SMhBAaqQ2umVp3WCa/ASiyh4hnUzSI7udj09AI6X93H2mLSNlGkNPoOjnr6Dn6BxEinJbBMLgt53p2UHu6NDY7oHyHFdGfoRQqAIBhiYPLET7NYEfZYQWde/y8sjGlcEgSFJ4xO7SDKk9VYb0JAkUjZlnoVoDBDQWetGGgli51yt8rYqvJAgppVWWfldKcmtAdp/DRk+wixA43eSVgQsGr/tK9guxh4hlyRekUj0eZNUNX0HFhIgRCUGVwlmzu7kV1fefVIKG9096dwQvy7oLa2aWJ1Cp1NXR+gU41De94Un4LKEgVw2yGudiClMk57nyRZOsUXj5PDsznqpzSIeualtsxeLuwRPJXzsMyf01P22HCajLu4XWJEL3ci8KBKgH7igtdwlnbzi25GsSTwMtgcexlA52bAW3Jl66wSMvZ7PeEu0j4xBTIWX9uJieaBLA3oD1wNrcqM0O4pHZdqB5bdXzOofZjiTJ0zuGWDToJbzFkmv7G4CRU0SP9zTX4Qw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9642.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(7416014)(38350700014)(921020); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xdg5pF8o3w4G/aYHBc12913hW4NJtaIkPqJQ6hDsN2aIr7QrPQqeb1xCWZuPD38GEWyM4m09xdYo/ntjwF1STMrsjVFHq2lGHm1alJnyesvD3xzgw+DqpGNihyRVxoRGycpwdsZtvl1KXlautnFWGyU2N6JyZBJIDxu5f6e7s8Ai7yu/4u+wOakb2WdTYxUJbVktQQfzBI3ehiWZg82Dd42OVuIb/a+0kWCjxMv96uZqp6MHVghER4eDVibcOms/C1HnT+whWE39VO2H+SNTaw1OtdqTFONJQpVg8tWy6KgPW1KXBR/XrnhlEilWjWkf3aKACbnKdoE0OEYkvcPrjzxt3CSdt98poLeLPokjKLjMCatsDWtG5TfHwlelRmZV1DhTx+bWaYTuBKAjquYbto7xQDkhMb4i9soIvayFoOha/SfLVPC/68aXAW0MIs2bKw42ODtB+Xm6Lh8rMuuJv3DhTEkQYqJgSoKxKaxGZmsGtShWtlEU7gNUT3TzM3fzTHPSfB8agBLg5oV99JhNHE+kCGVk2rQzttQTXu/eo9UpQS47rN/yL1essBl/zarsT97BQ4Xk2Hg7JkyyLLEfwa+vBC/tYYoh7j2Hr3JpV1SosBmiDKvwgI8z0x402rFSrwM2f85Y9CjEPkpCpYn7CloD9RXAa3QKputDAwl+dZxZXXJCLenkRt0Vk3gfeQGZMEPHoWlsqsSthU4YEpEo4OngwEA6/l8rY3m2jkMIH7JghcbNjq5d7SWxZrt9LRcflKhTzAOGhPHaiUTM8Kb5TKLjL8eY88rW1pld3gokBeAmXZb+JqF+rMWMv1rs/Q4jg5nOXt1wwleoRv9uZB5pv5khS87KQ1U4LJhU6VHBAA+qUmQ/ZZ9Apl/nNQxKEbRehJ2sTh0aAIJCGNcu7Gb81P1X/BeFHlq8PzdHLav4R6zyeoAznFzOUd30PKIWB6dCCVhkZmk6HUEad4zkilWAqJM6p4npxnFbQZC6l3MmtKnDMJOvdhYrNkMz8PH4x3+NiayWvcfy7uoTAWKb+bKbdsgkLiAInbUrOsppCXwqJB0uzcNWt1xIJ+TXXcEH1OmyfMu/LRrnaxE38pSM3lWacqNoq6qlo3oPFJ2pc6kB/kpf8Nx4VdE8CMKE7Ih03U/Skby+I9MS+C/MVzxmE0lbMRBx4fD4cu/Q4gYHBDzVDrON7AoSRwVy5rMGs9vnSwmZ7zNWdy3NzgskDCNaOipzAtcTpalCgWncEJdypZZdrtSCsfEnVGLP+xKmKA/2pEeV/pBGaPiRc4FZjm/02vnuQ2Zjrbvn/F8K47RnVSKpm0p+SUZgn8HOndwgjXDT9jI9IFZ2tsMzogrfwy9YwOqRb8pALYTfvZEDWpliPxrqsudfEzrwzRuTIwaD/sM3Vi+J4hlEaBgDNpBNx9NONruaZ0nePfWdNdsZK5RC55ogUGb7blfsO1FBvuszv7X3hiOkOwaLc5vNNj0EcyM7vYXGTujtGzMAoYGXDxj/Iee1GMtb1ffmhzTavfLkSjM3+XHVmY7BDlgRQ0wIRHJMr1PAEP3eLcMBC2e/tMS2nh1bvPKEhFk+9KPgZJ08E1FvlhWY X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 983c7a48-00f7-4051-efe8-08dce71679f0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2024 21:24:50.2423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZmwzZtHnnR4ab0NzKf/EwogXBI/yIlJa7uFqfCsQKjDi6tUepXnGZLgq18BBH2t6GGlcWiMc5W6Z6spPecBaMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6976 From: Animesh Agarwal Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only allow big-endian property for ls1012a and ls1043a. Fix dtbs_check errors. arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000: Unevaluated properties are not allowed ('big-endian' was unexpected) Cc: Daniel Baluta Signed-off-by: Animesh Agarwal Signed-off-by: Frank Li Reviewed-by: Krzysztof Kozlowski Acked-by: Wim Van Sebroeck --- Change from v1 to v2: only allow big endian for layerscape platform. previous post at: https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/ check spec, and dump watch dog reset value at ls1043a platform. 0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0 It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian() to handle endian. So this change is corret. big-endian for wdt is necessary --- .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml index 36b836d0620c9..0da953cb71272 100644 --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml @@ -48,6 +48,8 @@ properties: clocks: maxItems: 1 + big-endian: true + fsl,ext-reset-output: $ref: /schemas/types.yaml#/definitions/flag description: | @@ -93,6 +95,18 @@ allOf: properties: fsl,suspend-in-wait: false + - if: + not: + properties: + compatible: + contains: + enum: + - fsl,ls1012a-wdt + - fsl,ls1043a-wdt + then: + properties: + big-endian: false + unevaluatedProperties: false examples: