From patchwork Tue May 6 10:23:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yen-Chi Huang X-Patchwork-Id: 888516 Received: from HK3PR03CU002.outbound.protection.outlook.com (mail-eastasiaazon11021129.outbound.protection.outlook.com [52.101.129.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D347027605F; Tue, 6 May 2025 10:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.129.129 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746527006; cv=fail; b=KqRfKCRQBXqk/SSvvoasmKFmlPRNVFWu6UTytBuHpGsXoROTvGJGv9L/mNzoy5Qmn0A31CK23hlbhOzanYqled59M7MUULn+qu9WVVKRbkEitcr8VhsF5R7s4bjUc0ntvQQm73xv1+wdSfgGYKuWyKvS4Y8GnBH61pr5BZ+5ZVQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746527006; c=relaxed/simple; bh=bRPhMM2/HiTW+cxle+B8AsDbUwvCUm1Oafcvd66pQ+U=; h=Message-ID:Date:From:Subject:To:Cc:Content-Type:MIME-Version; b=I1YxAuM8/1LoO1YTJ0ecKHcm8YlIckzniU/W6SWav9V7I+unxNtQww453XWDjebxjWFGbnAshkNqVnshQuZpfWbpXFFvvqHu1QZMsDOV7BqZrJTMG7Jq3GNUjNZugVfvWscP378tpR8AwKnHvuptvz4LdxaElecA9REPjuF/xdA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=portwell.com.tw; spf=pass smtp.mailfrom=portwell.com.tw; dkim=pass (2048-bit key) header.d=fetCA905017.onmicrosoft.com header.i=@fetCA905017.onmicrosoft.com header.b=U+J6jc+a; arc=fail smtp.client-ip=52.101.129.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=portwell.com.tw Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=portwell.com.tw Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fetCA905017.onmicrosoft.com header.i=@fetCA905017.onmicrosoft.com header.b="U+J6jc+a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V6bxyt9TjgkqV9k95gnhHV3bw1S49UIFDJNJFxF/U1FYQK/1gOO2E8m9/Ca4Lo0Ny69lVkTRNmft2it1q2041aj2A9f1B3smC4dWS+qVFwCCvSQ+jUezokn5DkwI3vhVZbsoYlLf3202Uyg1tQdqdrT23aajvdNDW2lxOe5b6+dZmBkQA+LiUb0Ns6G6oqFRhZ5CIR/b06fq9Y63MKL5GZPal9lAL5Mg2wkbiYZSeCKhv3IccWTV0C/Y/sJ4kGbOrk/FpT2598K4FziQ+TtLF/BiJPtI/gOuy8458Fppt1fnPI6gygzOWB2Lp5JMW3m+XwiOM0b7hQCDF+iKFIk7RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2qFcmUhLohpfr/jkxQN3Q8fux1SRpxxVvpBZK7T85Cg=; b=jhORY52XEL38g2ICzDe6bO8p3AMJl6eeOH6JZ15m4vSP/vk8vYts6eBqaECAXxjwLEhle4BtdqBPfkQlUGc7Isu4z+q3gNP+60VUufVr7CmaAYJ34nCrcr3MoBpS1gSv1HEEqRYtDjO1yiBmDZkdRAPxsfwS04BUqZtq9OsB3RNFP+jUaS9jepwAs1GScl6mswSuSmfUzJZK79aB8yd13bViMyN87yXWglHTuD2jKtLIwcphXxQUbiTOHlovqwvcjsAghzidptZiDNSoa2wu33qs7ITFaCr0O3DXzuySvX3G0wn2bfnL5uiKZ7o++0UUv36alV4ZEhxE+oywygrrFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=portwell.com.tw; dmarc=pass action=none header.from=portwell.com.tw; dkim=pass header.d=portwell.com.tw; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fetCA905017.onmicrosoft.com; s=selector1-fetCA905017-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qFcmUhLohpfr/jkxQN3Q8fux1SRpxxVvpBZK7T85Cg=; b=U+J6jc+a3g5+LMG+7K8CB3JORemyxw+mH9tYq69O+K/ivnhYSg+qO6aDxsAQyEXZKWXbJQ3QhnOnDrSgJ6esNvKXHHZ97K31jSFrhrP5OmAUNeZKb4irAEUyS49VWIUC/0K1g3skJxcJN0KCIbiHwhWX4Gpq90n9uHerjEGzoXfIbXtfhGldk8T98jKW0286jDkhCFROxUgktmN6gafjpv9pi7YG06tOzrGdGOxf9vYB1bwu7n9ohOF3hWXtWt4KF6PP1eYsuJQffZZf0jAvsVTInBkqDJfEUNkHPZrB9VdUT3Fj6F/JbhoOJv0ei8SNxQRAoS5quVlbS8lZUglO6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=portwell.com.tw; Received: from KL1PR06MB6395.apcprd06.prod.outlook.com (2603:1096:820:e7::10) by PS1PPF80815FF87.apcprd06.prod.outlook.com (2603:1096:308::259) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.22; Tue, 6 May 2025 10:23:17 +0000 Received: from KL1PR06MB6395.apcprd06.prod.outlook.com ([fe80::9235:5570:71b3:224]) by KL1PR06MB6395.apcprd06.prod.outlook.com ([fe80::9235:5570:71b3:224%5]) with mapi id 15.20.8699.022; Tue, 6 May 2025 10:23:17 +0000 Message-ID: Date: Tue, 6 May 2025 18:23:14 +0800 User-Agent: Mozilla Thunderbird From: Yen-Chi Huang Subject: [PATCH v6] platform/x86: portwell-ec: Add GPIO and WDT driver for Portwell EC To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, linus.walleij@linaro.org, brgl@bgdev.pl, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, jay.chen@canonical.com, jesse.huang@portwell.com.tw Content-Language: en-US X-ClientProxiedBy: TPYP295CA0039.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::10) To KL1PR06MB6395.apcprd06.prod.outlook.com (2603:1096:820:e7::10) Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: KL1PR06MB6395:EE_|PS1PPF80815FF87:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f30191-4715-4ff0-320e-08dd8c88043b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?P6mfSxcIdACTEp+HK12LTVzEf1nsf7C?= =?utf-8?q?TvNG/ohnBDyqgjJYIidaJzYEZGZXkUGQKJSwGtsDejsP5KfcZIiDjvdY+ykPuwE0B?= =?utf-8?q?XbuVYO9SrNOcn0Y2sNEhOJQkJRYcKjH3tB4ClpuzCL3rqaWNGwDFAhsaIFTeyOWhY?= =?utf-8?q?ScQT0xtcrf2Tkp/BLnva9rRrJZ+ffnS4HKH74Rg2RUdhn+B4OAVdtGjnd8+wy7Ica?= =?utf-8?q?gcO1H1x+F6NwV0l8fjRsk+WcpHMqcZBMMpGqUHqam28Wgp2Qx7vYQU87zlrRjNgeX?= =?utf-8?q?l3dJrbZJzCxNAQ4d8jza8AMZ7RXi4I5vrIBxQ8JiKSk0/itU9aPrdD6+OD04FXwxp?= =?utf-8?q?OeDNY7pjRDtvO5lBuY797dFRVKBI7L5FmtvQli18O5lpfPBETJPogLJpcb3LM4RuU?= =?utf-8?q?dPNphu4QhYpi4TkG91J4daOOvJQKYEBmeH8aeNg4CxmJyrsmBJKczSeDaF8yB8AwS?= =?utf-8?q?qNrT32r+tOSIdfOr8Z0iYpK/Dd55tHJiaiX110ekCjfMMswjydhOE8iER2okh8HIh?= =?utf-8?q?kfVjAaGtDauuQdOd8pZUaWclwPCYhHfItXe9IVq94XmBJIsEuzSkCRj+ImGWkyL+P?= =?utf-8?q?ZSP5H1U1H65LuBlx4aGtPCk3RQtKakG2iHPu2hsXKjJqWnI70FDIgK3hFawoh5TRG?= =?utf-8?q?afYtFiahUhvdg6H3OgSZimVA2hOLs+HrrLlFFGITTY74DVMybSBRTNp8x+VZsyrWf?= =?utf-8?q?X96TEt0THdPQBrGgXWMcE+baFhU9UHhVDCahSJ6PTzfeYCwoYn/C9L+OrQxSA4oZH?= =?utf-8?q?gAxTSc/3NG3ja/QGVAQmRb1TyT0RmPfE24XaIbz96yfo5DNVV8ws+vLFEF+EWJ02c?= =?utf-8?q?42eoLBs7ZpLlm4GEV7J5dCUBvgtzX2lLgjkfU5tg3VEANRKiO8aj8FznFzabIji9c?= =?utf-8?q?w8CHLtbHWRwcPpUSO3+ugM+Hyde9dT5g1uVGrWl9R0VDdecPmPSOLBcCh8OUqkR9N?= =?utf-8?q?zvjXOQItj07wsV+oKyAbg2zEnkeBXVeFxYvMqkMsd8pcAV4NNJ9DegUkL0U0DqGu+?= =?utf-8?q?763SLb3wFfeiz2aJB/vidG2+v4mxLS5TaPZ/HdisKuKlYx/COwqiBLlhGS4pLiQyt?= =?utf-8?q?n413+dtC9I8hQbIzRmVEG6np221vxDXnk8Q8LOPANDVxBtvbk62sMWuExZSb0GKOH?= =?utf-8?q?uGKfRvapAPELz35ZxvnnNbZATJkGxoPB3N0hkXbKi0FdwlJkn6ERP93uHmfurSRg0?= =?utf-8?q?Qs9kNGH1kZyMc/WMgmoIsUnxpGgpivp2Zs/OInYhCh33QqPE6+6fxBVKHhg/byUV5?= =?utf-8?q?eWtD60mxOSue+BkvOtywoPC3+OwJH9zSPh1WJkdVqfgDgyTbG37SsVgyQ3msxLx3U?= =?utf-8?q?bjJzqOLiveI/+PNICyowSWXA2c9q29qnD+wW9PHvnTAIXXJ0k580VOk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:KL1PR06MB6395.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(7416014)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?aoqzWR+11xURgIbubEZ3tvtqqZaf?= =?utf-8?q?ucVvhrdk4O9fXe4pQRwp83zGlvDmH16wuDnkb/qzvoqXoQQv8B8K7xVmHFpQBg1YD?= =?utf-8?q?0iKs/kwfm4Mc/EYy8d6LnvGAZXRh+HU44qZ8XnZAZag4djasYj60kyUUm4vQP9hFT?= =?utf-8?q?iylwmpuDBHLbhyKcRuxNfvI/j9zFpX31wb5o952RTGPfzPqL1Kso750ptWXDcAiYe?= =?utf-8?q?rTyJlJ7Gj5GtKqkGHkL2zZz9sjJ/BNGbHaOYK1QUork93ABXaaj59y2Etxml2USC0?= =?utf-8?q?c66OFuHkHlFCPoja+krKr3yl2qlJB2MM/TmrgnY98TCwMBd9PZn8T5Fx8+ubDBHdc?= =?utf-8?q?JnSK7en63bHaDCYwyesH2+xOVudOEBXEUQ15paCGg76zBc+Dzy9G7hpkB95i8CRXu?= =?utf-8?q?W8y5OSrrRjuc7NtoE7bGFUiJ54wBJjimLg41RMU6PSUEILRkktTK6uStuGvqoJqni?= =?utf-8?q?BMiACQeGPOylP6nKISKAE/z4zTVONXsqwWySgdjHslc6GqjjsentZn+fJI2G/WH7v?= =?utf-8?q?urCDEJ/RE2TpeKcvARe+zLq/JLPM1UQEa5me20Vz7bFMj1uAq6vz9foJMkfc2Ifir?= =?utf-8?q?eBTfa/8QGsTBRiyh93vTOQnbPUyAxUCgKT5Yt+gU1Xr5Vwn6znOaI1ec5su35WIx3?= =?utf-8?q?Xca2DUnYg1oJhlYBgqBHBmHkVQiw3klA7iLcDcqDF/bj8fjPdCGA9zvd4TdJ/uO4E?= =?utf-8?q?5Iyb3UsEncyKtyDd0XR3/2+uGNYhwe3xMc92/OqbeEWVeVLrzdvvxROp0r8Hb+MUA?= =?utf-8?q?YT6WjMNQvzr25CtQT1LD+Gvq1uJugAP3Z6iJ4VT0dadYVa7nXO1Qb3YtVbivxgwLW?= =?utf-8?q?mc2m6AAZBzuMwyaRsNFjAuSY95KhhqjZsfTV09omht3yMyfwBEoscawvQF0lfsaap?= =?utf-8?q?F7rKEava3XUF4xHTZTit44I/KzBivqXx8NiVFl19JJyJgP5siKySu6WjsaZXby0Y9?= =?utf-8?q?FYmt8AgddXlbBNsRCTWodv7Ww3XjKB6kXwdgLciTz3j5iSesQYt6VuEKEJ+/uib+Q?= =?utf-8?q?W0a1LUO7eqcmnk2mXRTxMVT0F3RH52YA2xFtLd5er3pKgykE71sbn7UOzX5byCeHt?= =?utf-8?q?LpEe1bUngiX4uEFija7eF9xqBOCW0Nij85DCIrEj+dgd6MtGiyzTrVKyJYV3lGA58?= =?utf-8?q?p1UWX4Mn/xHv+nw8PC3F6I7ohal+IC5/Z42P8xTIDIzY5yPxZ84yK1NY5zHu+UOpy?= =?utf-8?q?ZZZlIXnSprjQ1xhdFQrJMoCweJAYMH9Yqqq7YVVpG5PcBhOKGL/a91ZxttELznQmj?= =?utf-8?q?8Qb+9JLmzfhFLjCxSZlkg21elqhs0Jt4KP/QnTY9tSM/zeaWxSwqr6SXK8LHhe68R?= =?utf-8?q?l0iGeOS899fwgAfvsu/guos+2IMN8Ug/tfHWyP3z6JGFOYrbzpToxb0lEVL7AlakQ?= =?utf-8?q?vE7b6HDNTvcIFShCqgA70Ph8VgHk5NZj8IqB4AjzrXm3YYjapKjmlSe9CXfjpeQuX?= =?utf-8?q?thVkI3IAaWuRGJc2cGnHrYRvFdB7VDeBfnNSnHx4iKUcAnNUjdVLLpiYmSoFPcv6T?= =?utf-8?q?RMorLVPLZb/VeKidAqZB2YiWN+kCpan0sw=3D=3D?= X-OriginatorOrg: portwell.com.tw X-MS-Exchange-CrossTenant-Network-Message-Id: 28f30191-4715-4ff0-320e-08dd8c88043b X-MS-Exchange-CrossTenant-AuthSource: KL1PR06MB6395.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 10:23:17.4771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e309f7e-c3ee-443b-8668-97701d998b2c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e/f1BtaF1yEXAv8F3VDpVUN09N9GINMhZbhO+cM0wU6Oa6FLn2pBgApgCgKLQop+3M5iB54B/t58obkpCUOQKXLyFo+bO1HOzW7werAnk7A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF80815FF87 Adds a driver for the ITE Embedded Controller (EC) on Portwell boards. It integrates with the Linux GPIO and watchdog subsystems to provide: - Control/monitoring of up to 8 EC GPIO pins. - Hardware watchdog timer with 1-255 second timeouts. The driver communicates with the EC via I/O port 0xe300 and identifies the hardware by the "PWG" firmware signature. This enables enhanced system management for Portwell embedded/industrial platforms. Signed-off-by: Yen-Chi Huang Reviewed-by: Linus Walleij --- V5 -> V6: - Use BIT(offset) instead of open-coding (1 << offset) - Move portwell-ec entry to correct alphabetical position in MAINTAINERS - Rebase onto latest platform/x86 master V4 -> V5: - Remove unnecessary `else` in pwec_gpio_get_direction() - Remove redundant watchdog timeout range validation - Rewrite pwec_wdt_get_timeleft() for rollover safety - Add missing comma in struct platform_driver and remove dummy parentheses - Fix devm_request_region() error message - Remove redundant pwec_dev null check in pwec_exit() V3->V4: - Added select WATCHDOG_CORE in Kconfig - Removed redundant retry logic from pwec_wdt_trigger() - Added pwec_wdt_write_timeout() helper - Handled second wraparound when reading min/sec in get_timeleft() - Reworked DMI check and force parameter logic - Fixed error handling for GPIO and platform device registration - Fixed typos, log messages, and formatting issues V2->V3: - Reworked based on review from Bartosz Golaszewski - Changed to use platform_driver and platform_device - Updated GPIO to use .set_rv() instead of .set() - Used devm_ helpers for request_region, GPIO and watchdog registration V1->V2: - Addressed review comments from Ilpo Jarvinen - Add DMI system check to avoid running on unsupported platforms - Add 'force' module parameter to override DMI matching - Use request_region() to claim I/O port access - Extend WDT timeout handling to use both minute and second registers - Increase WDT max timeout from 255s to 15300s - Use named defines for WDT enable/disable - Remove dummy pr_info() messages - Fix several coding style issues (comments, alignment, spacing) --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig | 15 ++ drivers/platform/x86/Makefile | 3 + drivers/platform/x86/portwell-ec.c | 291 +++++++++++++++++++++++++++++ 4 files changed, 315 insertions(+) create mode 100644 drivers/platform/x86/portwell-ec.c diff --git a/MAINTAINERS b/MAINTAINERS index 5f8688630c01..5e647296c950 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19287,6 +19287,12 @@ S: Maintained F: drivers/pnp/ F: include/linux/pnp.h +PORTWELL EC DRIVER +M: Yen-Chi Huang +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/portwell-ec.c + POSIX CLOCKS and TIMERS M: Anna-Maria Behnsen M: Frederic Weisbecker diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 43407e76476b..3ceeb70897eb 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -779,6 +779,21 @@ config PCENGINES_APU2 To compile this driver as a module, choose M here: the module will be called pcengines-apuv2. +config PORTWELL_EC + tristate "Portwell Embedded Controller driver" + depends on X86 && HAS_IOPORT && WATCHDOG && GPIOLIB + select WATCHDOG_CORE + help + This driver provides support for the GPIO pins and watchdog timer + embedded in Portwell's EC. + + Theoretically, this driver should work on multiple Portwell platforms, + but it has only been tested on the Portwell NANO-6064 board. + If you encounter any issues on other boards, please report them. + + To compile this driver as a module, choose M here: the module + will be called portwell-ec. + config BARCO_P50_GPIO tristate "Barco P50 GPIO driver for identify LED/button" depends on GPIOLIB diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 650dfbebb6c8..83dd82e04457 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -92,6 +92,9 @@ obj-$(CONFIG_XO1_RFKILL) += xo1-rfkill.o # PC Engines obj-$(CONFIG_PCENGINES_APU2) += pcengines-apuv2.o +# Portwell +obj-$(CONFIG_PORTWELL_EC) += portwell-ec.o + # Barco obj-$(CONFIG_BARCO_P50_GPIO) += barco-p50-gpio.o diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c new file mode 100644 index 000000000000..8b788822237b --- /dev/null +++ b/drivers/platform/x86/portwell-ec.c @@ -0,0 +1,291 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * portwell-ec.c: Portwell embedded controller driver. + * + * Tested on: + * - Portwell NANO-6064 + * + * This driver provides support for GPIO and Watchdog Timer + * functionalities of the Portwell boards with ITE embedded controller (EC). + * The EC is accessed through I/O ports and provides: + * - 8 GPIO pins for control and monitoring + * - Hardware watchdog with 1-15300 second timeout range + * + * It integrates with the Linux GPIO and Watchdog subsystems, allowing + * userspace interaction with EC GPIO pins and watchdog control, + * ensuring system stability and configurability. + * + * (C) Copyright 2025 Portwell, Inc. + * Author: Yen-Chi Huang (jesse.huang@portwell.com.tw) + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define PORTWELL_EC_IOSPACE 0xe300 +#define PORTWELL_EC_IOSPACE_LEN SZ_256 + +#define PORTWELL_GPIO_PINS 8 +#define PORTWELL_GPIO_DIR_REG 0x2b +#define PORTWELL_GPIO_VAL_REG 0x2c + +#define PORTWELL_WDT_EC_CONFIG_ADDR 0x06 +#define PORTWELL_WDT_CONFIG_ENABLE 0x1 +#define PORTWELL_WDT_CONFIG_DISABLE 0x0 +#define PORTWELL_WDT_EC_COUNT_MIN_ADDR 0x07 +#define PORTWELL_WDT_EC_COUNT_SEC_ADDR 0x08 +#define PORTWELL_WDT_EC_MAX_COUNT_SECOND (255 * 60) + +#define PORTWELL_EC_FW_VENDOR_ADDRESS 0x4d +#define PORTWELL_EC_FW_VENDOR_LENGTH 3 +#define PORTWELL_EC_FW_VENDOR_NAME "PWG" + +static bool force; +module_param(force, bool, 0444); +MODULE_PARM_DESC(force, "Force loading EC driver without checking DMI boardname"); + +static const struct dmi_system_id pwec_dmi_table[] = { + { + .ident = "NANO-6064 series", + .matches = { + DMI_MATCH(DMI_BOARD_NAME, "NANO-6064"), + }, + }, + { } +}; +MODULE_DEVICE_TABLE(dmi, pwec_dmi_table); + +/* Functions for access EC via IOSPACE */ + +static void pwec_write(u8 index, u8 data) +{ + outb(data, PORTWELL_EC_IOSPACE + index); +} + +static u8 pwec_read(u8 address) +{ + return inb(PORTWELL_EC_IOSPACE + address); +} + +/* GPIO functions */ + +static int pwec_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + return pwec_read(PORTWELL_GPIO_VAL_REG) & BIT(offset) ? 1 : 0; +} + +static int pwec_gpio_set_rv(struct gpio_chip *chip, unsigned int offset, int val) +{ + u8 tmp = pwec_read(PORTWELL_GPIO_VAL_REG); + + if (val) + tmp |= BIT(offset); + else + tmp &= ~BIT(offset); + pwec_write(PORTWELL_GPIO_VAL_REG, tmp); + + return 0; +} + +static int pwec_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) +{ + u8 direction = pwec_read(PORTWELL_GPIO_DIR_REG) & BIT(offset); + + if (direction) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; +} + +/* + * Changing direction causes issues on some boards, + * so direction_input and direction_output are disabled for now. + */ + +static int pwec_gpio_direction_input(struct gpio_chip *gc, unsigned int offset) +{ + return -EOPNOTSUPP; +} + +static int pwec_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int value) +{ + return -EOPNOTSUPP; +} + +static struct gpio_chip pwec_gpio_chip = { + .label = "portwell-ec-gpio", + .get_direction = pwec_gpio_get_direction, + .direction_input = pwec_gpio_direction_input, + .direction_output = pwec_gpio_direction_output, + .get = pwec_gpio_get, + .set_rv = pwec_gpio_set_rv, + .base = -1, + .ngpio = PORTWELL_GPIO_PINS, +}; + +/* Watchdog functions */ + +static void pwec_wdt_write_timeout(unsigned int timeout) +{ + pwec_write(PORTWELL_WDT_EC_COUNT_MIN_ADDR, timeout / 60); + pwec_write(PORTWELL_WDT_EC_COUNT_SEC_ADDR, timeout % 60); +} + +static int pwec_wdt_trigger(struct watchdog_device *wdd) +{ + pwec_wdt_write_timeout(wdd->timeout); + pwec_write(PORTWELL_WDT_EC_CONFIG_ADDR, PORTWELL_WDT_CONFIG_ENABLE); + + return 0; +} + +static int pwec_wdt_start(struct watchdog_device *wdd) +{ + return pwec_wdt_trigger(wdd); +} + +static int pwec_wdt_stop(struct watchdog_device *wdd) +{ + pwec_write(PORTWELL_WDT_EC_CONFIG_ADDR, PORTWELL_WDT_CONFIG_DISABLE); + return 0; +} + +static int pwec_wdt_set_timeout(struct watchdog_device *wdd, unsigned int timeout) +{ + wdd->timeout = timeout; + pwec_wdt_write_timeout(wdd->timeout); + + return 0; +} + +/* Ensure consistent min/sec read in case of second rollover. */ +static unsigned int pwec_wdt_get_timeleft(struct watchdog_device *wdd) +{ + u8 sec, min, old_min; + + do { + old_min = pwec_read(PORTWELL_WDT_EC_COUNT_MIN_ADDR); + sec = pwec_read(PORTWELL_WDT_EC_COUNT_SEC_ADDR); + min = pwec_read(PORTWELL_WDT_EC_COUNT_MIN_ADDR); + } while (min != old_min); + + return min * 60 + sec; +} + +static const struct watchdog_ops pwec_wdt_ops = { + .owner = THIS_MODULE, + .start = pwec_wdt_start, + .stop = pwec_wdt_stop, + .ping = pwec_wdt_trigger, + .set_timeout = pwec_wdt_set_timeout, + .get_timeleft = pwec_wdt_get_timeleft, +}; + +static struct watchdog_device ec_wdt_dev = { + .info = &(struct watchdog_info){ + .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE, + .identity = "Portwell EC watchdog", + }, + .ops = &pwec_wdt_ops, + .timeout = 60, + .min_timeout = 1, + .max_timeout = PORTWELL_WDT_EC_MAX_COUNT_SECOND, +}; + +static int pwec_firmware_vendor_check(void) +{ + u8 buf[PORTWELL_EC_FW_VENDOR_LENGTH + 1]; + u8 i; + + for (i = 0; i < PORTWELL_EC_FW_VENDOR_LENGTH; i++) + buf[i] = pwec_read(PORTWELL_EC_FW_VENDOR_ADDRESS + i); + buf[PORTWELL_EC_FW_VENDOR_LENGTH] = '\0'; + + return !strcmp(PORTWELL_EC_FW_VENDOR_NAME, buf) ? 0 : -ENODEV; +} + +static int pwec_probe(struct platform_device *pdev) +{ + int ret; + + if (!devm_request_region(&pdev->dev, PORTWELL_EC_IOSPACE, + PORTWELL_EC_IOSPACE_LEN, dev_name(&pdev->dev))) { + dev_err(&pdev->dev, "failed to get IO region\n"); + return -EBUSY; + } + + ret = pwec_firmware_vendor_check(); + if (ret < 0) + return ret; + + ret = devm_gpiochip_add_data(&pdev->dev, &pwec_gpio_chip, NULL); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register Portwell EC GPIO\n"); + return ret; + } + + ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n"); + return ret; + } + + return 0; +} + +static struct platform_driver pwec_driver = { + .driver = { + .name = "portwell-ec", + }, + .probe = pwec_probe, +}; + +static struct platform_device *pwec_dev; + +static int __init pwec_init(void) +{ + int ret; + + if (!dmi_check_system(pwec_dmi_table)) { + if (!force) + return -ENODEV; + pr_warn("force load portwell-ec without DMI check\n"); + } + + ret = platform_driver_register(&pwec_driver); + if (ret) + return ret; + + pwec_dev = platform_device_register_simple("portwell-ec", -1, NULL, 0); + if (IS_ERR(pwec_dev)) { + platform_driver_unregister(&pwec_driver); + return PTR_ERR(pwec_dev); + } + + return 0; +} + +static void __exit pwec_exit(void) +{ + platform_device_unregister(pwec_dev); + platform_driver_unregister(&pwec_driver); +} + +module_init(pwec_init); +module_exit(pwec_exit); + +MODULE_AUTHOR("Yen-Chi Huang "); +MODULE_DESCRIPTION("Portwell EC Driver"); +MODULE_LICENSE("GPL");