mbox series

[v2,0/3] cfg80211: Add MLO Link Device abstraction

Message ID 1645613200-30221-1-git-send-email-quic_vjakkam@quicinc.com
Headers show
Series cfg80211: Add MLO Link Device abstraction | expand

Message

Veerendranath Jakkam Feb. 23, 2022, 10:46 a.m. UTC 
This patch series adds support for MLO link in STA mode. Add new iface
type (NL80211_IFTYPE_MLO_LINK) to represent MLO link in non-AP MLD mode.
Define several attributes to indicate MLO links info associated with
MLD STA interface to userspace. Add support for key operations on wdev
without netdev to allow configuring per link keys(GTK/IGTK/BIGTK).

Sunil Dutt (2):
  cfg80211: Add NL80211_IFTYPE_MLO_LINK type for MLO links on MLD STA
  cfg80211: Indicate MLO links info in connect/roam events

Veerendranath Jakkam (1):
  cfg80211: Add support for key operations on NL80211_IFTYPE_MLO_LINK

Added required changes in "cfg80211: Add support for key operations on
NL80211_IFTYPE_MLO_LINK" patch to fix the compilation issue reported by
"kernel test robot <lkp@intel.com>".

 drivers/net/wireless/ath/ath6kl/cfg80211.c         |  52 ++++-
 drivers/net/wireless/ath/wil6210/cfg80211.c        |  38 ++--
 .../broadcom/brcm80211/brcmfmac/cfg80211.c         |  58 +++--
 drivers/net/wireless/marvell/libertas/cfg.c        |  14 +-
 drivers/net/wireless/marvell/mwifiex/cfg80211.c    |  40 +++-
 drivers/net/wireless/microchip/wilc1000/cfg80211.c |  48 ++++-
 drivers/net/wireless/quantenna/qtnfmac/cfg80211.c  |  40 +++-
 drivers/net/wireless/rndis_wlan.c                  |  24 ++-
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c  |  40 +++-
 drivers/staging/wlan-ng/cfg80211.c                 |  41 +++-
 include/net/cfg80211.h                             |  78 ++++++-
 include/uapi/linux/nl80211.h                       |  50 +++++
 net/mac80211/cfg.c                                 |  59 ++++--
 net/mac80211/chan.c                                |   2 +
 net/mac80211/iface.c                               |   2 +
 net/mac80211/util.c                                |   1 +
 net/wireless/chan.c                                |  21 ++
 net/wireless/core.c                                | 100 ++++++++-
 net/wireless/core.h                                |  16 ++
 net/wireless/ibss.c                                |   2 +-
 net/wireless/nl80211.c                             | 233 +++++++++++++++++----
 net/wireless/rdev-ops.h                            |  36 ++--
 net/wireless/scan.c                                |  25 +++
 net/wireless/sme.c                                 |  81 ++++++-
 net/wireless/trace.h                               |  68 +++---
 net/wireless/util.c                                |  10 +-
 net/wireless/wext-compat.c                         |  10 +-
 27 files changed, 966 insertions(+), 223 deletions(-)

Comments

Arend Van Spriel Feb. 23, 2022, 12:39 p.m. UTC | #1 
On 2/23/2022 11:46 AM, Veerendranath Jakkam wrote:
> In contrast, NL80211_IFTYPE_MLO_LINK can't be used to represent AP MLO
> link since an MLD AP must support pre-11be and 11be clients
> simultaneously so each AP MLO link affiliated with AP MLD must also act
> as independent AP for pre-11be clients so each AP MLO link must be

Not just for pre-11be clients. 11be clients can opt-out right?

> represented by NL80211_IFTYPE_AP associated with a separate netdev.
> 
> Two link AP MLD representation:
> 
>                   AP MLD
>               (netdev + wdev)
>                  /      \
>                 /        \
>            wlan0          wlan1
>        IFTYPE_AP       IFTYPE_AP
>     (netdev + wdev)  (netdev + wdev)
>             |             |
>             |             |
>          radio(2G)      radio(5G)

So the AP MLD is a new IFTYPE? Earlier discussions were suggesting the 
AP MLO links would be bridged, but then there would be only a netdev at 
AP MLD level, right?

Regards,
Arend
Arend Van Spriel Feb. 26, 2022, 7:36 p.m. UTC | #2 
On February 24, 2022 8:59:07 AM Veerendranath Jakkam 
<quic_vjakkam@quicinc.com> wrote:

> On 2/23/2022 6:09 PM, Arend van Spriel wrote:
>> On 2/23/2022 11:46 AM, Veerendranath Jakkam wrote:
>>> In contrast, NL80211_IFTYPE_MLO_LINK can't be used to represent AP MLO
>>> link since an MLD AP must support pre-11be and 11be clients
>>> simultaneously so each AP MLO link affiliated with AP MLD must also act
>>> as independent AP for pre-11be clients so each AP MLO link must be
>>
>> Not just for pre-11be clients. 11be clients can opt-out right?
>
> I think as of now spec is mandating to use multi-link capabilities in
> 11BE association. Anyways, current design is allows single link 11be
> connections also in case if it is going to be allowed by spec in future.

Reading clause 35.3.5 Multi-link (re)setup (D1.4) I would say it is 
allowed. If the non-AP MLD doesn't include Basic multi-link element in the 
(re)assoc request it is a single link request. In this case the non-AP MLD 
is effectively a 11be STA. Maybe missing a clause describing the AP MLD 
behavior in this scenario.

Regards,
Arend