From patchwork Fri May 15 08:33:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215606 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C694C433DF for ; Fri, 15 May 2020 08:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D60A720657 for ; Fri, 15 May 2020 08:33:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="nrh0u21k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727811AbgEOIdx (ORCPT ); Fri, 15 May 2020 04:33:53 -0400 Received: from mail-dm6nam11on2086.outbound.protection.outlook.com ([40.107.223.86]:6138 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726694AbgEOIdw (ORCPT ); Fri, 15 May 2020 04:33:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GdIOnV5VNtUB1bQ1AT1aeNVIkXMLpDzVY5oun90WeimDGHhbXvjvDOBZpFF7xDUS7NJdRVMfSpEwHVnM9EsWG/8D9kRY79rWTncZ9JhYxcJJLcPszVdBHqiAjKqgGPZJAIgWgHsVIWWCUz/VKwUSY2rXfuYjXIdL8NTpDxK1MaEmIi8bE6h3/bhF7kTiMa8pvQ7TEzmR75dIJdFUOZDes1D6x6H/EmK64NTGDhqeNFMBuS4r8pm4H3DS9y50wJ38o4kT9UmpXBr+qiMmNC69/CELb7wT8THHBPNIHCmA5s4ylRkK0OAugh4mieLI1HZOdSbCV5m+NXD/2wx+nDgDNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owEGYhDSPe8g3K0oc3QVvoWe3aGkmULc3RgqcpbwuGY=; b=IXZb7RyvJSkNawg7aiw33XZ0GWpjPo1S3LOIYXG4G6sAvDWzA5pcIaWuRJlXZviTQKKHXs8pyGg1dGz1Kqo/8cdWt5AvjxkhJipONtAO+yj1eWLYNw7T5H+bHf9QSIQmLikBsAg/H7Mq5AHjIIEYJLQ9oORJtyghLaN7CZ1im9JNSDF5qhsYMAo89jJNbH4kSeX/Dw0Xac5yO4XKn3BaWnxXR8aVrK+Wbt25eeAWjrboIPPjanboL+VWorJM6PXm+cJ47fjW+XdYpNCzm5ghVF64oKQ7w1/gxu/P0L67TloszDv8uwRSUeLB8h1fjxYQczIc/gheOuY8Ddlg4uh+KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owEGYhDSPe8g3K0oc3QVvoWe3aGkmULc3RgqcpbwuGY=; b=nrh0u21klYdHp7mW2pYWvN+rIjsMupKwmW2qrFpKlgMwIjp8gjWd618boFy7vgFGCHfGBZCY3X/OGymscxE0ztMXnzulG7cfl10InHEXbJGd6t99u+n8EPWWn3Om/Pq8m0S3epQryqRDMRI+ZLIQI0SYCT3KdmlutwK8b/mNy4g= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 15 May 2020 08:33:49 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:33:48 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 00/19] staging: wfx: various fixes Date: Fri, 15 May 2020 10:33:06 +0200 Message-Id: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 X-ClientProxiedBy: PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (82.67.86.106) by PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 08:33:46 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1e8fdda-aff3-424f-b887-08d7f8aab037 X-MS-TrafficTypeDiagnostic: MWHPR11MB1310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u96AVyk29oa23xL4BstrTo/8lcg9nRjqdMp8EANhYdgNLqqGDmZ3D5O0z7kxcPMmtxta5g7fSxVYnJfAyZ1hE9DdG444CPuJ3fU74VXlK9y8Qk7MYjmEpzZivOPWjcAlXYFy/IwJQEowK7Gopkb5Gf9O/j4HDihFIXpaJ8NbF93v5GB/j3z1IxFTvwTdvHc46+BMVn+3S7TqEoc5UqEnoM1ZTywpi8yFQ9INtgoZDD5e32bG7zFRBw+jmjV68DlGsDNiffhlIR/5f14BCVk/4w9va9FiyNUHt5V+WcbkVLftUpgnGaMaEmDhPsywEA/oNzrDlufZKMKwa5Ntc23DldZ8R02dAd4thmXS0kZvCG2Cu46xHLcFTKz+9nkn3qohOKhbE7c3pUc3kT0VnQjaPLDYy1QiBmGpoM8R62pCoIZVNy7eDcupONh0GZZ7PlYS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(136003)(376002)(366004)(39850400004)(396003)(8886007)(66556008)(186003)(6512007)(66946007)(6506007)(36756003)(316002)(66476007)(26005)(52116002)(16526019)(6666004)(54906003)(2906002)(2616005)(478600001)(66574014)(107886003)(956004)(8936002)(86362001)(8676002)(6486002)(5660300002)(4326008)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: RenaLXUOcCN+ALqP0q+A10RMwExeovE9hbR3ZUYX9uwuzOI5x4LvPHsf8158DNWTHDqWmkNvPXKl1CGnMmmYbg0xZ9gFfpX54vki88Zy3V9cwnum0xKX1kmVbhTVxqvBAQKZIQNyhjVM+uh3MDn+0JDpZJZwFLkGs3S1L9kbtzFncIiimJj4S2Nj9JWvwIVdXC0LMsQohjqeoPkAkQHV2U1f0LK5LIOx1JYJYNkznma8rIyG2+tobyVQoBACW7/LuY5FproObWg9gij0qB/2zvSojnMggGE7La1d/vPAkq+inj+DS4cEFuu+Fs6SKXxjkCyWVHBNsUY3zDIyAn4hX87S1W+eStlnSt2Nco3wPGMfOhLBKEUVw4XpLE10wFSMVEL9IydXwEKIClyW3hqGma+vs3eYWXUmuPMZVPP0X6c2quxr626chDeiL8AGyQiat4h/cnAL16y05/0vpkBaXjuwZGmTLPZ+gmR5SEyQ8GU= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1e8fdda-aff3-424f-b887-08d7f8aab037 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:33:48.2914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rJfU9cjhjHN3Z4/IlW04FvJc4W4KHxZXnct+GKWC+xNX6aXMNm+lDQOoLXc85XuukNBFMWLdDCvK8G7NXCuYJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Hello, This series contains various changes. The most important patches are the 13 and 14 since they fix two functional defects. The other patches fix runtime warnings (1, 17, 18, 19), improve robustness (3, 4, 5, 7, 10, 16) and do some cosmetics improvements (2, 6, 8, 9, 11, 12, 15). This series have to be applied on top of patch sent by Dan: "staging: wfx: unlock on error path". Would I had include this patch in this PR? Jérôme Pouiller (19): staging: wfx: fix warning when unregister a frozen device staging: wfx: apply 80-columns rule to strings staging: wfx: check pointers returned by allocations staging: wfx: fix value of scan timeout staging: wfx: fix coherency of hif_scan() prototype staging: wfx: fix indentation staging: wfx: fix status of dropped frames staging: wfx: split out wfx_tx_fill_rates() from wfx_tx_confirm_cb() staging: wfx: call wfx_tx_update_sta() before to destroy tx_priv staging: wfx: fix potential use-after-free staging: wfx: rename wfx_do_unjoin() into wfx_reset() staging: wfx: merge wfx_stop_ap() with wfx_reset() staging: wfx: fix potential dead lock between join and scan staging: wfx: fix PS parameters when multiple vif are in use staging: wfx: drop unnecessary filter configuration when disabling filter staging: wfx: fix error reporting in wfx_start_ap() staging: wfx: remove false-positive WARN() staging: wfx: trace acknowledges not linked to any stations staging: wfx: remove false positive warning drivers/staging/wfx/bus_sdio.c | 3 +- drivers/staging/wfx/data_tx.c | 110 +++++++++++++++++-------------- drivers/staging/wfx/fwio.c | 8 +-- drivers/staging/wfx/hif_tx.c | 57 ++++++++++++++-- drivers/staging/wfx/hif_tx.h | 2 +- drivers/staging/wfx/hif_tx_mib.c | 2 + drivers/staging/wfx/main.c | 17 +++-- drivers/staging/wfx/queue.c | 7 -- drivers/staging/wfx/scan.c | 11 +++- drivers/staging/wfx/sta.c | 69 ++++++++++--------- drivers/staging/wfx/sta.h | 1 + drivers/staging/wfx/wfx.h | 2 + 12 files changed, 182 insertions(+), 107 deletions(-)