From patchwork Mon Sep 13 08:30:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D47FC433EF for ; Mon, 13 Sep 2021 08:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 478DD60F6C for ; Mon, 13 Sep 2021 08:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238037AbhIMIcX (ORCPT ); Mon, 13 Sep 2021 04:32:23 -0400 Received: from mail-bn8nam12on2052.outbound.protection.outlook.com ([40.107.237.52]:33696 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234575AbhIMIcV (ORCPT ); Mon, 13 Sep 2021 04:32:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uyc+tUgt7xPtzPLO/bAhZo6nxcFMQoGRpi3+RF9rdtgpYvT+SMv3VUP8yClC8AtV8uG+J61bqplwAHTnsoWSN4QaZBG7kXl4fjjJBqBcHXBX2Kp/0qy90qjhktnPD/kYwV52BT5V3prQSJSkCYplRGZFtPY7psKJ8/CqFseWp8u/75Uo0TRbs42OP+N/UOrYMnQIYIoqXkK+BIo7koViJfLS/bvriWVZexCBx2khnlyfbYoVpZj0EAmHxGNLrAAaxgUWD1isTLwugu00+PY3GXobhgn/2KYBJLbA9WlWscBNJV/HP5wW/YCSr11faMl/ex3+gJpGvpZ4y68vxKftoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SQNpjUe61SqKssYQU/Mb0PGzbkSpWdFzmsj0q0MhMz4=; b=cGmjKnBG4p0b1rNjnR5YnKY3MHKT6PPnVXIUU4WF61XirokLcyKQZe8P3yWnmHUIjbrBz6fXbiPdoiMkt9THTQKzOXHjwOCteswW9NBLHqi3NIkPqxuQdVePPVib6YfcnrhQMs513LpMoO7LAbEAGtVmCMy2kC+d8G+X4tiP5Y0qciVSkW19Du3zNgJVtNISsTAVIdXQ4k2xEMQ9GiI0wbSf4FliIZyMDk4rHCrLzGzVguiFmYELks5nyvPTQkc79rQFvkxrzXDx0rQlZS2sE4JicqaFpb2cwxWAsxBi5i1DXW3rj9xHhW9wQD3vcCjXPpb/CS0jSwBwxHnLRdbqDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQNpjUe61SqKssYQU/Mb0PGzbkSpWdFzmsj0q0MhMz4=; b=bO4WIRHAR1jlBV4hlNTZYz0qaJD6U/Z+A/trkwaUh/k5iCeHDr7pcjIHRTd7emeMZ3i9ZDq+vKnU7XHSkwF3K1NgGV6JU54a5ONey/34I0KB4TYqnY+67GEXaYjC5PF7jg+D7Kk7pGSLnmPK4RHwJlJONLzzhNe9gY+UheecjTU= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (52.135.97.18) by SN6PR11MB3263.namprd11.prod.outlook.com (52.135.109.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Mon, 13 Sep 2021 08:31:04 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 08:31:03 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 00/33] staging/wfx: usual maintenance Date: Mon, 13 Sep 2021 10:30:12 +0200 Message-Id: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 08:31:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7475c927-a116-4016-6e5e-08d97690d2f0 X-MS-TrafficTypeDiagnostic: SN6PR11MB3263: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i3Pl2unxpaC2Z/vzDUYQov8SLn67OwckZj3nIyESgRWKNi51RWZGBVPIhW3zvHz4m0bjjCEZAKKroZce+FAue5hcifLfEKDnzRF6M9hZUAKoIhRgZo8Hs1GBkk3xghRyssH8CnHKDU5Wri/9FVHsGK/5nNNyDLmqhX4pIHj8sVqeIDcB1Iq+idqALACzlzbktw2c+g8HeVa4098cAyJ1Gf/c26KoHFWFzMEe9wOC6lMUCVzvzHSc77OS6luWCs06JoxUFxLG/F0l70nU6zS1F8GQJ1/hby1SDOhDdXNpCdVB+Y9xaYTDUVon1UVQxFAwlMgjYh2OhJW7pB210E79cmAveV8t4omPXxsxFc4zg8hKir8PYDyEu012tuEtEgcLfAPS1JSxE5Ccck4N9PO2exRRX61WerFyOIfg3yniXyZcregDRP7tycvZJw/onCRQcexYUXatGmTHYXNE3xaBseTf8Ei2rO//VG5FoN4lxqgxewg6Ar5a5tVgDASwSUj3isIL4CBETIrq8gmxI65G2PwDz0pJcLCFGXqxDKshbETTY9avVJt4dQ0GBNjn28KzyimCAchFQ6Gy0UUVqiV+iOJBmH4uA5VI0YWrjDsykcW4voFXoXXle8YaZX+yKiJ4JDHMXqavJKc3C7uxXAC0YbHf0G5cPtKN18owzqS0Sx0YO4P70coSmfGwZjVqaZXbJZoa2ont55h2WseWaTEneiG3cVN3HCEWFfE+263LU7lqmNUXTKuVaKrp3iVBI6Ufrplnh3CvEi5x/JK8KmmornZHEySOLIubAne/ITFZLF0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(66574015)(966005)(107886003)(956004)(2616005)(5660300002)(54906003)(38350700002)(4326008)(6666004)(316002)(38100700002)(66946007)(26005)(66476007)(66556008)(186003)(8676002)(36756003)(8936002)(86362001)(508600001)(52116002)(7696005)(6486002)(1076003)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?cFLanZ8llypjMBOFihA2qMmy6?= =?utf-8?q?yoI0Wz0Uo9ROFnyQ9rvAqyac0nC08HQl9dYA9Sbka+TfJ/6IoPPu40a9?= =?utf-8?q?aw5G5+WwfyGZcVccmJiW3c0AXQahAWWVD6JcJZFhQEZ8mjLPKtToEQdA?= =?utf-8?q?ABhj/J++BpBLP7Q6VcMpP9nORJpUogsXEJPNtXEflT9zcS9K7ODIFcDm?= =?utf-8?q?kuFwkATY6gmEYmIa9Q78LLF+VodXuEXOA131CrbR+IlnagUhKn9y1wnK?= =?utf-8?q?BNcy2DaMfQc9VQ/L9k1M4Nc4irFGAFyCwEY6AW/PSNOaLGifNBTrwiBH?= =?utf-8?q?6VJpIAnltfuOfUD9U3Pk2zs1b26hJ67ZmNCZPEirNNDXe0cEYqVWo/5r?= =?utf-8?q?FM7IdvQ+rimZULczAe1C0hhmbtH3/MsaJWPIlKablnB6qQgxUrP3sSan?= =?utf-8?q?BYhGTQhD+Euc51Z/oxbq6Cr7/Sv4UYtyVg3fxKYeJsNKGf+KJg7Luyrq?= =?utf-8?q?LdJWvh0Q1A91xH6rJN5F6wWAHP9UvYThECGo1FpgORsqrxNb6Imk1hd7?= =?utf-8?q?C59N/IUuKePx6mYKD21qq9Yg0KghNcMf3IjZquuFo3OgP72Q+V3q8kZv?= =?utf-8?q?QNcX7TkHZbWcj3JyoPnE4JadZQ1k6+bHBpD7hq6s/ytG9QO+8HkinVYg?= =?utf-8?q?LpXAQuknolnsiLj+gKYXKHRCEJ688f9HARphsFuAnAQ4+61qazHRhtQB?= =?utf-8?q?teBxUIjkS+rBa4kP2p4sntvTVO4i0YfXgO+NNAIs9iIFXrmNL5DXt2CU?= =?utf-8?q?th+EZBl8365SVWzLRRl+XRlUqXzHyR54j7kw1DcFz4qe9ymFdT8KHP0K?= =?utf-8?q?XKCkRSBuCMHEHhYGuGSjdnUGVdZ9mCbTBqEkiN9c4/lYLGVBgWzwnnoW?= =?utf-8?q?5LKmWjaDtWvcJs47cP6awvAosTwXYU7iuukcgGTfJ2q2sM3tMpgkSdq5?= =?utf-8?q?0Wi0FUSzj62Yg+j30mGKwn7eFpTQPbEGY5qZmR7WtBYBQpeV1vFvvFiP?= =?utf-8?q?Im7LTFy1DDrOd0SpnVo64NwMpvo3Hl13edp6/oqPiDQ5300AGMG6zgor?= =?utf-8?q?/eCVMZDNenrtxtah56P9h/+5nHzfb6r6Ao2GJESU79bVTYbhekJC8m0P?= =?utf-8?q?Bp3owjsqHBXfSj2o7xAcdjXwTxoO5tr7A3f2VvzOmTVqr5/xhlfvFCxg?= =?utf-8?q?49kmyTFgOedKEat9tMwIAkwmJGCo8DYLqXRLcMN/5FTwYsDTyJs+V8HQ?= =?utf-8?q?fPVn7S6njY7sgAg+Ksxxg6icIECrwREv8+BlGflAczWA8zPwMWAIFf0T?= =?utf-8?q?rqbghSqSnEplVbvYiDFz6GqmbZiiPAi+MvxxQQhZ2gZ3iFpUh7FCaeYz?= =?utf-8?q?9D9HUlfx07PwlZhUrwC1iPkkG8psL3f?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7475c927-a116-4016-6e5e-08d97690d2f0 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:03.8175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: loNGDGrz4gA2krM0wOinIU6AGGEwOFJ3n82hnGtCt2bEaB3Nd81t5jZ72nxebMH93eT1amFTuYVVs3mAEUXpcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3263 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Hi, The following PR contains now usual maintenance for the wfx driver. I have more-or-less sorted the patches by importance: - the first ones and the two last ones are fixes for a few corner-cases reported by users - the patches 9 and 10 add support for CSA and TDLS - then the end of the series is mostly cosmetics and nitpicking I have wait longer than I initially wanted before to send this PR. It is because didn't want to conflict with the PR currently in review[1] to relocate this driver into the main tree. However, this PR started to be very large and nothing seems to move on main-tree side so I decided to not wait longer. Kalle, I am going to send a new version of [1] as soon as this PR will be accepted. I hope you will have time to review it one day :-). [1] https://lore.kernel.org/all/20210315132501.441681-1-Jerome.Pouiller@silabs.com/ v2: - Add patches 32 and 33 to solve a possible race when device is misconfigured - Fix C99 comments (Kari) - Replace "API 3.8" by "firmware API 3.8" (Kari) - Fix wording "aligned with first argument" instead of "aligned with opening parenthesis" Jérôme Pouiller (33): staging: wfx: use abbreviated message for "incorrect sequence" staging: wfx: do not send CAB while scanning staging: wfx: ignore PS when STA/AP share same channel staging: wfx: wait for SCAN_CMPL after a SCAN_STOP staging: wfx: avoid possible lock-up during scan staging: wfx: drop unused argument from hif_scan() staging: wfx: fix atomic accesses in wfx_tx_queue_empty() staging: wfx: take advantage of wfx_tx_queue_empty() staging: wfx: declare support for TDLS staging: wfx: fix support for CSA staging: wfx: relax the PDS existence constraint staging: wfx: simplify API coherency check staging: wfx: update with the firmware API 3.8 staging: wfx: uniformize counter names staging: wfx: fix misleading 'rate_id' usage staging: wfx: declare variables at beginning of functions staging: wfx: simplify hif_join() staging: wfx: reorder function for slightly better eye candy staging: wfx: fix error names staging: wfx: apply naming rules in hif_tx_mib.c staging: wfx: remove unused definition staging: wfx: remove useless debug statement staging: wfx: fix space after cast operator staging: wfx: remove references to WFxxx in comments staging: wfx: update files descriptions staging: wfx: reformat comment staging: wfx: avoid c99 comments staging: wfx: fix comments styles staging: wfx: remove useless comments after #endif staging: wfx: explain the purpose of wfx_send_pds() staging: wfx: indent functions arguments staging: wfx: ensure IRQ is ready before enabling it staging: wfx: early exit of PDS is not correct drivers/staging/wfx/bh.c | 33 +++---- drivers/staging/wfx/bh.h | 4 +- drivers/staging/wfx/bus_sdio.c | 29 +++--- drivers/staging/wfx/bus_spi.c | 22 ++--- drivers/staging/wfx/data_rx.c | 7 +- drivers/staging/wfx/data_rx.h | 4 +- drivers/staging/wfx/data_tx.c | 87 +++++++++-------- drivers/staging/wfx/data_tx.h | 6 +- drivers/staging/wfx/debug.c | 54 ++++++----- drivers/staging/wfx/debug.h | 2 +- drivers/staging/wfx/fwio.c | 26 ++--- drivers/staging/wfx/fwio.h | 2 +- drivers/staging/wfx/hif_api_cmd.h | 14 +-- drivers/staging/wfx/hif_api_general.h | 25 ++--- drivers/staging/wfx/hif_api_mib.h | 85 ++++++++-------- drivers/staging/wfx/hif_rx.c | 23 ++--- drivers/staging/wfx/hif_rx.h | 3 +- drivers/staging/wfx/hif_tx.c | 61 +++++------- drivers/staging/wfx/hif_tx.h | 6 +- drivers/staging/wfx/hif_tx_mib.c | 14 +-- drivers/staging/wfx/hif_tx_mib.h | 2 +- drivers/staging/wfx/hwio.c | 6 +- drivers/staging/wfx/hwio.h | 20 ++-- drivers/staging/wfx/key.c | 30 +++--- drivers/staging/wfx/key.h | 4 +- drivers/staging/wfx/main.c | 37 +++++-- drivers/staging/wfx/main.h | 3 +- drivers/staging/wfx/queue.c | 43 ++++---- drivers/staging/wfx/queue.h | 6 +- drivers/staging/wfx/scan.c | 55 +++++++---- drivers/staging/wfx/scan.h | 4 +- drivers/staging/wfx/sta.c | 135 +++++++++++++++----------- drivers/staging/wfx/sta.h | 8 +- drivers/staging/wfx/traces.h | 2 +- drivers/staging/wfx/wfx.h | 14 ++- 35 files changed, 469 insertions(+), 407 deletions(-)