mbox series

[v5,00/12] add support for WCN6750

Message ID 20220426145456.8055-1-quic_mpubbise@quicinc.com
Headers show
Series add support for WCN6750 | expand

Message

Manikanta Pubbisetty April 26, 2022, 2:54 p.m. UTC
WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which
are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a
single LMAC supporting 2G, 5G and 6G bands. It can be operated only
on one band at any given point.

WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices
which are directly attached to APSS (Application Processor SubSystem),
WCN6750 is not attached to APSS, it is attached to the WPSS
(Wireless Processor SubSystem) Q6 processor, the FW which runs on the
Q6 processor will enumerate the PCIe device. Since APSS is unaware of
such a device, it has to be registered as a platform device(AHB) to the
kernel for device probing. Like other AHB devices, remoteproc APIs are
used to boot up or shutdown of WCN6750.

WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation.
It uses AHB APIs for device probe and booting of the remote processor.
Once device is booted up, it uses ATH11K PCIe APIs for initialization
and register access. Hence, it is referred as hybrid bus device in
the rest of this series.

Since the chip is enumerated by WPSS Q6, device information like
BAR and BAR size is not known to the APSS processor. A new QMI message
called device info QMI request will be sent to the target for fetching
these details.

STA and AP modes are supported; Basic connectivity and ping are
verified in both the modes.

An important point to note is that though WCN6750 is a PCIe device,
it cannot be attached to any other platform except on Qualcomm
Snapdragon SoCs due to the aforementioned reasons.

Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

Manikanta Pubbisetty (12):
  dt: bindings: net: add bindings of WCN6750 for ath11k
  ath11k: Add HW params for WCN6750
  ath11k: Add bus params for WCN6750
  ath11k: Add register access logic for WCN6750
  ath11k: Fetch device information via QMI for WCN6750
  ath11k: Add QMI changes for WCN6750
  ath11k: HAL changes to support WCN6750
  ath11k: Datapath changes to support WCN6750
  ath11k: Do not put HW in DBS mode for WCN6750
  ath11k: WMI changes to support WCN6750
  ath11k: Update WBM idle ring HP after FW mode on
  ath11k: Add support for WCN6750 device
---
V5:
 - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76

V4:
 - Addressed comments on DT binding (Matthias Kaehlcke <mka@chromium.org>)
 - Rebased on ToT SHAID: 607c3dc2750382befa0f3f20063943bd058a2bc1

V3:
 - Patch series with 19 patches is split in 2 patch series, this is the second one
 - Rebased on ToT SHAID: 7316a74e54318d0cd648242b18ea83cdef6dda96
 - Addessed DT binding concerns
 - PCI common code is moved to ath11k.ko
 - Added a new HW param for WCN6750 which uses fixed firmware memory, this is
   needed to differentiate WCN6750 from other ATH11K chipsets
 - Modified the logic in patch "ath11k: Add support for WCN6750 device" based on the latest DT binding

V2:
 - Rebased on ToT
 - Addressed comments on DT binding

 .../bindings/net/wireless/qcom,ath11k.yaml    | 361 ++++++++++++------
 drivers/net/wireless/ath/ath11k/Makefile      |   5 +-
 drivers/net/wireless/ath/ath11k/ahb.c         | 162 +++++++-
 drivers/net/wireless/ath/ath11k/ahb.h         |   1 +
 drivers/net/wireless/ath/ath11k/ce.c          |   4 +-
 drivers/net/wireless/ath/ath11k/core.c        | 119 +++++-
 drivers/net/wireless/ath/ath11k/core.h        |   5 +
 drivers/net/wireless/ath/ath11k/hal.c         |  15 +-
 drivers/net/wireless/ath/ath11k/hal.h         |  15 +-
 drivers/net/wireless/ath/ath11k/hw.c          | 166 ++++++++
 drivers/net/wireless/ath/ath11k/hw.h          |  11 +
 drivers/net/wireless/ath/ath11k/pci.c         |   4 +
 drivers/net/wireless/ath/ath11k/pcic.c        |  76 ++--
 drivers/net/wireless/ath/ath11k/qmi.c         | 220 +++++++++--
 drivers/net/wireless/ath/ath11k/qmi.h         |  26 +-
 drivers/net/wireless/ath/ath11k/wmi.c         |  13 +-
 16 files changed, 977 insertions(+), 226 deletions(-)

Comments

Kalle Valo April 27, 2022, 5:14 a.m. UTC | #1
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:

> WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which
> are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a
> single LMAC supporting 2G, 5G and 6G bands. It can be operated only
> on one band at any given point.
>
> WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices
> which are directly attached to APSS (Application Processor SubSystem),
> WCN6750 is not attached to APSS, it is attached to the WPSS
> (Wireless Processor SubSystem) Q6 processor, the FW which runs on the
> Q6 processor will enumerate the PCIe device. Since APSS is unaware of
> such a device, it has to be registered as a platform device(AHB) to the
> kernel for device probing. Like other AHB devices, remoteproc APIs are
> used to boot up or shutdown of WCN6750.
>
> WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation.
> It uses AHB APIs for device probe and booting of the remote processor.
> Once device is booted up, it uses ATH11K PCIe APIs for initialization
> and register access. Hence, it is referred as hybrid bus device in
> the rest of this series.
>
> Since the chip is enumerated by WPSS Q6, device information like
> BAR and BAR size is not known to the APSS processor. A new QMI message
> called device info QMI request will be sent to the target for fetching
> these details.
>
> STA and AP modes are supported; Basic connectivity and ping are
> verified in both the modes.
>
> An important point to note is that though WCN6750 is a PCIe device,
> it cannot be attached to any other platform except on Qualcomm
> Snapdragon SoCs due to the aforementioned reasons.
>
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1
>
> Manikanta Pubbisetty (12):
>   dt: bindings: net: add bindings of WCN6750 for ath11k
>   ath11k: Add HW params for WCN6750
>   ath11k: Add bus params for WCN6750
>   ath11k: Add register access logic for WCN6750
>   ath11k: Fetch device information via QMI for WCN6750
>   ath11k: Add QMI changes for WCN6750
>   ath11k: HAL changes to support WCN6750
>   ath11k: Datapath changes to support WCN6750
>   ath11k: Do not put HW in DBS mode for WCN6750
>   ath11k: WMI changes to support WCN6750
>   ath11k: Update WBM idle ring HP after FW mode on
>   ath11k: Add support for WCN6750 device
> ---
> V5:
>  - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76

I already had v4 applied to the pending branch so I'm going to drop v5
and look at v4 instead.
Kalle Valo April 27, 2022, 5:16 a.m. UTC | #2
Kalle Valo <kvalo@kernel.org> writes:

> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>
>> WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which
>> are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a
>> single LMAC supporting 2G, 5G and 6G bands. It can be operated only
>> on one band at any given point.
>>
>> WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices
>> which are directly attached to APSS (Application Processor SubSystem),
>> WCN6750 is not attached to APSS, it is attached to the WPSS
>> (Wireless Processor SubSystem) Q6 processor, the FW which runs on the
>> Q6 processor will enumerate the PCIe device. Since APSS is unaware of
>> such a device, it has to be registered as a platform device(AHB) to the
>> kernel for device probing. Like other AHB devices, remoteproc APIs are
>> used to boot up or shutdown of WCN6750.
>>
>> WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation.
>> It uses AHB APIs for device probe and booting of the remote processor.
>> Once device is booted up, it uses ATH11K PCIe APIs for initialization
>> and register access. Hence, it is referred as hybrid bus device in
>> the rest of this series.
>>
>> Since the chip is enumerated by WPSS Q6, device information like
>> BAR and BAR size is not known to the APSS processor. A new QMI message
>> called device info QMI request will be sent to the target for fetching
>> these details.
>>
>> STA and AP modes are supported; Basic connectivity and ping are
>> verified in both the modes.
>>
>> An important point to note is that though WCN6750 is a PCIe device,
>> it cannot be attached to any other platform except on Qualcomm
>> Snapdragon SoCs due to the aforementioned reasons.
>>
>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1
>>
>> Manikanta Pubbisetty (12):
>>   dt: bindings: net: add bindings of WCN6750 for ath11k
>>   ath11k: Add HW params for WCN6750
>>   ath11k: Add bus params for WCN6750
>>   ath11k: Add register access logic for WCN6750
>>   ath11k: Fetch device information via QMI for WCN6750
>>   ath11k: Add QMI changes for WCN6750
>>   ath11k: HAL changes to support WCN6750
>>   ath11k: Datapath changes to support WCN6750
>>   ath11k: Do not put HW in DBS mode for WCN6750
>>   ath11k: WMI changes to support WCN6750
>>   ath11k: Update WBM idle ring HP after FW mode on
>>   ath11k: Add support for WCN6750 device
>> ---
>> V5:
>>  - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76
>
> I already had v4 applied to the pending branch so I'm going to drop v5
> and look at v4 instead.

I see that you also added Rob's reviewed-by to patch 1. Please include
ALL changes in the changes list, otherwise review is difficult as we
don't know what you changed.
Manikanta Pubbisetty April 27, 2022, 5:32 a.m. UTC | #3
On 4/27/2022 10:46 AM, Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
> 
>> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>>
>>> WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which
>>> are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a
>>> single LMAC supporting 2G, 5G and 6G bands. It can be operated only
>>> on one band at any given point.
>>>
>>> WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices
>>> which are directly attached to APSS (Application Processor SubSystem),
>>> WCN6750 is not attached to APSS, it is attached to the WPSS
>>> (Wireless Processor SubSystem) Q6 processor, the FW which runs on the
>>> Q6 processor will enumerate the PCIe device. Since APSS is unaware of
>>> such a device, it has to be registered as a platform device(AHB) to the
>>> kernel for device probing. Like other AHB devices, remoteproc APIs are
>>> used to boot up or shutdown of WCN6750.
>>>
>>> WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation.
>>> It uses AHB APIs for device probe and booting of the remote processor.
>>> Once device is booted up, it uses ATH11K PCIe APIs for initialization
>>> and register access. Hence, it is referred as hybrid bus device in
>>> the rest of this series.
>>>
>>> Since the chip is enumerated by WPSS Q6, device information like
>>> BAR and BAR size is not known to the APSS processor. A new QMI message
>>> called device info QMI request will be sent to the target for fetching
>>> these details.
>>>
>>> STA and AP modes are supported; Basic connectivity and ping are
>>> verified in both the modes.
>>>
>>> An important point to note is that though WCN6750 is a PCIe device,
>>> it cannot be attached to any other platform except on Qualcomm
>>> Snapdragon SoCs due to the aforementioned reasons.
>>>
>>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1
>>>
>>> Manikanta Pubbisetty (12):
>>>    dt: bindings: net: add bindings of WCN6750 for ath11k
>>>    ath11k: Add HW params for WCN6750
>>>    ath11k: Add bus params for WCN6750
>>>    ath11k: Add register access logic for WCN6750
>>>    ath11k: Fetch device information via QMI for WCN6750
>>>    ath11k: Add QMI changes for WCN6750
>>>    ath11k: HAL changes to support WCN6750
>>>    ath11k: Datapath changes to support WCN6750
>>>    ath11k: Do not put HW in DBS mode for WCN6750
>>>    ath11k: WMI changes to support WCN6750
>>>    ath11k: Update WBM idle ring HP after FW mode on
>>>    ath11k: Add support for WCN6750 device
>>> ---
>>> V5:
>>>   - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76
>>
>> I already had v4 applied to the pending branch so I'm going to drop v5
>> and look at v4 instead.
> 
> I see that you also added Rob's reviewed-by to patch 1. Please include
> ALL changes in the changes list, otherwise review is difficult as we
> don't know what you changed.
> 

Sorry for the inconvenience caused, I thought the reviewed-by addition 
is trivial and did not add it to the change list. Going forward, I'll 
take care of it.

Thanks,
Manikanta