| Message ID | 20221122084554.9494-1-shayne.chen@mediatek.com |
|---|---|
| Headers | show |
| Series | wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices | expand |
Shayne Chen <shayne.chen@mediatek.com> writes: > Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices. > The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7 > chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and > 2.4 GHz with 4x4 antennas on each band. > > Currently, mt7996 only supports tri-band HE or older mode. > EHT mode and more variants of Filogic 680 support will be introduced > in further patches. > > Reviewed-by: Ryder Lee <ryder.lee@mediatek.com> > Co-developed-by: Peter Chiu <chui-hao.chiu@mediatek.com> > Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com> > Co-developed-by: Bo Jiao <Bo.Jiao@mediatek.com> > Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com> > Co-developed-by: Howard Hsu <howard-yh.hsu@mediatek.com> > Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com> > Co-developed-by: MeiChia Chiu <meichia.chiu@mediatek.com> > Signed-off-by: MeiChia Chiu <meichia.chiu@mediatek.com> > Co-developed-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com> > Signed-off-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com> > Co-developed-by: Money Wang <Money.Wang@mediatek.com> > Signed-off-by: Money Wang <Money.Wang@mediatek.com> > Co-developed-by: Evelyn Tsai <evelyn.tsai@mediatek.com> > Signed-off-by: Evelyn Tsai <evelyn.tsai@mediatek.com> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> > > ----------------[commit message cut here]---------------- > > This series is based on the following series with fixes folded: > - https://patchwork.kernel.org/project/linux-wireless/cover/20221110093525.29649-1-shayne.chen@mediatek.com/ > > For easier review, the big patch has been splitted into multiple patches > per functionality. These patches will be folded into a single patch in > the final version. I wish you had split the patches per file like I asked, it makes reviewing a new driver so much easier. Reviewing is hard, please always take us reviewers into consideration when submitting patches. No need to resend because of this, but I am grumpy.
On Thu, 2022-11-24 at 10:06 +0200, Kalle Valo wrote: > Shayne Chen <shayne.chen@mediatek.com> writes: > > > Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) > > devices. > > The driver first supports Filogic 680 PCI device, which is a Wi-Fi > > 7 > > chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, > > and > > 2.4 GHz with 4x4 antennas on each band. > > > > Currently, mt7996 only supports tri-band HE or older mode. > > EHT mode and more variants of Filogic 680 support will be > > introduced > > in further patches. > > > > Reviewed-by: Ryder Lee <ryder.lee@mediatek.com> > > Co-developed-by: Peter Chiu <chui-hao.chiu@mediatek.com> > > Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com> > > Co-developed-by: Bo Jiao <Bo.Jiao@mediatek.com> > > Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com> > > Co-developed-by: Howard Hsu <howard-yh.hsu@mediatek.com> > > Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com> > > Co-developed-by: MeiChia Chiu <meichia.chiu@mediatek.com> > > Signed-off-by: MeiChia Chiu <meichia.chiu@mediatek.com> > > Co-developed-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com> > > Signed-off-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com> > > Co-developed-by: Money Wang <Money.Wang@mediatek.com> > > Signed-off-by: Money Wang <Money.Wang@mediatek.com> > > Co-developed-by: Evelyn Tsai <evelyn.tsai@mediatek.com> > > Signed-off-by: Evelyn Tsai <evelyn.tsai@mediatek.com> > > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> > > > > ----------------[commit message cut here]---------------- > > > > This series is based on the following series with fixes folded: > > - > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-wireless/cover/20221110093525.29649-1-shayne.chen@mediatek.com/__;!!CTRNKA9wMg0ARbw!3dab74MyEsbcnl1X5kv2N1RQlZiDfg9P-YL_3d_opTcmOs5bGdWoc91z1QGJgr8wg6g$ > > > > > > For easier review, the big patch has been splitted into multiple > > patches > > per functionality. These patches will be folded into a single patch > > in > > the final version. > > I wish you had split the patches per file like I asked, it makes > reviewing a new driver so much easier. Reviewing is hard, please > always > take us reviewers into consideration when submitting patches. > > No need to resend because of this, but I am grumpy. > Hi Kalle, I am sorry for any inconvenience caused. Will keep this in mind when upstreaming a new driver next time. Thanks, Shayne