| Message ID | 20230810073803.1643451-1-evan.quan@amd.com |
|---|---|
| Headers | show |
| Series | Enable Wifi RFI interference mitigation feature support | expand |
On 8/10/2023 12:37 AM, Evan Quan wrote: > The newly added WBRF feature needs this interface for channel > width calculation. > > Signed-off-by: Evan Quan <evan.quan@amd.com> > --- > include/net/cfg80211.h | 8 ++++++++ > net/wireless/chan.c | 3 ++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 7c7d03aa9d06..f50508e295db 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def * > cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1, > const struct cfg80211_chan_def *chandef2); > > +/** > + * nl80211_chan_width_to_mhz - get the channel width in Mhz > + * @chan_width: the channel width from &enum nl80211_chan_width > + * Return: channel width in Mhz if the chan_width from &enum nl80211_chan_width > + * is valid. -1 otherwise. SI nit: s/Mhz/MHz/ in both places > + */ > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width); > + > /** > * cfg80211_chandef_valid - check if a channel definition is valid > * @chandef: the channel definition to check > diff --git a/net/wireless/chan.c b/net/wireless/chan.c > index 0b7e81db383d..227db04eac42 100644 > --- a/net/wireless/chan.c > +++ b/net/wireless/chan.c > @@ -141,7 +141,7 @@ static bool cfg80211_edmg_chandef_valid(const struct cfg80211_chan_def *chandef) > return true; > } > > -static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width) > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width) > { > int mhz; > > @@ -190,6 +190,7 @@ static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width) > } > return mhz; > } > +EXPORT_SYMBOL(nl80211_chan_width_to_mhz); > > static int cfg80211_chandef_get_width(const struct cfg80211_chan_def *c) > {
On 8/10/23 00:37, Evan Quan wrote: > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index a1457995fd41..21f73a0bbd0b 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -7152,3 +7152,12 @@ > xmon commands. > off xmon is disabled. > > + wbrf= [KNL] > + Format: { on | auto | off } > + Controls if WBRF features should be enabled or disabled > + forcely. Default is auto. "forcely" is not a word. "forcedly" is a word, but it's not used very much AFAIK. I would probably write "Controls if WBRF features should be forced on or off." > + on Force enable the WBRF features. > + auto Up to the system to do proper checks to > + determine the WBRF features should be enabled > + or not. > + off Force disable the WBRF features.
[AMD Official Use Only - General] > -----Original Message----- > From: Randy Dunlap <rdunlap@infradead.org> > Sent: Thursday, August 10, 2023 11:41 PM > To: Quan, Evan <Evan.Quan@amd.com>; rafael@kernel.org; lenb@kernel.org; > Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; > airlied@gmail.com; daniel@ffwll.ch; johannes@sipsolutions.net; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; Limonciello, Mario <Mario.Limonciello@amd.com>; > mdaenzer@redhat.com; maarten.lankhorst@linux.intel.com; > tzimmermann@suse.de; hdegoede@redhat.com; jingyuwang_vip@163.com; > Lazar, Lijo <Lijo.Lazar@amd.com>; jim.cromie@gmail.com; > bellosilicio@gmail.com; andrealmeid@igalia.com; trix@redhat.com; > jsg@jsg.id.au; arnd@arndb.de; andrew@lunn.ch > Cc: linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org; amd- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > wireless@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH V8 1/9] drivers core: Add support for Wifi band RF > mitigations > > > > On 8/10/23 00:37, Evan Quan wrote: > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > b/Documentation/admin-guide/kernel-parameters.txt > > index a1457995fd41..21f73a0bbd0b 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -7152,3 +7152,12 @@ > > xmon commands. > > off xmon is disabled. > > > > + wbrf= [KNL] > > + Format: { on | auto | off } > > + Controls if WBRF features should be enabled or > disabled > > + forcely. Default is auto. > > "forcely" is not a word. "forcedly" is a word, but it's not used very much AFAIK. > I would probably write "Controls if WBRF features should be forced on or off." Yeah, that sounds better. Will update this as suggested. Evan > > > + on Force enable the WBRF features. > > + auto Up to the system to do proper checks to > > + determine the WBRF features should be > enabled > > + or not. > > + off Force disable the WBRF features. > > -- > ~Randy