mbox series

[v4,0/6] wifi: ath12k: switch to using wiphy_lock()

Message ID 20241007165932.78081-1-kvalo@kernel.org
Headers show
Series wifi: ath12k: switch to using wiphy_lock() | expand

Message

Kalle Valo Oct. 7, 2024, 4:59 p.m. UTC
From: Kalle Valo <quic_kvalo@quicinc.com>

Convert all uses of struct ath12k::conf_mutex to use struct wiphy::mtx, which
is already used by mac80211, and remove conf_mutex from ath12k. This way we
have one mutex less in ath12k and simpler locking design.

v4:

* patch 2: s/praparation/preparation/

* ath12k_mac_op_assign_vif_chanctx(): lockdep_assert_wiphy() was twice

* ath12k_mac_vdev_create()(): lockdep_assert_wiphy() was twice

* as this is now tested with MLO remove RFC tag, this patchset should be ready now

v3: https://patchwork.kernel.org/project/linux-wireless/cover/20240924092515.1049885-1-kvalo@kernel.org/

* new patch: wifi: ath12k: fix atomic calls in ath12k_mac_op_set_bitrate_mask()

* new patch: wifi: ath12k: ath12k_mac_op_sta_state(): clean up update_wk cancellation

* patch 3: ath12k_core_post_reconfigure_recovery(): take wiphy lock before hw_mutex to
  avoid a lockdep warning

* patch 3: ath12k_sta_rc_update_wk(): remove extra wiphy_lock() calls

* patch 3: update commit message, especially remove the sparse warning which was already fixed

* rebase to ath-202409191620

v2: https://patchwork.kernel.org/project/linux-wireless/cover/20240918181042.91891-1-kvalo@kernel.org/

* rebase to ath-202409051620

* patch 1: ath12k_wow_op_suspend(): remove extra wiphy_lock()/unlock() (Baochen)

* patch 1: fix clang warnings about unused labels (Johannes)

* patch 2: s/no/now/ (Jeff)

* patch 4: ath12k_sta_rc_update_wk(): fix wiphy_priv() usage

v1: https://patchwork.kernel.org/project/linux-wireless/cover/20240821153728.2121600-1-kvalo@kernel.org/

Kalle Valo (6):
  wifi: ath12k: fix atomic calls in ath12k_mac_op_set_bitrate_mask()
  wifi: ath12k: convert struct ath12k_sta::update_wk to use struct
    wiphy_work
  wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex
  wifi: ath12k: cleanup unneeded labels
  wifi: ath12k: ath12k_mac_set_key(): remove exit label
  wifi: ath12k: ath12k_mac_op_sta_state(): clean up update_wk
    cancellation

 drivers/net/wireless/ath/ath12k/core.c        |   7 +-
 drivers/net/wireless/ath/ath12k/core.h        |   7 +-
 drivers/net/wireless/ath/ath12k/debugfs.c     |   4 +-
 .../wireless/ath/ath12k/debugfs_htt_stats.c   |  26 +-
 drivers/net/wireless/ath/ath12k/mac.c         | 387 +++++++-----------
 drivers/net/wireless/ath/ath12k/peer.c        |   6 +-
 drivers/net/wireless/ath/ath12k/wow.c         |  26 +-
 7 files changed, 190 insertions(+), 273 deletions(-)


base-commit: 1a0c640ce1cdcde3eb131a0c1e70ca1ed7cf27cb

Comments

Jeff Johnson Oct. 11, 2024, 2:39 p.m. UTC | #1
On Mon, 07 Oct 2024 19:59:26 +0300, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
> 
> Convert all uses of struct ath12k::conf_mutex to use struct wiphy::mtx, which
> is already used by mac80211, and remove conf_mutex from ath12k. This way we
> have one mutex less in ath12k and simpler locking design.
> 
> v4:
> 
> [...]

Applied, thanks!

[1/6] wifi: ath12k: fix atomic calls in ath12k_mac_op_set_bitrate_mask()
      commit: 8fac3266c68a8e647240b8ac8d0b82f1821edf85
[2/6] wifi: ath12k: convert struct ath12k_sta::update_wk to use struct wiphy_work
      commit: 58550cdda961dedad8ed08c5abf8367d5c020fb6
[3/6] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex
      commit: b8c67509b91ec23fcacbb99d40c960ab479e1299
[4/6] wifi: ath12k: cleanup unneeded labels
      commit: 31489439e6481cd0c21c8c7096d2ec44dc56b6a6
[5/6] wifi: ath12k: ath12k_mac_set_key(): remove exit label
      commit: 37d06d71e69c16d24ccc276cb86489fd2fcd00c4
[6/6] wifi: ath12k: ath12k_mac_op_sta_state(): clean up update_wk cancellation
      commit: e805272f8c2dee280e2fa1c1a454517df17f1261

Best regards,