| Message ID | 20241212004906.3087425-1-quic_periyasa@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Fix the static checker warning | expand |
On 12/12/2024 1:16 PM, Kalle Valo wrote: > Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes: > >> Currently, ath12k_hw is placed inside the ath12k_hw_group. However, the >> ath12k_hw set helper function takes the device handle and the index as >> parameters. Here, the index parameter is specific to the group handle. >> Therefore, change this helper function argument from the device handle to >> the group handle. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> > > What's the user visible impact here? > No user visible, it just help to avoid the dependency of device handle (ab) for using the helper function ath12k_*_set_ah().
This patch series fix the below Smatch static checker warnings Warnings: mac.c:10941 ath12k_mac_destroy() error: we previously assumed 'ab' could be null (see line 10930) mac.c:11007 ath12k_mac_allocate() error: uninitialized symbol 'ab'. mac.c:11013 ath12k_mac_allocate() error: uninitialized symbol 'ab'. Karthikeyan Periyasamy (4): wifi: ath12k: Refactor ath12k_hw set helper function argument wifi: ath12k: Refactor the ath12k_hw get helper function argument wifi: ath12k: Refactor ath12k_get_num_hw() helper function argument wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function drivers/net/wireless/ath/ath12k/core.c | 16 ++++----- drivers/net/wireless/ath/ath12k/core.h | 12 +++---- drivers/net/wireless/ath/ath12k/mac.c | 47 +++++++++++++++++--------- 3 files changed, 45 insertions(+), 30 deletions(-) base-commit: 4d762e0043789e3608ad28c102131b232bd04377