From patchwork Tue Apr 29 12:29:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ond=C5=99ej_Jirman?= X-Patchwork-Id: 886035 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E70A2C178F; Tue, 29 Apr 2025 12:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745929770; cv=none; b=JA/zSFo+1CtfaxZaiEzVdl02rQFUSt7qCFsXSu4Gju0pR1pLaxlTPzuWgKxJvwFd9Im1lTmjGSS+P+H+Cabcgb/7WM7WGnWRjIQABKC/MAY2efn/cE+BEfEFDK0G5O7CX3iSRBr3Lh4zBQwiKa94ZqurAff1Ye2QbsgdoR3MorU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745929770; c=relaxed/simple; bh=l9WVZpUe07GworAoOUBdHThkKV12yLAUYvfdH4Ce0+A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p5NJ5KciWSQQJPkzJl0nIfQhrwoBtq/iO0S8npN74SNH1ygxaHCd6+1KzE0nN/BUXQkVrT6kLo80N7dnAQmNrC/wLqUf8hc5sgjZtxazN//7iXL62tytTB0NlvXM4f25tmecsEY9TtqibRfE6me87sculuxRutBZbQT3hDY6imQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=GddofSk+; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="GddofSk+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1745929764; bh=l9WVZpUe07GworAoOUBdHThkKV12yLAUYvfdH4Ce0+A=; h=From:To:Cc:Subject:Date:From; b=GddofSk+1YPDb7h8Ohb0gqjdYe6K6yP9JIHC1W1RG/OOBY3OSysTz2IMQxqn1dB42 MamLSNnmK1EFLAAO/OFgMAHb4exKOAO9PIhhw5uJNVY7xB1b/AJuHbdM7ZwFVmePEc +kwJstet4m8klO3BPbrP4oyhdtLuKPj6YmsXOf4o= From: =?utf-8?q?Ond=C5=99ej_Jirman?= To: Ping-Ke Shih Cc: Ondrej Jirman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH rtw-next v3 0/2] Fix inadverent sharing of struct ieee80211_supported_band data Date: Tue, 29 Apr 2025 14:29:09 +0200 Message-ID: <20250429122916.1734879-1-megi@xff.cz> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Ondrej Jirman This is a series of patches requested by Ping-Ke Shih in response to https://lore.kernel.org/lkml/20250427002414.410791-1-megi@xff.cz/ Please take a look. (hw->wiphy->bands[*] are no longer being NULLed when probe fails and on remove(), but I guess that should not be an issue? I tried unbinding the device and it worked fine without any crash) thank you and regards, Ondrej Jirman Changes since v2: - requested sizeof argument changes Changes since v1: - added patch to convert some memory allocations to be devm_* managed - check for NULL from kmemdup() - rename rtw89_copy_sband - drop some kfree due to them not being needed because failed rtw89_core_set_supported_band() results in abandoned probe() and devm_* will take care of that - add error return to rtw89_init_he_eht_cap and check for it Ondrej Jirman (2): wifi: rtw89: Convert rtw89_core_set_supported_band to use devm_* wifi: rtw89: Fix inadverent sharing of struct ieee80211_supported_band data drivers/net/wireless/realtek/rtw89/core.c | 124 +++++++++++----------- 1 file changed, 60 insertions(+), 64 deletions(-)