From patchwork Wed Jan 15 13:55:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6281C33CB1 for ; Wed, 15 Jan 2020 13:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BD5E24656 for ; Wed, 15 Jan 2020 13:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="moiUOHFo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730155AbgAON5O (ORCPT ); Wed, 15 Jan 2020 08:57:14 -0500 Received: from mail-eopbgr770085.outbound.protection.outlook.com ([40.107.77.85]:39089 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730381AbgAON4q (ORCPT ); Wed, 15 Jan 2020 08:56:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVcq6/FWOKWH3vWqYIrzfCl0qTj9N9za55L7v2iHGLrffW4nf9PrrDmo4erFuUEkBHHhZ8OZLpAgsVi5EqN4w9aFudNXs6mYTmJNHCHP3ZQ904pfd1y9GmwbCErhoTP0qFqGtEq6IE7hB8uQecVFIBhk55smEA3FZq2i2lRdS/1sY8v2netC9x/2Cz1i6+Ez0u4cc7J29WJhHEzUi4axlBjOvmPD1Pzv8Cv0bx6HylV0RvnwA16VWYpZNvhqcCzSrHXeHEy1SuOTrcCIiH4G3z+0Ic0KAHpRk+eYGwvWvwEZsM5KFiLcJsukrky1jL7htw0Gbd6l1xkuNOsYV4bjcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3u2E2RuWsPeDBspbS1BYQcNKcjt+UuC5v4vUdV+0qA=; b=JRADd+u8Qh097PlV8dwANZ9XNLc1/ikORsUTLCvIw8hgQdBXqVkgLfMQZVopBdRXUajCiR8xfQbVSrXYUQDcnTEG7xDR0sekkpSgiMED2000vjF1HODwiT1QzdYdLgADKJPwRHHXJ4Dk0D5FvDDwZZpa6tlCsLwRmt5hlsyK8bBa4ZXZG+1oSuD+k96RqUJY6fFarW1kB9dQS/I1E64k0X41YH0aV08xgdWEZ5VTCYTFFam9+ededvmotPjsINX+A/t+GujUoKVNoa29FzhZOlTQkTKjpjoMh9pgkxmHVYlgxrbpJDiD/qXPCOFuymCLf1FruImxGtzYvcvrVifDKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3u2E2RuWsPeDBspbS1BYQcNKcjt+UuC5v4vUdV+0qA=; b=moiUOHFoEf2dWzL78kJVMoyphgpetygZhOtXoJLRTa6CMS5gxpIS3oeq4XXM5S0Me2NvmU+DDQ6LmyuF1SqFIN1sZINLsiR4bkCJQRr8m82jI80ompQrLffWbGVkAVl64uobD6YSv+uFufuyrTnAlDGlYmPedJIrM28IiAXz/yY= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3661.namprd11.prod.outlook.com (20.178.252.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Wed, 15 Jan 2020 13:56:05 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2623.018; Wed, 15 Jan 2020 13:56:05 +0000 Received: from pc-42.home (2a01:e35:8bf5:66a0:3dbe:4cb5:6059:a948) by PR2P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18 via Frontend Transport; Wed, 15 Jan 2020 13:55:35 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH v2 64/65] staging: wfx: simplify hif_multi_tx_confirm() Thread-Topic: [PATCH v2 64/65] staging: wfx: simplify hif_multi_tx_confirm() Thread-Index: AQHVy6t2ZLEHcGkyoU+PxqF9Ez40+g== Date: Wed, 15 Jan 2020 13:55:37 +0000 Message-ID: <20200115135338.14374-65-Jerome.Pouiller@silabs.com> References: <20200115135338.14374-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20200115135338.14374-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PR2P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::20) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.25.0 x-originating-ip: [2a01:e35:8bf5:66a0:3dbe:4cb5:6059:a948] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f8a185d-6cd0-445e-cd38-08d799c29927 x-ms-traffictypediagnostic: MN2PR11MB3661: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(136003)(346002)(366004)(199004)(189003)(8886007)(6486002)(316002)(54906003)(71200400001)(36756003)(6506007)(66476007)(66446008)(66946007)(110136005)(8676002)(81166006)(81156014)(478600001)(86362001)(2616005)(4326008)(66574012)(2906002)(107886003)(1076003)(16526019)(186003)(85202003)(5660300002)(6512007)(52116002)(64756008)(66556008)(85182001)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3661; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L2734OgM+GNyb1qKT6bxjV8kH9aD7LIZZNIOxbXZNApSfMBxrbDEnZAbSOdh48rhvg7jpKIhL9uT/eVz4d6BtxM5MtSZ46hcMU0yc5kJWSAeb6UHKgzi+jYrRttaEmQ1g/LLE2/PXG5FKJjrr4tKjp/px7qlXtkNOmMe9DiChcMUXPVE0N+jUE2ciKD1aVthNoCnVKeSX9QEZ1Oyhta4xZ0bzKurzJQrke/il7zM4fRHQ3/Qv8/jRjJDstIzCvm+tGqqP1sgl7opIewiovr17Q6Pbjcdm0t353jSjhOj3BlHjBI5/jUpnLa/usZC+3ITkSc7VkIjBl+1oSeu2Hv+jLfgX5Y2sMd1qTBKA5ddbOqlB/mOw9T5OhDzLqC0TemgCr4wPxJe63iE4fMl6jOqXbGwAoiRo/TuILn6x+3QRpltbXwmmlQQi3VJpflDh6KE Content-ID: <8FCBE9271BF65D4F9FEF3C60FAE94438@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f8a185d-6cd0-445e-cd38-08d799c29927 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 13:55:37.0530 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +mJpJOai+RX8yTDTKFbWanIzxJqxouXwHToj65IGnB4CiYYqhzTcgUpKNePxnq1NcH+9nyC1euCh/9mEV6IWVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3661 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Usage of the "buf_loc" variable does not simplify the function. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index f798cd6973b6..33c22c5d629d 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -77,21 +77,16 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, const struct hif_msg *hif, const void *buf) { const struct hif_cnf_multi_transmit *body = buf; - const struct hif_cnf_tx *buf_loc = - (const struct hif_cnf_tx *)&body->tx_conf_payload; struct wfx_vif *wvif = wdev_to_wvif(wdev, hif->interface); - int count = body->num_tx_confs; int i; - WARN(count <= 0, "corrupted message"); + WARN(body->num_tx_confs <= 0, "corrupted message"); WARN_ON(!wvif); if (!wvif) return -EFAULT; - for (i = 0; i < count; ++i) { - wfx_tx_confirm_cb(wvif, buf_loc); - buf_loc++; - } + for (i = 0; i < body->num_tx_confs; i++) + wfx_tx_confirm_cb(wvif, &body->tx_conf_payload[i]); return 0; }