From patchwork Wed Apr 15 16:11:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B10C2BA19 for ; Wed, 15 Apr 2020 16:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0CE3206F9 for ; Wed, 15 Apr 2020 16:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="kK9/gM8Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415252AbgDOQM7 (ORCPT ); Wed, 15 Apr 2020 12:12:59 -0400 Received: from mail-bn8nam12on2062.outbound.protection.outlook.com ([40.107.237.62]:4064 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415229AbgDOQM5 (ORCPT ); Wed, 15 Apr 2020 12:12:57 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRWCcrVRL9gEZO84EI88GPd9wnZwK1V+4XUbOqCa2h8GIfB/KPByxnBdFNbWpOYfD4zCbC/n/qtjmte85MGC++rwg9LuYnLvOGFqcw0um/5uTnMBsot9xgQ/WXkiTNHxwckH/yQC6AGV9fu/56Ls27TjCFtdhOh1iEQoPpS0zKl03ypH9WC05iC0oLovTSr3Gzc/4FQgpJAH4MwTb0Ilkxt8fxPWs8P9OGxY+aZ00CMbnlJ/ryBtYxc9yDi0/f+SrqTiI7RoCLcDj1dZjDSb2vTvePekr9NVkBZa0QmBY3StAWYQyFyi9cBkbuwQNbI4vX+yBZmiJQt0mkro5YPk3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNLfJVzh5VJ31qEn7gbyiYEuSbHzRJCYxbJgsAgxrkk=; b=ihMYL1lEEghaXUNBNB22QzkazDmRWjL34oxbO5GJYhEiex5vDR6DtK3HBKjJJdTD77rgWQfOG0CpInnYKOjIat9PZJbZ8bEEnmhJXKPLuA841lnsiaj4E6jzjKvaMVp1opj90nyuwXHa9jGnG/iEA9h984SKWrQVf/+NKtQJXhA1ov8MfYpqhm+gQ9ER+KqerhOdpbDdBgdlkc8CXi2fjQKNan3zxDL+suvCbUv7BAgk6PQGbpenXoULkfV/7kL/RGPFfXvPZ/MIP27eDDgT6J9CMG+PkL8xfSfrp8g7JWanoQJxTcS04U2UVkYs00iUzfISQoWzBmppapqYE4smhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNLfJVzh5VJ31qEn7gbyiYEuSbHzRJCYxbJgsAgxrkk=; b=kK9/gM8ZdOHvF+JGTj5I3C1xCCtKarUR+I0k0I7PHk6awaB9e0o1inY1l65a+fYDyIUfXxa5LpmkI5GHDOa3DgcVeKJHyBkb/1pC/BOhd/W/jXuQmz8GOuLOvqYHSAK8wkuAJZlpZf6tn98H1kIwanNUUSlPxoaXScsFP48z4Jg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 16:12:53 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:53 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 16/20] staging: wfx: drop useless attributes 'filter_prbreq' and 'filter_bssid' Date: Wed, 15 Apr 2020 18:11:43 +0200 Message-Id: <20200415161147.69738-17-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:50 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5b34595-86cb-4be6-68c6-08d7e157da0b X-MS-TrafficTypeDiagnostic: MWHPR11MB1327: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:317; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(39850400004)(136003)(346002)(366004)(376002)(396003)(4326008)(81156014)(107886003)(52116002)(54906003)(8676002)(478600001)(8936002)(6506007)(5660300002)(6512007)(36756003)(8886007)(86362001)(316002)(6486002)(1076003)(2616005)(186003)(2906002)(66574012)(6666004)(66556008)(16526019)(66946007)(66476007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RvU5qAJMv4nCX8E7Mkvbb4WE/ZLu7umW0QyORGO5USwTIN0Bh9LeSRfI4ubmFkRKOZ420Nk0Xu/E038cwWTENY0yyBqJMAhX85LT0xzlf5AEUJrL1JPLLDrS4feVTWNR8qkWwlkaJ2oApOczTxpdfNIB8zv3qTaC3Rwes3c2i+7+PFsAtho6FpTrkAczswdrnUmE7Fbq+7xBZjamDLglbLgSMuwNonO+tnedTRY24nH1Bm6DG4GtJ89YsTniEXjYGY04FrMUU2E8Z9KUJtZC/9p92IhZJ50eOpw3sBd3laYxp4bnU8oPtgiSQjPxa5/Dt0xIxWiFvky3Nc2e4J2SLW6lU0cfqB2qczBoXcxt2vscGzeQF7GKt/YYZNudVAcUYC6tO2aOuUC94QEBlUO9wTJ2YM6xSIKTvI+PbaoP74HhOOUaQ5B9HzXjNj5U8LLu X-MS-Exchange-AntiSpam-MessageData: +CQhcFEbKDIiv+oxAzja5MDfPyrfJZRM41ZtZyUr3I/mTLoE5mQsLTsnP6xcW8f4vE2glOUpz0Q8vhCwCl1aXuNWfCrUoECCjeOBUYfA/4cW0N30fL2PrRjeNyTBYd/uB+4abiwGLZMxSBDR4CaXt564DzHgwxflel5AqR0xFhP4djbXWe9v8otLmn2uQLXzyR7+EtVWNTj64+EMfSGQjg== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5b34595-86cb-4be6-68c6-08d7e157da0b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:53.5588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U76nZlfXbO2Sm+/5omj7Ox5HrJZNYwjGyLap6wpSHSJd1l7dPAvm8E9GXgZdBGcZ+SpwVHNbao2jrcev6qbWaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller It is now useless to store filter_prbreq and filter_bssid in struct wfx_vif. We can just pass them as parameters to hif_set_rx_filter(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 12 ++++++------ drivers/staging/wfx/wfx.h | 2 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index c7505b5d0947..a9261ef4b4c5 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -194,6 +194,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, { struct wfx_vif *wvif = NULL; struct wfx_dev *wdev = hw->priv; + bool filter_bssid, filter_prbreq; // Notes: // - Probe responses (FIF_BCN_PRBRESP_PROMISC) are never filtered @@ -227,9 +228,9 @@ void wfx_configure_filter(struct ieee80211_hw *hw, wfx_update_filtering(wvif); if (*total_flags & FIF_OTHER_BSS) - wvif->filter_bssid = false; + filter_bssid = false; else - wvif->filter_bssid = true; + filter_bssid = true; // In AP mode, chip can reply to probe request itself if (*total_flags & FIF_PROBE_REQ && @@ -239,11 +240,10 @@ void wfx_configure_filter(struct ieee80211_hw *hw, } if (*total_flags & FIF_PROBE_REQ) - wvif->filter_prbreq = false; + filter_prbreq = false; else - wvif->filter_prbreq = true; - hif_set_rx_filter(wvif, wvif->filter_bssid, - wvif->filter_prbreq); + filter_prbreq = true; + hif_set_rx_filter(wvif, filter_bssid, filter_prbreq); mutex_unlock(&wvif->scan_lock); } diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 53184fe2da4b..310d95478824 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -90,8 +90,6 @@ struct wfx_vif { int filter_mcast_count; u8 filter_mcast_addr[8][ETH_ALEN]; bool filter_mcast; - bool filter_bssid; - bool filter_prbreq; bool filter_beacon; unsigned long uapsd_mask;