From patchwork Tue Sep 8 18:34:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249355 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4798209ilg; Tue, 8 Sep 2020 11:33:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz25aPAzoaLCNCPh6VeiLs6yCOU8wyKgPzdWL9HzBJDGZm9ZBMItS6yli/UUPFGU/WuiuTX X-Received: by 2002:a05:6638:210:: with SMTP id e16mr272010jaq.94.1599590024112; Tue, 08 Sep 2020 11:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599590024; cv=none; d=google.com; s=arc-20160816; b=WQDAXtOmQJiuhuSrle2qJq7RaoRYx79X0P86TyaOAUrYj57rUEDa7wZaEccP/XNgmp hFxgmMLIuHlcTMgoIk36BQp6hGj/z97TV6TrbGiimdbteTHfDw6LzeiA5+RR67OpreZS 27CPsCpTW8D7rv6btgti17NnB0Xo2bS320SHDKiRsGJAhjZpCk3g0d7mo93LRLDRmjM3 KqTxhZg9OKlDOoqGP3IJT4AXdq5gRhCUV7s4Gxlljt8uCw3Ezgyr2s5b5jcEwU4D3kn9 pgAyUxz2FYIyhfVMl2s0dlK8XfUwg+P2qqYSj27pqHCZTYkJwzPTrO2MTDsEMclm2/fC wb1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=c6Xl3xlRIhDSOcrfTtTxaUbU9sze+9yDxnnPsFikc18=; b=TKbCZWxLlDkNorUgMC1UatZ1sSGYESZi8PQLrIqRXJm73DNjWJ7hVeoSYkcIFDcI5n vJ0YAC86Gm5dMKnxZ/pHoUYolEwHUG2jANKW8jDhq5LgtNnVUhjG1OIQoZnLHzRmp39Q xHOb/9eXCIIXyjUu9xSG2/d/xMWCAL411WAmjw18tmUHLmf3xqxd8NXRZNoav5ukbhHy WABsVFTp+l3ul3Ri0UYFqUb5Gyd4AuHkeJfbFbXHCDKyEsmdjHRcI+eSBWJn/i1gtyOP JSVpA75p38BHlJGNVOhkcSil6NfElwcpmYxVKZTdqPXDRRfx0hZftUyMzRD8HR2BdpS0 CsyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="IatYLwP/"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=qgBhPVuV; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id y13si11729725jat.99.2020.09.08.11.33.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:33:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="IatYLwP/"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=qgBhPVuV; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c6Xl3xlRIhDSOcrfTtTxaUbU9sze+9yDxnnPsFikc18=; b=IatYLwP/2wV8y1ZADAnJk60qz pYaQSq3HhCTZiDvb/z7+T/WJy8CjkSith08gbQy3moL5XU4Kz4Uz3vboHzvNDyXAa3yYijrJ8XQ3x VwalwWLuL9XR5a/i8Z4TYWat7Mxd42WEbQDKwBHM9pjB8LWvY32wtndHjowAQ1QXHUqem+iCXjJLc BEWtufzAdsgAyDohDj3qIrmBJzikP9ZA3SsW9SiCxPSmzu/m2XL2bHJZhfLw2GsIeB0M2ggSi7wXp PiHmE62TseFkDpDDkk2PKY9YnEhLjvGq9BJpt9D+NqQaTZNB1sA90gaCZD2ppNZU9yTyA4aifI4nJ RnXn86Njg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiR2-0006XD-Bi; Tue, 08 Sep 2020 18:33:40 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiR0-0006WE-DA for wcn36xx@lists.infradead.org; Tue, 08 Sep 2020 18:33:39 +0000 Received: by mail-wr1-x444.google.com with SMTP id o5so205231wrn.13 for ; Tue, 08 Sep 2020 11:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qjd8fV7YLxTioYXpGkugtmpc2/qrixUOQBDAVrehnVM=; b=qgBhPVuVYy6Q8M49AdQ4WF2mbirJRIUSI4J3wlYPz640eBCc6tmic0Iz8gxn3XhkQP 7zEGRjAcAPhDHZaCOM5xbJwTtkSzYSoopbdu5Oyh9FiURTVrchtpAW6xCdRo6mBqVp6w Ob3LUy3bw0r5dyGXxrBd4LIIiEueDOIFTMMMe4QfzKIOOSKZnepEenm6IeFPv15fVqCr JH4cYa4DUc8dVsUUlapx8f0t6oCZLdluoixyjs0ftCfoXbtH67WjrI55ZM18zsDXyLUu dWo9hor3bL7D6o3QGYKqjzQCsWdt9Y6lJRubeb+6JTS9cptFtgFJu/1qOkwVngDeCE+u 7KEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qjd8fV7YLxTioYXpGkugtmpc2/qrixUOQBDAVrehnVM=; b=XzbyxYFfNrHD2TuKM+t/JvIFdaKB3uoXM9yt+vk92/NWWvvE1rL3v87UhJrYFOXQft ehscb3sEFHuE0C+b5BNi7G1YBDB6ReE+DL2TFJfSGJuoDxBNw0gW6zMB0JCeuidhi0EW UorcVt1iSq9aktZLiK/Edzu+XLPGYEUgi6QI2Sg8SXb+Co+tWm+2oM7QrGP3lePxAn/7 f4R+jAhksZaFxDI/V7B/Jd1BYV3s6ypH2xQB6WDL8uAiHtzCSz+ZaMDH4kWUVk1n3aSO Sq1EiiqlzdRrIU/utR3tUMq3ouDV1SK32IjVXIUBpL9ab0Ui2K3HXlJkVdcwWY37mP+S OYTQ== X-Gm-Message-State: AOAM531nqaw0FGs3d2u5ZRz4eOE2HZhD7yXUsEkgTcQCIEG4EzPLAqr1 4lXPYcG9GPH8CJRFIXEeBVZdsg== X-Received: by 2002:a5d:4603:: with SMTP id t3mr912133wrq.424.1599590017534; Tue, 08 Sep 2020 11:33:37 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id b194sm294992wmd.42.2020.09.08.11.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:33:37 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v3 1/2] wcn36xx: Mark internal smd functions static Date: Tue, 8 Sep 2020 19:34:23 +0100 Message-Id: <20200908183424.2871101-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200908183424.2871101-1-bryan.odonoghue@linaro.org> References: <20200908183424.2871101-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_143338_454273_FC6C2689 X-CRM114-Status: GOOD ( 15.53 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This commit marks all smd.c functions that are only used inside of smd.c as static. Previous commits added some VHT specific setup functions non-static which is the right thing to do in terms of having granular git commits that compile warning free. What we really want is for local not global scope on those functions. This patch makes the conversion from global to local scope. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 34 ++++++++++++++------------ 1 file changed, 18 insertions(+), 16 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index ac10789332d8..a8d2af74ef62 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -80,7 +80,7 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { WCN36XX_CFG_VAL(ENABLE_DYNAMIC_RA_START_RATE, 133), /* MCS 5 */ }; -struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { +static struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1), WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1), WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0), @@ -242,7 +242,7 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif, } } -void +static void wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct wcn36xx_hal_config_bss_params_v1 *bss) @@ -279,7 +279,7 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta, } } -void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { @@ -299,7 +299,7 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, } } -void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, +static void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (sta->ht_cap.ht_supported) { @@ -324,7 +324,7 @@ static void wcn36xx_smd_set_sta_default_ht_params( sta_params->dsss_cck_mode_40mhz = 1; } -void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) { @@ -340,7 +340,7 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, sta_params->vht_tx_bf_enabled = 0; } -void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) @@ -1361,7 +1361,7 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn, v1->p2p = orig->p2p; } -void +static void wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, struct ieee80211_vif *vif, struct ieee80211_sta *sta, @@ -1500,12 +1500,12 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif, return ret; } -void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - const u8 *bssid, - bool update, - struct wcn36xx_hal_config_bss_params *bss) +static void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update, + struct wcn36xx_hal_config_bss_params *bss) { struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif); struct wcn36xx_hal_config_sta_params *sta_params; @@ -1713,9 +1713,11 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn, return ret; } -int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif, - struct ieee80211_sta *sta, const u8 *bssid, - bool update) +static int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update) { struct wcn36xx_hal_config_bss_req_msg *msg; struct wcn36xx_hal_config_bss_params *bss;