From patchwork Thu Sep 10 15:08:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249663 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp828061ilk; Thu, 10 Sep 2020 08:08:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyESLfc+2Cnr/Lvy27DeUk7ghFGq1a7u5vggtrNU84QE0ZYVQ5GlqpPZNe6FWDxpTvbowXz X-Received: by 2002:a92:9f53:: with SMTP id u80mr8425462ili.42.1599750484237; Thu, 10 Sep 2020 08:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599750484; cv=none; d=google.com; s=arc-20160816; b=xCJry2vdhn9R6s0TkrxIgNToYHnuKH+LXZ3+ocZ8uS48XkkHY4WBGiwm29zqDlzdvl Hkuwv5C9PrCV2JgnHykX6EkQIoswbffBjuGBGSiex+ZTrmPvhqLiC2xFNohrvb2y2mMM Cpje6LgfIQYeJltEIh5GnbT399ivvlL1Ejx8l3wH8YNxmlisPEXIMQfm4oeNtUHHOiUq ZCYVMuYQo8T+tSy8I/0jjRT30K02xvREnmy7rgYmUbIQkp+EJayCD60VSU9TxgNiHu3E 0twSv/fGMKRWwTiByW1CzWYtabT3Ox5+RYvPmO6eNrkBJtyWrna/OYG2ZPDsjW7trUSb Y50Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=jXBy7gsuY0HX3uxODsb30ERIY35aUlkkY3TL7fby5Q4=; b=zxj5/KZaz16fO2RkKm5tYtVntWgAZiwLXe2NNEYdJR965fIxQnyYa81pTlJSbql5ik ZUqr8h97cHYucTybH8OrnLAJbi9G4Khmh9r58TwCOLXGjFoOu9ebmMdXzywJWD+gS7XF NIq5mbbxfy2homm8Bz8gZFFebWWyLXLMYX5raHRjmMcoM9xfcHSldrg9w/9uo6UMoMGY 7m63IoS0Zzz5A4u19oKXRJOsd0+tbuwjZZfco0RnK+f1a1xU1oGrRmL9n1jmyfAqAUCC 6xKf+gyD1s0D2o9UiVQPK258RxOhngRU/xY2rLHGIJPHEwsUmBaBP33myLT+Z6AkPSDP jkGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=wcyzXoQF; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EAtrRbzx; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id c3si4388542ils.33.2020.09.10.08.08.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:08:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=wcyzXoQF; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EAtrRbzx; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jXBy7gsuY0HX3uxODsb30ERIY35aUlkkY3TL7fby5Q4=; b=wcyzXoQF3dFW0bV9HEtVXpmmY /vAt9ownxH4G5I8R31yCqG5LJaIJcN1GTEwaszpjjlC+0LpRI5frFbEiUGXudaAgBcXm6dAHV7MCi C8yXdUvx8j8b1vJ/fRcIg75kFSX+l2sO0AWodCsBu5haOMkmDunMU2xlfB9tBYLgiw1iExJpcF1b1 /8B1JfMgM7mt2rjWHwD+bPQ2C+He6hpZILP00qIXZKPLoolBHtKNuj5sjjpXGrWCAn69ez5+RtgBB uXqFUwr8rLhRK6WPcom1mzo9EDscdv/tR7QjS6ldRoeGBODp23cSseweF2/MusVbURUX530FQlbfp oV5EFRnDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGOB6-0008IT-W2; Thu, 10 Sep 2020 15:08:01 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGOB5-0008HM-3l for wcn36xx@lists.infradead.org; Thu, 10 Sep 2020 15:07:59 +0000 Received: by mail-wr1-x442.google.com with SMTP id z1so7097241wrt.3 for ; Thu, 10 Sep 2020 08:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bux7fAG0+zOODRO5fQccC45bmW3bWHTSwsrxqwBCgeg=; b=EAtrRbzxlI8L7D+Mx1FEFBHBOY14RfStjnJdk7p0Gt4QMaL/0kDxz52hvNrTiFPO1I B7bd4UNzRxFRoF1cQGLBVMLkisIm6yqsSXH+4WAYWQrJMpF37g/sVqe6TakU9cvlp9LK 9dRlP/IZPy1mZucFDmuAg9O9LOJO+U2sdsAgjmY+NwnC0UdHeM7pU8+gLmH8J+gF9KoZ SrIrHTOVDM7C0rAgLdk8MSEBugeYEF1qAoVAT4Pkp69vWx0kt6SoSoo8aXgJS5mlJtmG m1tkznaKYVKtRgqHLzM+1qIpdw6j1tliiiwcOFTpx0B0sU+Mv3qTed0Vf9vJVwXEk6Ru PQhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bux7fAG0+zOODRO5fQccC45bmW3bWHTSwsrxqwBCgeg=; b=tL69DgSw1/CWnvljsd3+VVlWdfoDc6qOJgiZ794gfxGjkXzgKnt2P4NPQfuipgEWHC VlOM+ZjZEAG96/cxSMzRdfEZanUCGzv+gip6AJsianrZWPRBFaeaPxy9LCekp5fWGpvQ N3Efz9PGI3kye2TupXQ5pjgOLZZk3HhNUyjIP74zhpnDtuNrZjvlDwgEgqyCO7dYoQnZ E2z4LSrnU+eGqABw0L2s26sgn6yfRSpYGRtxnVolvczkUmg6HWzOobMLAXueGm8NTvfr zxAQvoyV3MUcuLQutr8h+ZSj+vlNjDjbZjwy462lHirX8kfoiOZd556diAU3F9ug3j7Y MEkQ== X-Gm-Message-State: AOAM533MGFjB5UsaI40Fb53Dl4SPuIui1LCBSo6VBrH14oCSgh20M64g YAuVyOzTYK3efx9Eb7jF0JgwOQ== X-Received: by 2002:adf:a1d6:: with SMTP id v22mr9788348wrv.185.1599750478327; Thu, 10 Sep 2020 08:07:58 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a17sm9732901wra.24.2020.09.10.08.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:07:57 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v5 1/2] wcn36xx: Mark internal smd functions static Date: Thu, 10 Sep 2020 16:08:44 +0100 Message-Id: <20200910150845.2179320-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200910150845.2179320-1-bryan.odonoghue@linaro.org> References: <20200910150845.2179320-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_110759_161374_850AEA92 X-CRM114-Status: GOOD ( 14.82 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This commit marks all smd.c functions that are only used inside of smd.c as static. Previous commits added some VHT specific setup functions non-static which is the right thing to do in terms of having granular git commits that compile warning free. What we really want is for local not global scope on those functions. This patch makes the conversion from global to local scope. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 61 ++++++++------------------ 1 file changed, 18 insertions(+), 43 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index e74abc153153..bccdae62ffbc 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -80,7 +80,7 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { WCN36XX_CFG_VAL(ENABLE_DYNAMIC_RA_START_RATE, 133), /* MCS 5 */ }; -struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { +static struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1), WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1), WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0), @@ -242,11 +242,7 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif, } } -void -wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - struct wcn36xx_hal_config_bss_params_v1 *bss); -void +static void wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct wcn36xx_hal_config_bss_params_v1 *bss) @@ -283,10 +279,7 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta, } } -void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, - struct ieee80211_sta *sta, - struct wcn36xx_hal_config_sta_params_v1 *sta_params); -void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { @@ -308,9 +301,7 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, } } -void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, - struct wcn36xx_hal_config_sta_params_v1 *sta_params); -void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, +static void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (sta->ht_cap.ht_supported) { @@ -335,9 +326,7 @@ static void wcn36xx_smd_set_sta_default_ht_params( sta_params->dsss_cck_mode_40mhz = 1; } -void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, - struct wcn36xx_hal_config_sta_params_v1 *sta_params); -void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) { @@ -353,9 +342,7 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, sta_params->vht_tx_bf_enabled = 0; } -void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, - struct wcn36xx_hal_config_sta_params_v1 *sta_params); -void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) @@ -1376,12 +1363,7 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn, v1->p2p = orig->p2p; } -void -wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - struct wcn36xx_hal_config_sta_params_v1 *sta_par); -void +static void wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, struct ieee80211_vif *vif, struct ieee80211_sta *sta, @@ -1520,18 +1502,12 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif, return ret; } -void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - const u8 *bssid, - bool update, - struct wcn36xx_hal_config_bss_params *bss); -void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - const u8 *bssid, - bool update, - struct wcn36xx_hal_config_bss_params *bss) +static void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update, + struct wcn36xx_hal_config_bss_params *bss) { struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif); @@ -1736,12 +1712,11 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn, return ret; } -int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif, - struct ieee80211_sta *sta, const u8 *bssid, - bool update); -int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif, - struct ieee80211_sta *sta, const u8 *bssid, - bool update) +static int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update) { struct wcn36xx_hal_config_bss_req_msg *msg; struct wcn36xx_hal_config_bss_params *bss;