From patchwork Mon Nov 2 11:23:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 315585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8AAC2D0A3 for ; Mon, 2 Nov 2020 11:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A43207C3 for ; Mon, 2 Nov 2020 11:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D6UrFCbN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbgKBL1h (ORCPT ); Mon, 2 Nov 2020 06:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728741AbgKBLYs (ORCPT ); Mon, 2 Nov 2020 06:24:48 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D498FC061A04 for ; Mon, 2 Nov 2020 03:24:47 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id n18so14133610wrs.5 for ; Mon, 02 Nov 2020 03:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=D6UrFCbNnbIMKjVgRasS/TVPF0VFgetQBPCgu22jy/5xPEaU/MeB37127gXhnJ2Q/v 9B8Dc/D11Iuhl9l0wkkX0tPQE/JYuxjYpSYoGoy7jy2VuYHuxGBU+JKVU3ezNh0d6F5L XQRJruZlUj2caVSprleh4QEvkGtsM4Bbz4qxkpPkQYLZzrkOPep5NdtrCCyNb68pNkk0 v/3Guv2tYwpyktPn0vilkm7u2eird8Zcx91kYjKNWNXW8efOmE9dlBCs97tfxwpsbZqm XR2EeJuKuB/yGHZiYgjMnQD14vwlRc9Z8sv/+5xPM2o6nUznn/MjCgolB3+x/LB5UcHM 4tSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=gujotsu+MUBdyOB36Pz6kxZ6RZ7JrIOjDCWXVxqNQilbafODy+wA1y1QzhCmZtIch/ uhgA07rGfbBnwRRgSye6X3JGogYEigS7dvsnWEv7KOUebg8ye3ofRWaCnjdADLUqYRzD Omcns0Fu3iAVcRQi8vac10x4WrehsaqqmnJm1h1pIfYWJsTJG7xIWtwT0SFoZ3SAJT/a KdS44P49rI+0w7DsVSSuzVz/PXkxanW12dTFyWcyfFJvKIIlPm3BjDIuEMO2v4oe/Ckr eYv7BJDEfLdZ+MWroiuG6UokeXorwmuG40/Ug+vG8Xq5xMcogbyUem+HLyFMLlAx3WL7 jL1g== X-Gm-Message-State: AOAM532ANtelW0vsGt5LWSIVX55bE69n86Q3j076rwUqbtmYoy2+ORta 08svqAtWEUbidUonxVEwaoCbaA== X-Google-Smtp-Source: ABdhPJz9zMcwVD2AX9EtfnH8vy23WmMsvpYeEmhm18hnzkcD7bKocVRmvzyBo2IqrL3PWlu2YTNv9w== X-Received: by 2002:adf:aad0:: with SMTP id i16mr19166015wrc.270.1604316286561; Mon, 02 Nov 2020 03:24:46 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:46 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 20/41] ath9k: ar5008_phy: Demote half completed function headers Date: Mon, 2 Nov 2020 11:23:49 +0000 Message-Id: <20201102112410.1049272-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'reg32' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'numBits' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'firstBit' not described in 'ar5008_hw_phy_modify_rx_buffer' Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index 2fa30834a88db..6610d76131fa8 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -102,13 +102,8 @@ static void ar5008_write_bank6(struct ath_hw *ah, unsigned int *writecnt) REGWRITE_BUFFER_FLUSH(ah); } -/** +/* * ar5008_hw_phy_modify_rx_buffer() - perform analog swizzling of parameters - * @rfbuf: - * @reg32: - * @numBits: - * @firstBit: - * @column: * * Performs analog "swizzling" of parameters into their location. * Used on external AR2133/AR5133 radios. @@ -198,10 +193,8 @@ static void ar5008_hw_force_bias(struct ath_hw *ah, u16 synth_freq) ar5008_write_bank6(ah, ®_writes); } -/** +/* * ar5008_hw_set_channel - tune to a channel on the external AR2133/AR5133 radios - * @ah: atheros hardware structure - * @chan: * * For the external AR2133/AR5133 radios, takes the MHz channel value and set * the channel value. Assumes writes enabled to analog bus and bank6 register @@ -430,10 +423,8 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah, REG_WRITE(ah, AR_PHY_MASK2_P_61_45, tmp_mask); } -/** +/* * ar5008_hw_spur_mitigate - convert baseband spur frequency for external radios - * @ah: atheros hardware structure - * @chan: * * For non single-chip solutions. Converts to baseband spur frequency given the * input channel frequency and compute register settings below.