From patchwork Mon Dec 28 16:28:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 352754 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp10027796ejs; Mon, 28 Dec 2020 08:27:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJydXm6LlxZWlmacrukrP20DuY59CAtx1a5S9mrpMKoX49t88RS+/XYNXlE04hH2ohyM5PHI X-Received: by 2002:a92:6d12:: with SMTP id i18mr44897690ilc.48.1609172862739; Mon, 28 Dec 2020 08:27:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609172862; cv=none; d=google.com; s=arc-20160816; b=dky+GiKph4AFp0R0gP3NTxYZnNSiisVlYjtogB0IdGSxnwNoXZoCXoNitFNPKXfOJB hO3QrzhunkcCxHXmjV/AJ3O8wZ4QdgmwKe8tcQlqoIPIIJNzOsO8qTnlMVTB9j5TbFXb TdON0pnx/vtZhXPb/B8uUFkUCGfcED1yG3JkKc79JbVTkJPCbmH9P/0Ao2HCbkyUQ3NI OpXa7ZDiQa1wzeb97rg04sO3u79lTnIrISuSrAroyGl8G6PIhekV9fnOAN9zDTV/jjh+ XVpvxqT6G6rYst3OkXzcregIaOjQ37jcF3VhHXmvnuWGhMzE7PL4bfw7yulRaCgu0ARM 8qlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=Z4O9CyDi1Ci+XLipXIM+elR8KtUS4hFEljeGaQym9Nw=; b=Ghe41PlEpuqsOrpRONJrBYoueUtNFvOAXHdRLAKNPbi2znamiEttkFx5ALRRXev435 7tedQ5Ij6cRJLH8lu9DhxdP4GdER2LtlmmRzJPxqkjtqt4Ne2FqztbBy875pBcpBKhn+ S5rDFPWrmtU4G+pJap6jcrXmtH7lEuL+UBnXAcOzi0Bf35YIHtsbpfH5RwoOfjk6I6PI Pm29fc8y8Vc9kpEQRnzO198UOneJze55ILjsPk3dZSMuA3P6/vO5t/OfNBz/BvJgj0Bv 3d0T7fVFvl0LEcFcFnLZ7L2ypov3GMJJt9ed/HNFRlHhAlpCpfsCg9akCKwNF5/zov18 efWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=rgQl9OQZ; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ohwfsIY9; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id l16si28288080jaj.31.2020.12.28.08.27.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 08:27:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=rgQl9OQZ; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ohwfsIY9; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z4O9CyDi1Ci+XLipXIM+elR8KtUS4hFEljeGaQym9Nw=; b=rgQl9OQZz0edadWobWnU0JvYb y2QbgKBVX+RsdBDdZLQPL9n/RhroyJ/2JRrxu3OU5LkUYATkgqWBZQSXIUpPZTDK45gK8NrWMgNIc o7QBP6ipN2/4+mLs2n/n8DtNbCCv47vC//op6CXTD5hszlaR1hzcbvq52yEkpS8kHs39KsXlRjnyb uzFAG+eUpBHYnK8ntPvvOytqgGHmFqCC49JBVk5f7oLzVHo5Rg2HdpgFos5XfVHhj8rwaGgAi4FJz U0rPJzGhwU/6FbH/ThBpIE3nxkeHEBLbM0rFCjj0tDX5g/YQJ7aEj+BaOKhMWhlaM0C5K4aKX6jGk uPn1eJXAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktvMv-0004Wy-GF; Mon, 28 Dec 2020 16:27:37 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktvMs-0004UG-4x for wcn36xx@lists.infradead.org; Mon, 28 Dec 2020 16:27:35 +0000 Received: by mail-wr1-x430.google.com with SMTP id r7so11757553wrc.5 for ; Mon, 28 Dec 2020 08:27:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=61/IO/ybk77sJ5G1Q4pxAhHWdP2licw/COCpz/eNPLI=; b=ohwfsIY91vM7KCpWo6qaIHvnnIEVW3ex02xQKCE0YWnD2g0f4y4fUHm3Ju3H/T2h7i PD7oGMW+5AHto7R1zbs0rGu3oV3P+f/Gn/RdCocp9jHIn/5OZik2dD6/0S6kC1ha7wHp k2951AzIgZs3f5+QdOH1wgKQsLXb+wWdwIV61arjejbVWnNJgBN2x73sFbCa9lbE8Ihu Z5CPXc3P9aQwZTu5+W5CE2xZ0e/FzaBUM+p8bx6vU/Gj1sAu4ljdElFCm+qkp6P9MqBi 00vy7szTobHGI4ZLvsFrabclDQjqc0tYpM6lPfuL07i62sWZ1OAvOFUByRxMVG4Q1qjK SvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=61/IO/ybk77sJ5G1Q4pxAhHWdP2licw/COCpz/eNPLI=; b=NOeaEjCeu6a6tCJFMwh8sLpkmlMAguaxxXqtmC0+Rgf7IBvnaCJuKf9xLEadw70Dhf 6vmV5dTVlFzKOAt3TbKsUIJYusXB/nZUf1E5IjfUWGntJJUuTQl2m0FNWbKE7lCq5s4h K96VakrUQleIq9l8dmKkjjdkiLgLapn5L36Vu+LJhUhiURz2GHJZ/gYnUBGt+kenIBpF fXvK5SeUPUqBaHRK35EjV8NpOh/0XYauDFqIh9v+MCREYosz+8+WitXACETgri+wjkib O2P41tnm6P13BZNlH8vARGW4wMHhNffMLPNVyYvO20aHBa2K0LpT32pqn7dXHidKvQzr AQqQ== X-Gm-Message-State: AOAM531fFNDPUTmR18yUoRt+NSBz/RKGI9N4HwW46kSIPjAycdYFIVbI /1nlaGNnI2JOB59HccrjwR5wzQ== X-Received: by 2002:a5d:660b:: with SMTP id n11mr51861229wru.407.1609172851213; Mon, 28 Dec 2020 08:27:31 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id w21sm19523379wmi.45.2020.12.28.08.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 08:27:30 -0800 (PST) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH 01/13] wcn36xx: Return result of set_power_params in suspend Date: Mon, 28 Dec 2020 16:28:27 +0000 Message-Id: <20201228162839.369156-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228162839.369156-1-bryan.odonoghue@linaro.org> References: <20201228162839.369156-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_112734_217637_38FD72D7 X-CRM114-Status: GOOD ( 12.04 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:430 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org, benl@squareup.com Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org wcn36xx_smd_set_power_params() can return an error. For the purposes of entering into suspend we need the suspend() function to trap and report errors up the stack. First step in this process is reporting the existing result code for wcn36xx_smd_set_power_params(). Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.29.2 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 5867bd9c2f64..a863a90232c9 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1091,12 +1091,14 @@ static int wcn36xx_sta_remove(struct ieee80211_hw *hw, static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) { struct wcn36xx *wcn = hw->priv; + int ret; wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); flush_workqueue(wcn->hal_ind_wq); - wcn36xx_smd_set_power_params(wcn, true); - return 0; + ret = wcn36xx_smd_set_power_params(wcn, true); + + return ret; } static int wcn36xx_resume(struct ieee80211_hw *hw)