From patchwork Fri Mar 19 16:15:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 404807 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1511040jai; Fri, 19 Mar 2021 09:13:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZLmaScgYDPDzZvKnccZghCDVnuTPBqsjwVW6JlYYKDpWWyN47QhlJQuhB8WTBozjHPy3c X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr4326760wma.141.1616170439546; Fri, 19 Mar 2021 09:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616170439; cv=none; d=google.com; s=arc-20160816; b=MhKA54sgRPUpuLmQVBJkgVqONf+h9YMvPZNYgb/NA6GwBjGBmseQv93Aw1ySq7PRR5 MT+CXaoHA09OpryOOJj3zAFGbdasxKfnSfk7mpid47lZZGGAtqktefMF/NrZ/eTJPTN7 ZpwEc62UmOArw7qAORUkPV+zsETos0Wrqh9/wFrxuvkIT6iRK5FmswU/UqIbWA3hmt8+ XRrg1j9KSajPq2+Va7PWQWGSdHrBw839vxr0kMBT97K8b5VrdDWX6BKaRHn/egG9ONxX nKL0ZZqpQtmqyBa0EP83+dwlMvXN06McFi7ghYs8k9d8pqdZZgrK7rCZLa9zL32ANS9K RURg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=Uhh6/zDuhVKLgIbB0ELzpssNRJSmxCYu2IUG+rFgHI0=; b=M9Le7tRrI++1wnuSuYLiZzp8Ckp4VhQiBpCn8CBULCrcwU34ujlWtWIWe86OTA+LAG EuSwEaxWdg4l77e477GeftzAgT22xr31Fo8r2n0kq6YML7y1J457sqcl2BYKeSamuES6 +BLcop3Trd3q8AxzEMFVlgyqE3suTsV89HlhQ2bXgCPdol1zyOjpUn0/L4utM6AoKS2Z 048ddLIY+CriBrZGCYK+VdDONL20I+owFgbp6gXQY/9YHXyVP+6LyC1Ar3ner0pAuiwN Y1XJi2O3hqMth3lBSOWL7lwDXE0EC7B+Q/Ek2VmummnlVljyGKKc9/cJMcuHV/unFqo3 Puyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b=aK1r4h4C; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AedZuECw; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from desiato.infradead.org (desiato.infradead.org. [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by mx.google.com with ESMTPS id q136si5838135wme.149.2021.03.19.09.13.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 09:13:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=desiato.20200630 header.b=aK1r4h4C; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AedZuECw; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1:d65d:64ff:fe57:4e05 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uhh6/zDuhVKLgIbB0ELzpssNRJSmxCYu2IUG+rFgHI0=; b=aK1r4h4CbAtCNXKNqZQ5Ekp2/ vMkY2YMBvaBGcy+DMPxaycpI6gcZdecBIFY2YI7+7ZmunUJymXA3vZWobmj1Wmuhk1/K70U1SboC5 Z7We3bNfHv27Pt9GMV/AlLtsjo8nzbNPxbR7x9M+4KWl+s5XlbxzeA9zblrSGTnuc3ylSuWvB/DWd vB7nOA1aAbwJN34sasmK+SUEViW96uYBjgaERp8+xX3yUDML9cbHFluBV5zqtRuLi0CR3/fkkwM20 f+OvnYEJl3AEGoV9tTjaNA2skOvHxn0qFKZcCEr71dLtIRxumMqCDm7xA9Ti17yMxW9sXy/DPuYr6 fIJPLalmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lNHl8-007foT-0H; Fri, 19 Mar 2021 16:13:58 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lNHl3-007fmp-UC for wcn36xx@lists.infradead.org; Fri, 19 Mar 2021 16:13:56 +0000 Received: by mail-wm1-x329.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso5569169wmi.0 for ; Fri, 19 Mar 2021 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NYk+e0v1fIIJdNtGGm5pPGaN1woGIuYcsbVccpj5KvM=; b=AedZuECwrE33A9fA14xe/DNOpQSLgC2xQd0+gzgZtl/EXoSdLBYT0E5lfUPXcsElFs ilctEP2k15ssyFmiSYbGwAxIQz1eYRO0cWJoMR8MW5mPTyrqLbKDC6wTcKksMV9TXLbU AZ9yNYJ5yVIP54nNEEEhd62iKsAiB1La7JDOmFV+yQvDmPing/dYR1nt+SaQ7zCuRBiK XCp9aiCh3QxsYRkOkdQ8pl2oVSLU5aiY4qChREh6vhj0i9Zqz2Zhrk9W4ptwRMR4X4xP dr9LTlMq9PAA8tZdr/j8UmH5ce3fahaUaBU26nQHyPJIXvNwfVp+XWgmUHD7wWYf2H/c m3Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NYk+e0v1fIIJdNtGGm5pPGaN1woGIuYcsbVccpj5KvM=; b=rOtWRJvcNxGbM/ashAVjOLAW9iKrne8mIXtYtrNOKPg9b9DLdFG0x19BwwhJqxWVjG Ai6uHV1uB1+8XmxZnNp/Br655oaMUMTYXnF2qi1iATkwq2Cwz6WJRzPVMeZgzfvdpPp0 PKkTi++joKUTW4t+pV4T0eccBfOUZdVRMTVYgyBl9TfJzkRxv0+MEmH02GVfwIaIHFLm L2VHhw4XM6NCKdUr2e+hqhQl0qWPCwJ47VvNGe1i7Zvfymuk25Mq/JnrZm6Nn6LQK1tY t7Sl2dkTBko1GpcOVqjOyTcVmZrnTs5XiTHIKJID0RgCwnMGI/sZe+NLUf21xBJ7nj2j wdHg== X-Gm-Message-State: AOAM533ygZyJejn3lBZIZF3mCFnwbe8BetyWzl1/NpNBIqeEEpBto4ci /JJVNaKWx0U1NCMAnqDmme/M370nNM/hVcgL X-Received: by 2002:a1c:65c2:: with SMTP id z185mr4468920wmb.2.1616170432596; Fri, 19 Mar 2021 09:13:52 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id h8sm8432495wrt.94.2021.03.19.09.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 09:13:52 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org, bjorn.andersson@linaro.org Subject: [PATCH v3 01/12] wcn36xx: Return result of set_power_params in suspend Date: Fri, 19 Mar 2021 16:15:09 +0000 Message-Id: <20210319161520.3590510-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210319161520.3590510-1-bryan.odonoghue@linaro.org> References: <20210319161520.3590510-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_161354_060510_666A9448 X-CRM114-Status: GOOD ( 11.48 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: wcn36xx_smd_set_power_params() can return an error. For the purposes of entering into suspend we need the suspend() function to trap and report errors up the stack. First step in this process is reporting the existing result code for wcn36xx_smd_set_power_params(). Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:329 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org wcn36xx_smd_set_power_params() can return an error. For the purposes of entering into suspend we need the suspend() function to trap and report errors up the stack. First step in this process is reporting the existing result code for wcn36xx_smd_set_power_params(). Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.30.1 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index afb4877eaad8..b361e40697a6 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1091,12 +1091,14 @@ static int wcn36xx_sta_remove(struct ieee80211_hw *hw, static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) { struct wcn36xx *wcn = hw->priv; + int ret; wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); flush_workqueue(wcn->hal_ind_wq); - wcn36xx_smd_set_power_params(wcn, true); - return 0; + ret = wcn36xx_smd_set_power_params(wcn, true); + + return ret; } static int wcn36xx_resume(struct ieee80211_hw *hw)