From patchwork Fri Sep 10 16:04:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 509046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF94FC433FE for ; Fri, 10 Sep 2021 16:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 951FA61205 for ; Fri, 10 Sep 2021 16:08:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233209AbhIJQJM (ORCPT ); Fri, 10 Sep 2021 12:09:12 -0400 Received: from mail-mw2nam10on2058.outbound.protection.outlook.com ([40.107.94.58]:51435 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230010AbhIJQIQ (ORCPT ); Fri, 10 Sep 2021 12:08:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSq7hpQcsEwT0n7VgGC1GbPIXzirulYpvS7JoIF1S8iW8atmuGZYW6XfuOWwx7JFOBWKfxwTasUVWeP2Fd6xDNtQtCBzRa2z7iQGEGSm6+SdBXsrm64g/zDATOaJG4vBw5XpBOlJffyRxOjJthCeSS9EDgQqsb9C6GNz2EsB+INK7UNzOWwZBu34z0Uh/IPqADciKTdWrFFODwm4QoFaH3kNlHVtSqu5W/hyoam8agzRuuLaLFXaoNPNErdV+EUI5Dw2Mua9jqi1z8qBCdEWusDljpbctnhcRd79GGOccAeP8jh0aRGCD/6lcTRuAI4dIsdAyx6M1DDXdoUTXbdqHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=jLdGk0AJDq77llqS7a/TBjNdllPyz9qfRomY/e8MXOFZx3RyDZZ8dy4ylJurtq3Q3V5tiI/8MFV3NA3XRIea3wq3QnoOHf/ADjCeZRj2RK6rNQETQtDkfatdKA8kuBM3pHazT1PL2l75HonE+buGpSysDbHHL4KPF9Uzibs8obAb+4LTas146b4X3GA+ItxpCHiy5EaOCHUvIYRHHR1DBVuADmEet0wlbZmyI9mgXbFcWU6MzkVWhCFfr1n7rghCMuS1I0AySk9ynFspoePtXXJ7fGzNoylRJGOt6kTZdqCb44Ivu0EiYwrQIzx3SSKj1pV2PRsxLJnVEgBzdKw5MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=gsLrxpUHFqg2CrYApSab9nFuEtCAmmLYnO2xuEB1O+voI3reLf2wZbdUk/LT3Uk3aNAzBs7sTZmjQiVjuaNk0jsEKKzW895jkaGTmenUnyv1HKPeiQtoipMED6e8fd9dfVMbIe8uODBkOeFKuNctAWnZnYsKJiTFULcVJlcum94= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA2PR11MB5002.namprd11.prod.outlook.com (2603:10b6:806:fb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Fri, 10 Sep 2021 16:06:14 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 16:06:14 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 22/31] staging: wfx: remove useless debug statement Date: Fri, 10 Sep 2021 18:04:55 +0200 Message-Id: <20210910160504.1794332-23-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> References: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (2a01:e34:ecb5:66a0:9876:e1d7:65be:d294) by SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Fri, 10 Sep 2021 16:06:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5bfbb32-33ef-4e3d-77ea-08d97474ea25 X-MS-TrafficTypeDiagnostic: SA2PR11MB5002: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cKsiSgGAELKwg1S4iwg+VTRbu8RsSJRqFH6ZNP/0uV4b49k/yjlNkjSqCJnJ27cVX2ra3N1VK93hjWLYt25FlhYlTZRgpxrxJjO9BPmmuCmfhGNG9wPhPLsYfgxpp1iMiq9lVtCJfwiCo0qlQPD73XDEYqZSJF9aUgLvfsif2cw/8cHPtXf5RG6nkpZTPuy4WD5p+YtZffCW49NV6QvXzhaPSpgOckcZUcgvmfSE9eNJz8U5Ip5+vfjHrOkzdNNjf/li7CuzOKBHLaiWk5oSoBijCi2q8sHT0XuwGvnz+wjE6WzTJB3WnY+M3eED23I8fvyVSMfiddBVIoQax6xEcoF9628Zu1U4tII+ZKLgrPdR5Y+ub0sVI3Ml41ZMbm/3KOnPDOIBbavwcH2/7Y8upZuJOKlDKtLBT8AEbG+J9pU9wVROGKxazv2iFY1NaQq8rvtHecIhKqYdZA5h0ir/VWqhN4RTJrJnCAJD/mMhitY3YZw7o4UOeAj115n51z18ESaaTDyaQI0bH5DINxCbMq+dhN6Qj6obwqPw7p0b43z8w29qAoUuVqpRCdUDphxLxtYJOzP7ZZaHYoyQHiJ5ccvLMEVf2aZwWB9AUuNlDpYaUndpvoz0d7qpKjmaAAWaRgAJ3/Hxj2Z4NQrvweVrYg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(52116002)(86362001)(38100700002)(8936002)(186003)(66574015)(7696005)(4326008)(508600001)(8676002)(4744005)(36756003)(2616005)(6666004)(66556008)(316002)(66476007)(83380400001)(54906003)(66946007)(2906002)(1076003)(107886003)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HZnU2iX/my+1e9NNuDexEgu7x?= =?utf-8?q?pl0vM3zTXtXl5UAGg+YoDmT9+aHTzo2n/bjXOw4ouCqbhVsNVnAXUDoG?= =?utf-8?q?OvrcHdToNU9upWGhjhGtwgTrdqk5hi6RtD6m4k5MQfLRruWgVo6Ed+z+?= =?utf-8?q?K3rixY822/rp4AXkP17YtB2RwQKLiieMYv57i4gDUo2zfWY9jwrcbh0G?= =?utf-8?q?FxKKeJYr1R8ibYVUhJLmQx3woZxELWSMksoCYOn1eNcJX8yLt3kV/bC4?= =?utf-8?q?GSdomBN6LPKqZc8ilSSYlg25XRrusXEnNYga07Fbnz3MaXyn8L5+8cQA?= =?utf-8?q?tQnZlS2EzER+zM3E8B01kZ7LP1eFlLhUddB3W6Yg2SzG6oD23hDkvYHQ?= =?utf-8?q?48Hw2f5DCGFdgYsKA8hcBGGXf2qDvB4Jyq9RcH/6mIQDNQPbomBvvJAQ?= =?utf-8?q?VoI3p1gpdD8M7r+86U6BxUt1/PGi1kAr9D7zjwGTI5VFVNOLd9gTbVwj?= =?utf-8?q?XWDOdL3Buhp88zkxls5ZfPswmXJWEQ5qPpiukx/kw8QgBU20tNAVVb3V?= =?utf-8?q?HyfS6isv7jzojsJghxG/OxFh2yX5ztGivIQPXO5cH0wbJjPry3P2TKmH?= =?utf-8?q?Wty7dX/ljQ1R43iEMn+oE30IhPRfJ4l/MynPBK7F79z4Vmeoqr7Dij6a?= =?utf-8?q?MGY2sx1tgBg2c0Vx8LbDz8R/oLCDX3YkfdcWtLw1lBhj9MBxXwAYpK4J?= =?utf-8?q?YURRJ45Wj9rg6sVmDEJGrUoTEDRRxpvJ/6eggHaIMGb55SVMBNif0Yu5?= =?utf-8?q?56HRi5VMDCvV/fser6X5BM7heHdxwjQr+TKaxIGQ+N76pQxhlCRlvbUO?= =?utf-8?q?KWKKJK3Xf/mMNviac+4uwJIpQm9fYL553LeZrHV5r5N8bBprvRynR6n2?= =?utf-8?q?s+p+HGjJaNM774gTK4ODkiui81tYdTR8mwS6RsooVDUILfpsKm76Adwb?= =?utf-8?q?fWRx9cnZLv+VRl4PRMqCYLpaAqrGtJm9GeZzn9puUGXoEyCfsj5+ES+T?= =?utf-8?q?QfMZZhAwnEaF8dvKEOzCiK/3mP9/oca9s5fo7n0yqvDWuGGRmLij7wzs?= =?utf-8?q?l6oerqctD+qY3Pr44e+0rUFIYAAPFzmRG5zmUnkWAxLr3tGZ+VW1Z9aI?= =?utf-8?q?6IVhnM/lYo8xtsj49k642b8KjyAeYVl79BjYY3FE7zNxInIg8oJjBlPd?= =?utf-8?q?3krgXDHUeVeY4buWtA2bbYJR+4KHqobSa+gE+LY0xTDfGZaLAZ/3gows?= =?utf-8?q?joHwTkAho1M3u9wPLQak2BnXyKUaykM2aVjKnQ6ogMM2apsCxBuialBj?= =?utf-8?q?3nL5PgdDZUIOR+ciynMMFzINwxw9QpLK/lGzdZXStqwkDdmvKa2REmt2?= =?utf-8?q?tk0mAnkzapZ9CvyBuboJSCb5tCam9BvmUHTi2Zy/Adc2Xox0Zy1hYrKO?= =?utf-8?q?0XsNeUm/DXbb5ZRa/zXAlORHv3CiWDU56bvB3Xh?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5bfbb32-33ef-4e3d-77ea-08d97474ea25 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 16:06:14.5486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AynfuWgmioOHnIMmoQwP4rWJRDXednZhVNZxu31ki0LA/gofcovRxAPsmW0olG48qV8VqpidWtQ2S8E4rlFaOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5002 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller In the early age, it was unexpected to access a VIF that did not exist. With current code, this happens frequently. Having a trace associated on this event brings absolutely no informations. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wfx.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 56f1e4bb0b57..a8efa25a38ac 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -99,11 +99,8 @@ static inline struct wfx_vif *wdev_to_wvif(struct wfx_dev *wdev, int vif_id) return NULL; } vif_id = array_index_nospec(vif_id, ARRAY_SIZE(wdev->vif)); - if (!wdev->vif[vif_id]) { - dev_dbg(wdev->dev, "requesting non-allocated vif: %d\n", - vif_id); + if (!wdev->vif[vif_id]) return NULL; - } return (struct wfx_vif *) wdev->vif[vif_id]->drv_priv; }