From patchwork Mon Sep 13 08:30:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA93C433EF for ; Mon, 13 Sep 2021 08:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA68C60F46 for ; Mon, 13 Sep 2021 08:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238227AbhIMIdj (ORCPT ); Mon, 13 Sep 2021 04:33:39 -0400 Received: from mail-mw2nam08on2066.outbound.protection.outlook.com ([40.107.101.66]:47168 "EHLO NAM04-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238153AbhIMIdP (ORCPT ); Mon, 13 Sep 2021 04:33:15 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dNLBxbZampHeIvpKS4gt6Sf5zdnCyIPOZ+fFhLxpRW+7H5aLf7VMnHwbN9ENfqfg0NQ/uFanCw7dPTU+pXgdGyMgoEveR6ashI5HotZzR1cAzp9BcicreDs8aMvRzW/RZvDDlinGlXDhajAABp1aGWhEzkXFb5l2/I6XDoa3ylxRL4k/aYVHvQ/+8lMMi0TKyX2B/xeoO32BUdzYb5wKKFbANTMPKJpElw3902Rqr7RO4N99H4oE24P6Gl0Fp1BYWJLk0CCMaJoZvsrjSzrVA2tG8Aqj/oxSu9BbhFBRrSWbAFxNhBm/oEWY3M8j4poSUG2MpmXAaljyr2Vdfa85CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=Iv5sb7jRxTUY6DW38gcuIaBnoIxhYrCv66hUu3G2JGf0QpkiIgTwByBBHKhSSMhZ10yemEfGAjuD5pOkIiubsI+MI6WIC67+RaU2agEfINj6f1cnxn53yhlUB1tFmnmUOMpUmsZdVOHWRwDNl3ENP61YYEpLlSHxkc3ubeIBZ5rEt5OBNoZpXL83VsMRURvFmR5hLY88pmbuT1GBVVqlkH4ObJK3wwpkM6wYmKYtpTrgwOjgqmljTXF+TnzBQyb21zgglIbJEyYseJ5H7oONID54/2pbm64IAT9KOGFhNEXQIjIJBiKJFJMlZvfMEwuFLxhyzG93dX0U18B1EsQ4pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=eEOUXY4cn6IQoinINZWs+KYsa39Up77a7R2kojTKjrShbjLuB5S/nyXmBXOuvAqHGJiLrb77dsw8il5hrGOxo3QVKSESId+T4kmb1DhU3++VxxoGmp8MCpOtgDn+5yl6L8qnOsq0NffQby6UgDy/lFDEiCVnfds/NVB9A43U7dE= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SN6PR11MB2717.namprd11.prod.outlook.com (2603:10b6:805:60::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Mon, 13 Sep 2021 08:31:58 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 08:31:58 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 22/33] staging: wfx: remove useless debug statement Date: Mon, 13 Sep 2021 10:30:34 +0200 Message-Id: <20210913083045.1881321-23-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> References: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 08:31:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71a2b5c4-c658-417c-6d4d-08d97690eac4 X-MS-TrafficTypeDiagnostic: SN6PR11MB2717: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jloJ/QYivMXd0Vi4neUJCfGLltLma3FYGo1yXlER5JZYVzUuT+bE5QslZ7HzmU0SdNCsGO1gGHQypWhuVyHKuH8l7aUbV+tA/TCuteEqLSe0/oamibucAKV36n49y/ssP/R5zdxQE8++HsYNvlIvhK1tm/TNbhCMEw+/da4WWESg4QzBpvBTsrV7qgCHb8sK4hUzsAgOetSAVyC0JQ3vKqOeqV1m5xlZdNXc9jVqb8unwlWt28Cs3qabutT1qUUh8PohUCiN5oottwQXoGXTe+xzvE93/avt52j43eN/MUytGud0r1SFH4eGjF4cxmXstFICJYW+GMsXXzejop3qBrwYO5HefzlYG5LpYLIJzt0WHgpAkleAO3f2km21F+V6X1sYLXQKKF4x+SvM6/G2d7+Ve09JRkmYUIxjKetRueh/C4Z4z3s2F/yf6qBrdSirc4wKuu5uAzno8Gk433k6VvceJLiX7/JeFuhwXG814rQe6kb7PNLLeSoJ143cU8+gLPKlaNYEeMMtmzHYj4U5xY3pCzBNE1Dl2apx1Vd0s6MG1RlgAvSVLvS8EjLeRUqcT8RUZ5RYuPnBjvcuEfoB2K9LdYKoBJsuonX8ja9zqoGmqGIWC1kfyYGvRiyPNLbd7O8jdyUHO49nLQlX5c6ttpA6nI92eP3gJ4HG0XLQDus7D5peWOm8pDpEV2TLd70yhjHXdx90woHDTGKIKiLBpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(2906002)(107886003)(26005)(66946007)(38100700002)(52116002)(7696005)(1076003)(956004)(36756003)(316002)(8676002)(38350700002)(186003)(8936002)(83380400001)(54906003)(66556008)(66476007)(508600001)(6486002)(5660300002)(6666004)(86362001)(2616005)(4744005)(66574015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5qu8pCWQTLNOIIXWbC9NrFNO1?= =?utf-8?q?Ue3n9YRgrlZGUSyhDQfO08TZKeSokrplmDak6o0GPL5G5C7W+dTIFQv7?= =?utf-8?q?RCO+d7OkLBGO2X4V/UnE6Ijopd3rSujZITJ3B8se/Umtlu/ds3NMcX8d?= =?utf-8?q?WcLvnisI16SNgM2vwhGeOL2Szb3sW6KjuqRT7OhWO3RjtviY6UM1ADfa?= =?utf-8?q?m5rYFaIxns7zaPURR/KU97HTNiS7ZDX0kLJBFL5Bf4ELOXkPuMltXBYJ?= =?utf-8?q?rlYWkIN7WzKlx+3qDsTZAgXHLXVOY9KUKhQPhNK/rKRCt6QqjcGUWwEn?= =?utf-8?q?y1CiJzMsRkEKTkG4C39kuBFU0bb+Em0CWTMqMPxgoXjUqjktzjFuKI56?= =?utf-8?q?UuIH+rnIbRcKndDcEbtNOpaIkc5GTF8bP7NBPZd1lOfrpA09QgaIwNrt?= =?utf-8?q?tuLhwD9nbDRVki8XSX8JPlZjqz8cCOT7yPItt0Zt73fjlNWI915Ng+TD?= =?utf-8?q?eQkIOP6y9sP67Dh4CBVDcQbZ1eWpERypCFk6tkJ3BjmUjQDX+pcfiflb?= =?utf-8?q?+UaTza98SOhjOEBcd0HiE/8rpucxF3D/wNWk0CivQAUCWYp2etv+erBD?= =?utf-8?q?+cSmm/u+KwPjMWaAuvWraWvxaoCxCDP5L8pHMHgLe3IA1IYalGzI4SeJ?= =?utf-8?q?+7jnYLl4Jq7prrY14hyytINr0gFzBagBhkaWEgdHkoCh6QA/x0WSfw53?= =?utf-8?q?0Apy6a6PRS4zq5UFbXEr0u2rdaXveeWk6vwtkqCBLH2EuG3r48kCnRzn?= =?utf-8?q?UAFqWi9wOWqLzv7m45Pmq9Ct+Gy9dBc573EQ4Owv4G8lcbYpH4zjREgB?= =?utf-8?q?icJggtqryYNN3YzWC5d3zpg24vXrYxpA/e2BdNg7UuXrPntk98Edk+89?= =?utf-8?q?q5ibaqjp7gA7EYXPJgc9rLO61AtNv4e/U0IDkG3Nxgt8VFd8aGXC5n4y?= =?utf-8?q?6cOtwK1s22e4pU+U1VZaeZnohgkk9VKD1O3uoVE4/fSNxjXo2H4zk2lR?= =?utf-8?q?+J6kEVZLA7NBtARKHHh9HYrl2gMGyTgYcGkBRdfDXaZQ05sfRiknpTyI?= =?utf-8?q?oNoON58DvQJ4/rfJnL/2l8rsD1o+2WsgwqvhVG9xKlKD3y2wcp1mHra1?= =?utf-8?q?tdxvf33/9/FWwSb6aNkKD+WF/8N2N0umZwt/86HwRdOgsX1h4jBz8mpj?= =?utf-8?q?qxoPV95VHeL9H340qgekMyV9lIVNDJ9L2a4LtkcDArng3M/nQI3L2lfb?= =?utf-8?q?20cUxfTrehI/w+qdyw5rQt+oUbuzm3frhxpc0cwkWnBcTF3fVBUfHSuz?= =?utf-8?q?6lWj7XHbo6yqpRVcRR5p2+kslHPhAfx0fafJDy0oG46uiI1PiysneGVE?= =?utf-8?q?TrBPSUHivFnBKvixyrKaDX4NYloGeOT?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71a2b5c4-c658-417c-6d4d-08d97690eac4 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:43.8344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +h3758FUe99H5ehoPy5NldOMi60bkqioFzNuuDjoVtyd+UXPnON6cIfpz9NGwTu3hV3VRcYBVtoOsKAvSyxf+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2717 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller In the early age, it was unexpected to access a VIF that did not exist. With current code, this happens frequently. Having a trace associated on this event brings absolutely no informations. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wfx.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 56f1e4bb0b57..a8efa25a38ac 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -99,11 +99,8 @@ static inline struct wfx_vif *wdev_to_wvif(struct wfx_dev *wdev, int vif_id) return NULL; } vif_id = array_index_nospec(vif_id, ARRAY_SIZE(wdev->vif)); - if (!wdev->vif[vif_id]) { - dev_dbg(wdev->dev, "requesting non-allocated vif: %d\n", - vif_id); + if (!wdev->vif[vif_id]) return NULL; - } return (struct wfx_vif *) wdev->vif[vif_id]->drv_priv; }