From patchwork Fri May 20 18:45:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 576897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314ADC433F5 for ; Fri, 20 May 2022 18:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352950AbiETSrf (ORCPT ); Fri, 20 May 2022 14:47:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352935AbiETSrd (ORCPT ); Fri, 20 May 2022 14:47:33 -0400 Received: from p-impout002.msg.pkvw.co.charter.net (p-impout002aa.msg.pkvw.co.charter.net [47.43.26.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC329132751 for ; Fri, 20 May 2022 11:47:32 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com.com ([24.31.246.181]) by cmsmtp with ESMTP id s7dFnjjoIFl1es7dQnBCYZ; Fri, 20 May 2022 18:46:01 +0000 X-Authority-Analysis: v=2.4 cv=EpDBEAQA c=1 sm=1 tr=0 ts=6287e1e9 a=cAe/7qmlxnd6JlJqP68I9A==:117 a=cAe/7qmlxnd6JlJqP68I9A==:17 a=yQdBAQUQAAAA:8 a=GTDKvHI3U8AOy6iqAGgA:9 a=SzazLyfi1tnkUD6oumHU:22 From: Larry Finger To: Kalle Valo Cc: Johannes Berg , linux-wireless@vger.kernel.org, Larry Finger , Ping-Ke Shih Subject: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Date: Fri, 20 May 2022 13:45:25 -0500 Message-Id: <20220520184528.4078-2-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220520184528.4078-1-Larry.Finger@lwfinger.net> References: <20220520184528.4078-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfB2BPp870NwGJvhiDPgUVrf3PKe8iiv09QDltWJb6pg296in77esuLV70Nkldy2hSG13RonDyFn4viiAlDnYIaBs+uqJWytwGQXZfzfzU6ShtOwJ2tB7 neoes8Yth4Ij8zc7xLUUpw2c4FauQ4srUN4m9VRrPF68qL3SslGpBafdmBF0JkdSV6PAsWR70S6VVPwWyu4AGbUmJ5fY9UEI3YlK11uU4KIhaQTC8KvMqtM7 gbfhqcKeWkNUItKwyXokhuX+npdaLDyIOP4E2e4ucSXvGlBCMiadFTDC3+EOt+uR5CsZHrqtjazAtFENx5MshADaS1dgmrthO6++/FUQfF9JnYJv4l2HbIPP gHl5Vhi99hwbxCN7xCyC7uIvJIYx96IoU4YHWoiZQROQul2yUD0= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sparse lists the following for rtw88: CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static? Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c index dccd722b8e62..60c4e75df035 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = { [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0}, }; -struct rtw_chip_info rtw8822b_hw_spec = { +static struct rtw_chip_info rtw8822b_hw_spec = { .ops = &rtw8822b_ops, .id = RTW_CHIP_TYPE_8822B, .fw_name = "rtw88/rtw8822b_fw.bin",