diff mbox series

[v2] mac80211: fix mesh airtime link metric estimating

Message ID 20220701133611.544-1-quic_adisi@quicinc.com
State New
Headers show
Series [v2] mac80211: fix mesh airtime link metric estimating | expand

Commit Message

Aditya Kumar Singh July 1, 2022, 1:36 p.m. UTC
ieee80211s_update_metric function uses sta_set_rate_info_tx
function to get struct rate_info data from ieee80211_tx_rate
struct, present in ieee80211_sta->deflink.tx_stats. However,
drivers can skip tx rate calculation by setting rate idx as 
-1. Such drivers provides rate_info directly and hence
ieee80211s metric is updated incorrectly since ieee80211_tx_rate
has inconsistent data.

Add fix to use rate_info directly if present instead of
sta_set_rate_info_tx for updating ieee80211s metric.

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
v2: * Rebased to latest HEAD
    * Considered changes due to 44fa75f207d8 ("mac80211: extend
      current rate control tx status API") and the MLO work
 net/mac80211/mesh_hwmp.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

base-commit: 8d70f33ed7207e82e51d5a4436c8ba2268a83b14
diff mbox series


diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index 58ebdcd69d05..2cb6dc84ac38 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -310,7 +310,12 @@  void ieee80211s_update_metric(struct ieee80211_local *local,
-	sta_set_rate_info_tx(sta, &sta->deflink.tx_stats.last_rate, &rinfo);
+	/* use rate info set by the driver directly if present */
+	if (st->n_rates)
+		rinfo = sta->deflink.tx_stats.last_rate_info;
+	else
+		sta_set_rate_info_tx(sta, &sta->deflink.tx_stats.last_rate, &rinfo);