diff mbox series

[08/10] wifi: mt76: connac: add more starec command tags

Message ID 20221031164000.17063-9-shayne.chen@mediatek.com
State Superseded
Headers show
Series Add driver for MediaTek Wi-Fi 7 devices | expand

Commit Message

Shayne Chen Oct. 31, 2022, 4:39 p.m. UTC
Add starec tags which will be used in new chipset.
This is a preliminary patch to add mt7996 chipset support.

Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lorenzo Bianconi Nov. 9, 2022, 12:03 p.m. UTC | #1
> Add starec tags which will be used in new chipset.
> This is a preliminary patch to add mt7996 chipset support.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index ed1d24822c37..336c20fcc8dc 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -791,6 +791,8 @@ enum {
>  	STA_REC_PHY = 0x15,
>  	STA_REC_HE_6G = 0x17,
>  	STA_REC_HE_V2 = 0x19,
> +	STA_REC_HDRT = 0x28,
> +	STA_REC_HDR_TRANS = 0x2B,
>  	STA_REC_MAX_NUM
>  };

I guess this patch does not apply cleanly.

Regards,
Lorenzo

>  
> -- 
> 2.25.1
>
Lorenzo Bianconi Nov. 9, 2022, 12:23 p.m. UTC | #2
> > Add starec tags which will be used in new chipset.
> > This is a preliminary patch to add mt7996 chipset support.
> > 
> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > index ed1d24822c37..336c20fcc8dc 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > @@ -791,6 +791,8 @@ enum {
> >  	STA_REC_PHY = 0x15,
> >  	STA_REC_HE_6G = 0x17,
> >  	STA_REC_HE_V2 = 0x19,
> > +	STA_REC_HDRT = 0x28,
> > +	STA_REC_HDR_TRANS = 0x2B,
> >  	STA_REC_MAX_NUM
> >  };
> 
> I guess this patch does not apply cleanly.
> 
> Regards,
> Lorenzo
> 
> >  
> > -- 
> > 2.25.1
> > 

I guess I am missing sta_rec_he_v2 structure definition. Is it already upstream
or have you missed it?

Regards,
Lorenzo
Shayne Chen Nov. 9, 2022, 12:46 p.m. UTC | #3
On Wed, 2022-11-09 at 13:23 +0100, Lorenzo Bianconi wrote:
> > > Add starec tags which will be used in new chipset.
> > > This is a preliminary patch to add mt7996 chipset support.
> > > 
> > > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> > > ---
> > >  drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > index ed1d24822c37..336c20fcc8dc 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > > @@ -791,6 +791,8 @@ enum {
> > >  	STA_REC_PHY = 0x15,
> > >  	STA_REC_HE_6G = 0x17,
> > >  	STA_REC_HE_V2 = 0x19,
> > > +	STA_REC_HDRT = 0x28,
> > > +	STA_REC_HDR_TRANS = 0x2B,
> > >  	STA_REC_MAX_NUM
> > >  };
> > 
> > I guess this patch does not apply cleanly.
> > 
> > Regards,
> > Lorenzo
> > 
Hi Lore,

The series is already rebased on top of this patch:

https://patchwork.kernel.org/project/linux-wireless/patch/85b5e8374fc9b86fb955060c1840f3b2a1d187e4.1666614616.git.deren.wu@mediatek.com/

I'll mention this in v2.

Thanks,
Shayne
> > >  
> > > -- 
> > > 2.25.1
> > > 
> 
> I guess I am missing sta_rec_he_v2 structure definition. Is it
> already upstream
> or have you missed it?
> 
> Regards,
> Lorenzo
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
index ed1d24822c37..336c20fcc8dc 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
@@ -791,6 +791,8 @@  enum {
 	STA_REC_PHY = 0x15,
 	STA_REC_HE_6G = 0x17,
 	STA_REC_HE_V2 = 0x19,
+	STA_REC_HDRT = 0x28,
+	STA_REC_HDR_TRANS = 0x2B,
 	STA_REC_MAX_NUM
 };