From patchwork Mon Aug 7 15:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 712335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FABC04A6A for ; Mon, 7 Aug 2023 15:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbjHGPGP (ORCPT ); Mon, 7 Aug 2023 11:06:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjHGPGM (ORCPT ); Mon, 7 Aug 2023 11:06:12 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 663ED10DE; Mon, 7 Aug 2023 08:06:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fi30Wghu3SgpJ5f2U8EgcK8bQ5GibSLNDGc1lY2tpahlXKLbyTcsx6Ib3qyWj6vmumDoxnbJckFj2bKhQAkxBtCB3v0whqRBFmyxoCpH0SB8W94hkJY3BxZDmCV6wDPYteEWddmaDkKY4pqOxvbfJi0DzEvfMOb6MZVuTFS3Gu+NG8SLImGrhpRH5eWJ8WSCPd9Lxy61RornRFwT+rB9+aOdELLREEmaUE2MeRxZctbEQ54bVUXVngMY4SlnBzuNS2OqlKi8yiKw/lPItgcuTHEYHNF36Idbn1HddmXOWvplcHxF9XEyhTWeHZ6Eva7Q9ScfPzebFbLqH/E7UtwhPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjGVnnI4IgQWVESipP4NJkbr9TxmMmdc9cZT7TgzWTk=; b=g7nuk51Cj3N/Y7vq2DaY4SdSG/23CcxI5iAitVUOJaBFw5MuQTFryqNV2YLPQ2d22DP5C3nWV1BrBGoxsD9XTY8Z2s7Kdq+/gVPHiG5JzaI8ykUEw0I4p3NMULldHIr0Uff99zTNRhHPgtw5Ry6+FrDw2+WGCuqnRo/+kd9WGYembyCWPmZAYJRHpHI9KrxCANh0nyxvqBku4fUjYLJM6WKiD+e/RtSZIfe74eB2BCtiB1mbN5gX3zjUiGy3YmEL52QKExKsYVAoQ8lKShmc65JIQa7tr0MVfCzRvfLB3MXapg82C3hghXx2dLKwM/wMoFEVEQ0NLM0Bmh0bCOJYoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjGVnnI4IgQWVESipP4NJkbr9TxmMmdc9cZT7TgzWTk=; b=VrwpgkTYg3dKtdW70CC8HmLnsYuTIgdCol9t3bl3MJ2fzkDFtwpd6I6BbljSjGPiDSiVGaZUQ4NfASKtkll17/ftvBgR+zJ9GZv73ugTqswBSIPAqr8uVFlXD0Vn9JW/kAX2vIkPhsqBdlE4neUJa5CdndFqkbO8Q+2cLn8WtMQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from IA1PR11MB7773.namprd11.prod.outlook.com (2603:10b6:208:3f0::21) by SN7PR11MB7590.namprd11.prod.outlook.com (2603:10b6:806:348::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 15:06:06 +0000 Received: from IA1PR11MB7773.namprd11.prod.outlook.com ([fe80::14b1:be6e:19a3:2eca]) by IA1PR11MB7773.namprd11.prod.outlook.com ([fe80::14b1:be6e:19a3:2eca%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 15:06:06 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 3/9] wifi: wfx: move wfx_skb_*() out of the header file Date: Mon, 7 Aug 2023 17:05:36 +0200 Message-Id: <20230807150542.247801-4-jerome.pouiller@silabs.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230807150542.247801-1-jerome.pouiller@silabs.com> References: <20230807150542.247801-1-jerome.pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0252.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::24) To IA1PR11MB7773.namprd11.prod.outlook.com (2603:10b6:208:3f0::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7773:EE_|SN7PR11MB7590:EE_ X-MS-Office365-Filtering-Correlation-Id: 74570109-ed36-44bc-3170-08db9757d2f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JG/+SZcRRnPXCR9bkPacmUfVJcLYxe3RJqcjuFWBaoCmNflH0avMsA8UJb7+D6uXds5O2m5yyzFRbgBajz/4hrhjg3O3+SYILDi4hiiTrQWXkZl5LwFYvd0Z9M8KMDIDv6tjkkMdFbmi8JgmW8IBacN0V2hVLVDqR2tiCCzkitubHGN+tpv96H+baHcavc9nofKWfJ6MvjuCghEUNbAQ3vNspFRv7ww5euKFtAeq2n4t8W3Vf+lkwr7BiTFX0eFziNV1ILDsLokwx1Q8XhfroFjaHa8I85C3pPo85wK/3LZzD+zU3WYGebiKyNG7JLvadYRVKiW2T2guoFo8C8zT2F16FiuQtR7fh4R9vF2qfJz4dPC21AHR8tKGh2pk/NImBlO487TaiwILAnhAeZ9Kxa/+AO5cJnBBmMTBJFBsFs6KAZIirDgT/hqYAsaBGwQ4T+Sgu5cbQnMLCAiulO0dKIpHf8ZCGNEoCk/TpI891H4nhV6/It9wDExrkbrYcD1d6AE8fiXAR1bgXfz7GXNY6H3ASEF/XbZmPsFlre2HIEAFB331xDnTfX5mRmPrCzKNgY0s+qGbZ/l3zue2+CH26CBEePUIbASXs33boJIu/vOxhdTOMmSXg/dfhbCAQPW7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB7773.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39850400004)(376002)(346002)(396003)(366004)(451199021)(1800799003)(186006)(2906002)(4326008)(6916009)(66556008)(66476007)(66946007)(6486002)(52116002)(6666004)(66574015)(83380400001)(5660300002)(41300700001)(8936002)(316002)(8676002)(38350700002)(38100700002)(2616005)(478600001)(36756003)(107886003)(26005)(6506007)(1076003)(86362001)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WBNTorANW3pLqHbOcX8DDXX2tn7l?= =?utf-8?q?f4FMHqG4fusApaMecw9Lizdp2NPUvpYx5wWl6E2TRwjGzDfJ3HWeS6fhHhoN6XozX?= =?utf-8?q?67DYvZX0J4lTpvi5IhVr+jVyZRWaEYW4x7bVIkU39cjvF+/6BAq02Ua4UlZJeIDtC?= =?utf-8?q?zQpSa5VwiAA402f+2x5s65DvpBm0McJ2N3PYBcDnqzR5VhBn7AZAKKelo1p9Rjvqm?= =?utf-8?q?99fc4wS7fJxgTUCB0r6G0jcUpuobpRHUkQHLPWXsEge0r/DWbYK5vb2xfo4uXlzWr?= =?utf-8?q?jPO76xzdszRmkfqB9zPTKDnOvfYxC6DR89qXa8QqcNn39pVuIl+k4yxEnp+Yn3rZx?= =?utf-8?q?6zUY2OX3wEIyickNQmO0ObmjqfFj7CidE7XsI/LfapTZPZkJXGy1ow/nHHhjlxGY0?= =?utf-8?q?53bQB8uiwwHLmT0H7LeV1RiwR0DMFJNgFI+JR7R+gAaV+ldCIs21hzaSmyMt/Te/x?= =?utf-8?q?MoneYtLwSCpewh125RLPCfU9+eYS2bJ18uKYDa7BU4yPD7JrcUH+6Hs5i+yFs9qIj?= =?utf-8?q?x5KTxyblSKL9/Z8o7nnuyM+6sEwb6BG+8h/hapQjWSJkOuCBTJaAVkgwM5Z9p63rp?= =?utf-8?q?DqvJWktAd207TcE6LomFHJtk5U0a51iN4Ma9sfIW09r1poTgJDg0jeB858NY3eV+v?= =?utf-8?q?MBFggf+eaeYnnmldW42ijoAfOsGGLWRju6HMCHPgM72NtVHkxRHyXmROfX9eWqkxp?= =?utf-8?q?D8Dt0nzF3PgVX7tDxc0KgsdtBpJf/WCYHuBMev/u382MjWMEQWLHV4Bst7ZH+eTXU?= =?utf-8?q?h0FCRsBoo/gChEQdiyTmc4mST6PviQhp58P+CCW78eEpvMM45FjHgjf/UWyP9XEcr?= =?utf-8?q?nRjd0ye+dSakgLBzf0bpZ+EiOmPLIkK+BvTGNa06lpAuEVoUzcf0ac6VnpnAaolHb?= =?utf-8?q?6ZJNkfQaIcL4kDtzbo0534u+pWL6er83hS8aLEgZxPsHUJPxGwvaiilrpTUXu42fS?= =?utf-8?q?74jlrrIGa2W1654vOsX20UvTuCtz95kpU/xgsH5ClYzyidVonBRI8UrRyjwjtRv62?= =?utf-8?q?XA28gRPoFWrvGRtQytKahsER5+LSY7VtkWMXbWj8QQXWVd7Fx0iYMUpgSq9FEBXtY?= =?utf-8?q?+6bIuusnAFYKD0V9SFdxBvHbEJBr4Kpm8LwhEi3h8VNz9cLjAVY9dbofnmXTV8onk?= =?utf-8?q?O0Su4dm7CSNmVeZdv/aqT23G3n7uqcKAA5/mkuyGCq+zCq+h8mA0gM+mryAVzn9I/?= =?utf-8?q?W15l+Y02Ia5PUlQdhPDOaacovtcEnEvCHQVSLODez1AFuGVMqVboT8nNEKyecRIkM?= =?utf-8?q?ch108G3ujs+kgePMmOn7nHltFkdU3eYvF5WuCmtorhz/4v66rrEjtLzsIlAmDJydu?= =?utf-8?q?SvsQZ63Y7Z+9knvcEpHYQONhtquXw5QRIcRsNWMkPaUraMsy2FaV48RxSPR79pOLv?= =?utf-8?q?q5qWDmF8sb+C3WXQ+RamwJy4kcJHSDlCeDtmfIRtXWcO4SUYqLtNZ4292B6HKFPRk?= =?utf-8?q?W9wrW85wK/gHycOE/ofCE5FohQZ7WOKW0/FuFopTtBGSsQ9GB5uRjK9z5X6OTKHm7?= =?utf-8?q?WQR0QnwW8rws?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74570109-ed36-44bc-3170-08db9757d2f0 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:06:06.0954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lnUZmCQtDln8h5qbZsvP6XchfRgJbgT4eu1qb+PGpLo/6QQUN+rKD7z/SkJsf5GJGHjj7Bo1jviBBglP4+MvJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7590 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is no real reasons to keep these function in the header file. Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/data_tx.c | 18 ++++++++++++++++++ drivers/net/wireless/silabs/wfx/data_tx.h | 19 ++----------------- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/net/wireless/silabs/wfx/data_tx.c b/drivers/net/wireless/silabs/wfx/data_tx.c index 6a5e52a96d183..ce2b5dcfd8d89 100644 --- a/drivers/net/wireless/silabs/wfx/data_tx.c +++ b/drivers/net/wireless/silabs/wfx/data_tx.c @@ -208,6 +208,24 @@ static bool wfx_is_action_back(struct ieee80211_hdr *hdr) return true; } +struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb) +{ + struct ieee80211_tx_info *tx_info; + + if (!skb) + return NULL; + tx_info = IEEE80211_SKB_CB(skb); + return (struct wfx_tx_priv *)tx_info->rate_driver_data; +} + +struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb) +{ + struct wfx_hif_msg *hif = (struct wfx_hif_msg *)skb->data; + struct wfx_hif_req_tx *req = (struct wfx_hif_req_tx *)hif->body; + + return req; +} + static u8 wfx_tx_get_link_id(struct wfx_vif *wvif, struct ieee80211_sta *sta, struct ieee80211_hdr *hdr) { diff --git a/drivers/net/wireless/silabs/wfx/data_tx.h b/drivers/net/wireless/silabs/wfx/data_tx.h index 983470705e4bb..a5b80eacce39a 100644 --- a/drivers/net/wireless/silabs/wfx/data_tx.h +++ b/drivers/net/wireless/silabs/wfx/data_tx.h @@ -45,22 +45,7 @@ void wfx_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control, struc void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct wfx_hif_cnf_tx *arg); void wfx_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u32 queues, bool drop); -static inline struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb) -{ - struct ieee80211_tx_info *tx_info; - - if (!skb) - return NULL; - tx_info = IEEE80211_SKB_CB(skb); - return (struct wfx_tx_priv *)tx_info->rate_driver_data; -} - -static inline struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb) -{ - struct wfx_hif_msg *hif = (struct wfx_hif_msg *)skb->data; - struct wfx_hif_req_tx *req = (struct wfx_hif_req_tx *)hif->body; - - return req; -} +struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb); +struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb); #endif