@@ -478,13 +478,14 @@ static int mt7996_add_interface(struct ieee80211_hw *hw,
for (i = 0; i < MT7996_MAX_RADIOS; i++) {
struct mt7996_phy *phy = dev->radio_phy[i];
- if (!phy || !(wdev->radio_mask & BIT(i)) ||
- test_bit(MT76_STATE_RUNNING, &phy->mt76->state))
+ if (!phy || !(wdev->radio_mask & BIT(i)))
continue;
- err = mt7996_run(phy);
- if (err)
- goto out;
+ if (!test_bit(MT76_STATE_RUNNING, &phy->mt76->state)) {
+ err = mt7996_run(phy);
+ if (err)
+ goto out;
+ }
if (vif->type == NL80211_IFTYPE_MONITOR)
mt7996_set_monitor(phy, true);
This path was being skipped if, for example, a monitor was created on a phy which already contained a station. Fixes: 69d54ce7491d ("wifi: mt76: mt7996: switch to single multi-radio wiphy") Signed-off-by: Rory Little <rory@candelatech.com> --- drivers/net/wireless/mediatek/mt76/mt7996/main.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)