From patchwork Fri Mar 3 06:00:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 94819 Delivered-To: patch@linaro.org Received: by 10.140.82.71 with SMTP id g65csp97118qgd; Thu, 2 Mar 2017 23:09:34 -0800 (PST) X-Received: by 10.98.108.196 with SMTP id h187mr1610407pfc.176.1488524974178; Thu, 02 Mar 2017 23:09:34 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7si9727883pll.64.2017.03.02.23.09.33; Thu, 02 Mar 2017 23:09:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdCCHJc (ORCPT + 25 others); Fri, 3 Mar 2017 02:09:32 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:34681 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbdCCHJa (ORCPT ); Fri, 3 Mar 2017 02:09:30 -0500 Received: by mail-pg0-f43.google.com with SMTP id 16so6731960pga.1 for ; Thu, 02 Mar 2017 23:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=rtkcNR3xnja9pxtByfMQJbiB7t9qmmZuEzey5zcQi/E=; b=ZwGxkoUaihAJ0zbHRmVqXDYW7FvEhFaA8ir6VbKh1o6rYJ9tsNnRZ5x91mjowiJNbL /k1vfbT7SpyCnB3dWBOS37LCJGdeOIShjkYu24cSKq0bYw1CRzG00H8VmYpIJTNlbvxC uZ13PM3zjefKKCBuR+md2WwssOTlNmjT2gX0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rtkcNR3xnja9pxtByfMQJbiB7t9qmmZuEzey5zcQi/E=; b=ulgQzsVCI8EN5LdV5zFn/ksM05cT3XRsZSY6GAiCMroqzBLwAZzrFpm87dekzfD0rT k+1ZXmvtpPJ/lUYuSuLgdBbmr0uN46JfPx/RC/9xBadXcoUIMQbavHs/ng4eEFTUSO0p pECKMOTBqSFekXg4OXKoTdZ9U2ET+VFq3X4XAP+4kGeqiLEI4pCRz51uqltcUJwIfCdw 04EvhCtS+3ns/T5doQ90nsPG0JdlcGfSmr1TbqifCYcfQHeO8KF8yxmDD1wDj/2/wNKN p/BcotxyPNgVezNeB+2d2jWvU1vdXbWpoepXDfAknkl5bo6Q/1f5YDdcU6gwV2H0RWa9 lfCA== X-Gm-Message-State: AMke39kLpTN1Lil1SQFStZrKlnxlOykL96SbCHeUs8YAB1fFPiy1fbMiNsoLbMsa3ZTTgpU4 X-Received: by 10.99.168.76 with SMTP id i12mr1336435pgp.73.1488520831727; Thu, 02 Mar 2017 22:00:31 -0800 (PST) Received: from localhost.localdomain (61-216-91-114.HINET-IP.hinet.net. [61.216.91.114]) by smtp.gmail.com with ESMTPSA id s13sm20541405pfk.26.2017.03.02.22.00.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 02 Mar 2017 22:00:30 -0800 (PST) From: Leo Yan To: Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Mathieu Poirier , John Stultz , Guodong Xu , Haojian Zhuang , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mike.leach@linaro.org Cc: Leo Yan Subject: [PATCH v3 0/5] coresight: enable debug module Date: Fri, 3 Mar 2017 14:00:04 +0800 Message-Id: <1488520809-31670-1-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The Sample-based Profiling Extension" has description for sampling registers, we can utilize these registers to check program counter value with combined CPU exception level, secure state, etc. So this is helpful for CPU lockup bugs, e.g. if one CPU has run into infinite loop with IRQ disabled; the 'hang' CPU cannot switch context and handle any interrupt, so it cannot handle SMP call for stack dump, etc. This patch series is to enable coresight debug module with sample-based registers and register call back notifier for PCSR register dumping when panic happens, so we can see below dumping info for panic; and this patch series has considered the conditions for access permission for debug registers self, so this can avoid access debug registers when CPU power domain is off; the driver also try to figure out the CPU is in secure or non-secure state. The last two patches in this series is to enable debug unit on 96boards Hikey, the first patch is to add apb clock for debug unit and the second patch is to add DT nodes for debug unit. As result we can below log after input command: echo c > /proc/sysrq-trigger: ARM external debug module: CPU[0]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [] handle_IPI+0xe4/0x150 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) CPU[1]: EDPRSR: 0000000b (Power:On DLK:Unlock) EDPCSR: [] debug_notifier_call+0x108/0x288 EDCIDSR: 00000000 EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) [...] Changes from v2: * According to Mathieu Poirier suggestion, applied some minor fixes. * Added two extra patches for enabling debug module on Hikey. Changes from v1: * According to Mike Leach suggestion, removed the binding for debug module clocks which have been directly provided by CPU clocks. * According to Mathieu Poirier suggestion, added function of_coresight_get_cpu() and some minor refactors for debug module driver. Changes from RFC: * According to Mike Leach suggestion, added check for EDPRSR to avoid lockup; added supporting EDVIDSR and EDCIDSR registers. * According to Mark Rutland and Mathieu Poirier suggestion, rewrote the documentation for DT binding. * According to Mark and Mathieu suggestion, refined debug driver. Leo Yan (5): coresight: bindings for debug module coresight: refactor with function of_coresight_get_cpu coresight: add support for debug module clk: hi6220: add debug APB clock arm64: dts: hi6220: register debug module .../devicetree/bindings/arm/coresight-debug.txt | 40 +++ arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 ++++ drivers/clk/hisilicon/clk-hi6220.c | 1 + drivers/hwtracing/coresight/Kconfig | 10 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-debug.c | 377 +++++++++++++++++++++ drivers/hwtracing/coresight/of_coresight.c | 37 +- include/dt-bindings/clock/hi6220-clock.h | 5 +- include/linux/coresight.h | 2 + 9 files changed, 524 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/coresight-debug.txt create mode 100644 drivers/hwtracing/coresight/coresight-debug.c -- 2.7.4